Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3776878rwb; Tue, 16 Aug 2022 08:35:02 -0700 (PDT) X-Google-Smtp-Source: AA6agR6BsB+LfYbcZZwp3K4vUif0FMc8KGucqvbUecFk5JBmovz16Zt/5/Er9eF4aUpWUMsJEUDs X-Received: by 2002:a17:906:fd84:b0:730:acee:d067 with SMTP id xa4-20020a170906fd8400b00730aceed067mr14003961ejb.206.1660664102390; Tue, 16 Aug 2022 08:35:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660664102; cv=none; d=google.com; s=arc-20160816; b=aq8InNP8BuYWYudmNqoGdYyFPzBV200qgs1DscbpqmMwqxxTa3dyoCGHB7JxBV//uT gio+kSEdObgfA9BqavmuxGkE7WA5Nu8K5DCdtoX+hVfSfJlufGZtq82u44MAi4xvqkYt 5NAP59WPj7O613CVS7osWfRJ8O5l2JlD5IgdUmb3S74BpXlixTVxHaRVp4XxmuetAIC+ D3FGvMwGKttM+BJayHn6sLevvKo936fDIahQXBebyslzoRWbj8m44jXzsAb94oyCSaoP IeY+XQmjRwNKRjQ0e+nzswHHHcmKdorMYAC+Dua+L7UR5IFJvMyzGb/sVgZZ774fC+Sf Voow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=sG6JmlG17+RjrinKjozLfFn8f42hxst+1J+nx9+sCMg=; b=NExnsKx0pr9xHLwFhbLKWZX6+XFCTfhM9rFdMjx7q2c75u9guz/18CzaE762PfqGh9 BCthAWfS9/u7B0Syb/1U+UuaJm82Fjf5QpbEJYf1ErYzkZgICFoFNf4IaZkatDpVOVHP qsD+zW05uHLYypGEkgYdLkcIKGGenqH8ibxR+294rU9mkZtQo/nxCQ9y7G5yZKSzmOE1 66TJVYfpn85jFHlKvDta4hvam631JOPVPUy06kYNr+RNXEVjpH6u49daarr+Ly2mkcpw ZJMdtAUrazNN4bFuKxDi0Gn/7i0oVh0Cb1KqP4jIUEGghazULrxUg/F2mryABZBNos5d ugQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hs20-20020a1709073e9400b0073305fd2278si10776106ejc.864.2022.08.16.08.34.35; Tue, 16 Aug 2022 08:35:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234899AbiHPPZ1 (ORCPT + 99 others); Tue, 16 Aug 2022 11:25:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236074AbiHPPZA (ORCPT ); Tue, 16 Aug 2022 11:25:00 -0400 Received: from smtp.smtpout.orange.fr (smtp03.smtpout.orange.fr [80.12.242.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D76D3F7 for ; Tue, 16 Aug 2022 08:24:49 -0700 (PDT) Received: from pop-os.home ([90.11.190.129]) by smtp.orange.fr with ESMTPA id NyQxoTzZrBDYDNyQxoNv3a; Tue, 16 Aug 2022 17:24:48 +0200 X-ME-Helo: pop-os.home X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Tue, 16 Aug 2022 17:24:48 +0200 X-ME-IP: 90.11.190.129 From: Christophe JAILLET To: Diana Craciun , Alex Williamson , Cornelia Huck Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET , kvm@vger.kernel.org Subject: [PATCH v2] vfio/fsl-mc: Fix a typo in a message Date: Tue, 16 Aug 2022 17:24:46 +0200 Message-Id: <3d2aa8434393ee8d2aa23a620e59ce1059c9d7ad.1660663440.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org L and S are swapped in the message. s/VFIO_FLS_MC/VFIO_FSL_MC/ Also use WARN instead of WARN_ON+dev_warn because WARN can already print the message. Signed-off-by: Christophe JAILLET --- Changes in v2: * s/comment/message/ in the subject [Cornelia Huck ] * use WARN instead of WARN_ON+dev_warn [Jason Gunthorpe ] v1: https://lore.kernel.org/all/2b65bf8d2b4d940cafbafcede07c23c35f042f5a.1659815764.git.christophe.jaillet@wanadoo.fr/ --- drivers/vfio/fsl-mc/vfio_fsl_mc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/vfio/fsl-mc/vfio_fsl_mc.c b/drivers/vfio/fsl-mc/vfio_fsl_mc.c index 3feff729f3ce..57774009e0eb 100644 --- a/drivers/vfio/fsl-mc/vfio_fsl_mc.c +++ b/drivers/vfio/fsl-mc/vfio_fsl_mc.c @@ -108,9 +108,7 @@ static void vfio_fsl_mc_close_device(struct vfio_device *core_vdev) /* reset the device before cleaning up the interrupts */ ret = vfio_fsl_mc_reset_device(vdev); - if (WARN_ON(ret)) - dev_warn(&mc_cont->dev, - "VFIO_FLS_MC: reset device has failed (%d)\n", ret); + WARN(ret, "VFIO_FSL_MC: reset device has failed (%d)\n", ret); vfio_fsl_mc_irqs_cleanup(vdev); -- 2.34.1