Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp3792779rwb; Tue, 16 Aug 2022 08:51:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR7uuacYIhCqtSxmZuqp9Bf4M1lU/CXFl8A8V0t+YkTZhPS9N0kcZWr24Fs3asAJI7iNkENi X-Received: by 2002:a17:907:3e93:b0:730:a92b:e7e1 with SMTP id hs19-20020a1709073e9300b00730a92be7e1mr14223919ejc.621.1660665095525; Tue, 16 Aug 2022 08:51:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660665095; cv=none; d=google.com; s=arc-20160816; b=eMDNT7gh48HBXgJAW5/M4W8LnuPjy1v4nMJlr9EdDGLprX+XswlYpNfhUsOjlSrpBu PtDwuCnG/L4FAyOhdSBxBtELlwiE+qn0IrWH4SAgrs04u5MHH5VP1tCBtat37Pa8lNwO IPsxvcxiK8yXyqz6JSTGB8Ue9zgruZSHHNqTwptbTOkpaGiYB3akMZPNUc6T3A102O/d gdRJFL2l2gGSYFlG+lP9kGQBsLPeXtrIeLkOsqBsv42VwjIJl12dd3NL/VxYA1ubF7Ku vzwhv/Wlu2EtQ1EexNqijjm4GPcLXYi87gswxgMevEoqYovX70PFwO0nwW1BdEzU4mZ9 7H7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=pWiiBzmFyODb6P+yd623tp6I2C0aXhIGggrBAjalXf0=; b=WlerKwk4eNuz2urzTrBK+8bdWHqIKqglvfaG5u2CU8staWA86DSol71NGR2ZY2/TlH 7avEqKMfrjDtEZjqHgeK1XNXSWv9v89SLZVCZXMUBPrKZCFLwiE0V76ZZT5DmdoRyqdt qb+/nFIw+gyI7ci/O2WzKS7Gpnv7s8DcmvLVYTa3F1d8mUnNbZ5U1RO7sOMWq8/e+vTX WnVGg9D46PytTEYBbPFsHOrgyDfwaLIUcYO3oaw5pLben5kX2FLWpyYssbXJJNMnEsdQ Tngut5+QAPM82jJS2VNUHi6d46UaY8ZcB/kv/Fk+scVkR5HywVvxppeFdhpWXn/UKlCl M14Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="a/+u+DU3"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp5-20020a1709073e0500b0072a8fcb3683si11059899ejc.20.2022.08.16.08.51.09; Tue, 16 Aug 2022 08:51:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b="a/+u+DU3"; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236250AbiHPPiy (ORCPT + 99 others); Tue, 16 Aug 2022 11:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235634AbiHPPiG (ORCPT ); Tue, 16 Aug 2022 11:38:06 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2AA5465242 for ; Tue, 16 Aug 2022 08:37:04 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DE4BA1FE97; Tue, 16 Aug 2022 15:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1660664222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pWiiBzmFyODb6P+yd623tp6I2C0aXhIGggrBAjalXf0=; b=a/+u+DU3xE24Mp/ygWTJ4R/nku3VMnegxB1ruMCZ4aB3pS90d6hKGrkeFi1lN4veZ4OkrF Y1enCN7zXnSmHc3oAXDgfNInuylTVF9dlltI084JgAiWfml9uSwU9kcNtXhjoVyO8ozp2g eTaSoTAbLfl70sKpXQ9LmXPzU+wud60= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1660664222; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pWiiBzmFyODb6P+yd623tp6I2C0aXhIGggrBAjalXf0=; b=RzZ7K07VUnWMIwpGAYwwxAx2FwZleJkGBLOgZvGlcXurz3gCsAAA975NqqqGFphA2JtCjo OFTkVAWojTUQM2BA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9F783139B7; Tue, 16 Aug 2022 15:37:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qOkpJp65+2LKJAAAMHmgww (envelope-from ); Tue, 16 Aug 2022 15:37:02 +0000 From: Takashi Iwai To: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/12] drm/udl: Increase the default URB list size to 20 Date: Tue, 16 Aug 2022 17:36:49 +0200 Message-Id: <20220816153655.27526-7-tiwai@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220816153655.27526-1-tiwai@suse.de> References: <20220816153655.27526-1-tiwai@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It seems that the current size (4) for the URB list is too small on some devices, and it resulted in the occasional stalls. Increase the default URB list size to 20 for working around it. Signed-off-by: Takashi Iwai --- drivers/gpu/drm/udl/udl_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c index 6aed6e0f669c..2b7eafd48ec2 100644 --- a/drivers/gpu/drm/udl/udl_main.c +++ b/drivers/gpu/drm/udl/udl_main.c @@ -20,7 +20,7 @@ #define NR_USB_REQUEST_CHANNEL 0x12 #define MAX_TRANSFER (PAGE_SIZE*16 - BULK_SIZE) -#define WRITES_IN_FLIGHT (4) +#define WRITES_IN_FLIGHT (20) #define MAX_VENDOR_DESCRIPTOR_SIZE 256 static int udl_parse_vendor_descriptor(struct udl_device *udl) -- 2.35.3