Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 Aug 2022 18:48:30 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Kevin Lu <luminlong@139.com>
Cc:     linux-kernel@vger.kernel.org, shenghao-ding@ti.com, kevin-lu@ti.com
Subject: Re: [PATCH v1 1/1] sound: Add a new kcontrol
Message-ID: <YvvYbkDSodLBkD0R@sirena.org.uk>
References: <20220815112715.21617-1-luminlong@139.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="XfXYlpbAJLpIqcAb"
Content-Disposition: inline
In-Reply-To: <20220815112715.21617-1-luminlong@139.com>
Precedence: bulk


--XfXYlpbAJLpIqcAb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Aug 15, 2022 at 07:27:15PM +0800, Kevin Lu wrote:
> Add a new kcontrol for phase calib

This looks mostly good now - one small issue below which I'll fix up
myself and apply.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

> +	ADCX140_PHASE_CALIB_SWITCH("Adcx140 Phase Calib Switch"),

We wouldn't normally put the CODEC name in the control name, it's not
really relevant to users and if some disambiguation is needed it's
usually better to do it in a board specific way (eg, describing the
output the CODEC is connected to) using the support ASoC has for adding
prefixes.  Better would be "Phase Callibration Switch".

--XfXYlpbAJLpIqcAb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmL72G4ACgkQJNaLcl1U
h9Ca0wf/XQssZO8ZQOX6JyoFp4Z1CVs4uZOwqeWylT4J6B8nCgcGCjl9ct5BVMhN
I3KTKUtW0utYNhtaT1VcQ5l/ufMxXWoG9xv4KWa081bBM8qY7VGfMAV6McK2Z93f
aY9CxZnr+3WURXKVO1kpi+ZKKffNup4hPNgSJ+a9+UOjAioGrjT7Zqs7Z0U40/XF
3AYkbqXVIBTbMP7sDOoFu0dOqrNix5e/KLIrkkUDRZBrkWjwcp0jo05J9jFc7PdV
RXFfJ3Af1EfSEHS719e0LUHolccdtzZqH6SXIgVee6YoY229oaQO06cl5Xi6ugAA
Ns+nepN6aFUBkzXDsFA8kIRBFgi/hw==
=EuU3
-----END PGP SIGNATURE-----

--XfXYlpbAJLpIqcAb--