Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH v2 1/6] dt-bindings: PCI: fu740-pci: fix missing
 clock-names
From:   Jessica Clarke <jrtc27@jrtc27.com>
In-Reply-To: <20220816182547.3454843-2-mail@conchuod.ie>
Date:   Tue, 16 Aug 2022 22:05:55 +0100
Cc:     Daire McNamara <daire.mcnamara@microchip.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Greentime Hu <greentime.hu@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Conor Dooley <conor.dooley@microchip.com>,
        linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <F62BE8A7-2023-497B-9BBC-AE54E7C5B08A@jrtc27.com>
References: <20220816182547.3454843-1-mail@conchuod.ie>
 <20220816182547.3454843-2-mail@conchuod.ie>
To:     Conor Dooley <mail@conchuod.ie>
Precedence: bulk

On 16 Aug 2022, at 19:25, Conor Dooley <mail@conchuod.ie> wrote:
>=20
> From: Conor Dooley <conor.dooley@microchip.com>
>=20
> The commit b92225b034c0 ("dt-bindings: PCI: designware: Fix
> 'unevaluatedProperties' warnings") removed the clock-names property as
> a requirement and from the example as it triggered unevaluatedProperty
> warnings. dtbs_check was not able to pick up on this at the time, but
> now can:
>=20
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dtb: pcie@e00000000: =
Unevaluated properties are not allowed ('clock-names' was unexpected)
>        =46rom schema: =
linux/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
>=20
> The property was already in use by the FU740 DTS and the clock must be
> enabled. The Linux driver does not use this property, but outside of
> the kernel this property may have users. Re-add the property and its
> "clocks" dependency.

Are you sure about this? I see a devm_clk_get("pcie_aux") that surely
won't without the property. FreeBSD=E2=80=99s similarly relies on the =
name,
though it also has a fallback to the U-Boot pcieaux name (because the
world is terrible and people can=E2=80=99t even agree on that) so it =
works
with the U-Boot-provided FDT (it would be nice if Linux had this as a
goal, and people worked with U-Boot devs to get everything needed for
newly-exposed devices merged back there so I don=E2=80=99t have to be =
the one
to notice and do it...).

Jess

> Fixes: b92225b034c0 ("dt-bindings: PCI: designware: Fix =
'unevaluatedProperties' warnings")
> Fixes: 43cea116be0b ("dt-bindings: PCI: Add SiFive FU740 PCIe host =
controller")
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> v2022.08 of dt-schema is required.
> ---
> .../devicetree/bindings/pci/sifive,fu740-pcie.yaml          | 6 ++++++
> 1 file changed, 6 insertions(+)
>=20
> diff --git =
a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml =
b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
> index 195e6afeb169..c7a9a2dc0fa6 100644
> --- a/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
> @@ -51,6 +51,12 @@ properties:
>     description: A phandle to the PCIe power up reset line.
>     maxItems: 1
>=20
> +  clocks:
> +    maxItems: 1
> +
> +  clock-names:
> +    const: pcie_aux
> +
>   pwren-gpios:
>     description: Should specify the GPIO for controlling the PCI bus =
device power on.
>     maxItems: 1
> --=20
> 2.37.1
>=20
>=20
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv