Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220815063555.1384505-1-pmalani@chromium.org>
 <20220815063555.1384505-5-pmalani@chromium.org> <YvsnE55zGVGxGpPv@google.com>
In-Reply-To: <YvsnE55zGVGxGpPv@google.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Tue, 16 Aug 2022 14:45:24 -0700
Message-ID: <CACeCKacHM7rOCziEXqRW7G24cgTi--vo76NrkCjwauxG4WbXDA@mail.gmail.com>
Subject: Re: [PATCH v5 4/7] platform/chrome: cros_typec_switch: Add event check
To:     Tzung-Bi Shih <tzungbi@kernel.org>
Cc:     linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
        bleung@chromium.org, Daisuke Nojiri <dnojiri@chromium.org>,
        "Dustin L. Howett" <dustin@howett.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Guenter Roeck <groeck@chromium.org>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Xiang wangx <wangxiang@cdjrlc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Aug 15, 2022 at 10:11 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
>
> On Mon, Aug 15, 2022 at 06:34:24AM +0000, Prashant Malani wrote:
> > The Chrome EC updates Type-C status events when mux set requests from
>
> To be consistent to the series, I guess you would like to use ChromeOS
> instead of Chrome?

Fixed in v6.

>
> > +static int cros_typec_send_clear_event(struct cros_typec_switch_data *sdata, int port_num,
> > +                                    u32 events_mask)
> > +{
> [...]
> > +     return cros_ec_cmd(sdata->ec, 0, EC_CMD_TYPEC_CONTROL, &req,
> > +                        sizeof(req), NULL, 0);
>
> The line can join to the previous line without exceeding col-100.
Fixed in v6.