Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4125265rwb; Tue, 16 Aug 2022 15:11:41 -0700 (PDT) X-Google-Smtp-Source: AA6agR6Z2bUypE5X/9DXql3It67g0wW5lYwE+pfSm/5Meyd+fPJUM0PwJ6Ac6uLcFzplG/jaPvX1 X-Received: by 2002:a05:6402:50ce:b0:43d:559d:43f4 with SMTP id h14-20020a05640250ce00b0043d559d43f4mr20128213edb.325.1660687901148; Tue, 16 Aug 2022 15:11:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660687901; cv=none; d=google.com; s=arc-20160816; b=TCZj5FgIfAxq0lc/iKCsGn2z8F3d7ism0Wt9knmSL6gE7rSkFpcV89nZISOwES4+v7 +vnbTLcUlY8fR5Fb0w29NZJ5mdZ+RDeUoR2kTF2HYNS5irkGyFEcvnUFgPiLyef4iI1t DmWKg2fVnXjpNx/t4cMfgTs7/a+QOE8Gf+E26rRV2Z/Q3nwgQdeLZtkiqTDB8jNVvZyB 4wU7xHqqNf8tSCgdiLQXmt392mBWr6ADzXjjS8ZuFoy80gnx5MNxj8lJp2mjO4nvfAWV xDMi00La6WolDcbShRTVEhLOvN2nrrmXEgFDYj9ttvkLQ850pz/jPvZPJ1qOq77OhnA0 UQJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=gQVd09TKBoK8myxx9+Kk6j7arplddUDBcJdpPSvQ9N0=; b=V0IInzaAs+6PHdEPU9TUaaxB6rhqPG2b6UVQny5VqkBebRqOKp+5LwzAJe5pd0Pa+G rxk2x0Ylv1CSLGqxX3aZ+A5mGWN2A/Ncqq6xgrinu14m7IRLRcz1ynWkvJVu+u5IJegO A/Rlpx95EdMRWPlnjfhY7inMiGVRTxyIencts+qAiuO5LrzYnH7L/sDOzBym0b+zsal9 1WYIhqc5EINwhXHkHYeWFcg41Xwe4bqDBd2z1NjXxw5/JATdfFF07LMZ4YVnzn5ifR2L Nsi2mI/xNCrAvohNQPx/l5Lb995SYh/XDGyBhv2a1+rgNOUBeiW+35tQa2jjAzZu7GGR 8v8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=crCJwXLm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w9-20020a05640234c900b0043d62064bc8si12786680edc.231.2022.08.16.15.11.15; Tue, 16 Aug 2022 15:11:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=crCJwXLm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236658AbiHPVIZ (ORCPT + 99 others); Tue, 16 Aug 2022 17:08:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbiHPVIW (ORCPT ); Tue, 16 Aug 2022 17:08:22 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ADE611471 for ; Tue, 16 Aug 2022 14:08:20 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id kb8so21215786ejc.4 for ; Tue, 16 Aug 2022 14:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=gQVd09TKBoK8myxx9+Kk6j7arplddUDBcJdpPSvQ9N0=; b=crCJwXLmEvPMSm86Sva0Xcmf7BIt21WtW9u2OR1PDBYvlSd51fDec13ktq12ylm07b V0p3KlPOXf0y0uvfPWHzB5Fi5UGStHw84wFGZ0/34v9Jsko1jcibPEgCTQbs0r+dPtqy ywy2yuLbLNxvViCfjVJ3CnvYRmZdM9BpyL69w7bpxMZxM16gfr4EoGrv6fkNZkRokDMz rucbT153NSZdeUtCGXQEegLHjsMLOsBeGxEKyzcArzDELv+MrxYoIOgsyM4Co3luz2DB 2WO9yapIUjoqORrmUgWUiqNwehZ55xN6IcmPwOqxUV/sVXFYqrQ0BEA0CnSIdf63s+wD HPvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=gQVd09TKBoK8myxx9+Kk6j7arplddUDBcJdpPSvQ9N0=; b=7jkCqQ8fmdpCK0+6jKsLcs0EiziDxhSf/oYdaQZT2kk02B6q5Rd/k48qmF+y+LAVGz hT3DfIHrRUCyHrau9jBTucSUbV1tkKiRaemtBIRtEweHN9hFSlV89pf7ZXZ6VG6f5qky dUjp/MIdis/qmo5DAYZ+TJHKE8fKQv8NDR+rybbfUDZi+0LTGFQYF6W1hmW6EjT/9QCq IYLg3nrVNGYESzQeuy075o3FkIPsxhMqCsBXFV1jt56HTmoKXgd15hshuDLChlimegU3 ApXulGUGWLOTRxc+QZUCBYzfq0Krv5jst0MuurqY4FUBIW88gBmLTtk8PBo1Mazzr0mn kJMw== X-Gm-Message-State: ACgBeo1MAe0OOqMIapF1VJLnF3CzKIIMgepCGgwo/wKSFB6bgffliF5e siIQGEnhqzn4XBAOmcK/cwt73D5ESvwyWMZnVLXkUeQcmp0= X-Received: by 2002:a17:907:9628:b0:731:1e3:b168 with SMTP id gb40-20020a170907962800b0073101e3b168mr15114815ejc.526.1660684098677; Tue, 16 Aug 2022 14:08:18 -0700 (PDT) MIME-Version: 1.0 References: <20220815091929.130547-1-brgl@bgdev.pl> In-Reply-To: <20220815091929.130547-1-brgl@bgdev.pl> From: Linus Walleij Date: Tue, 16 Aug 2022 23:08:07 +0200 Message-ID: Subject: Re: [PATCH] gpio: pxa: use devres for the clock struct To: Bartosz Golaszewski Cc: Robert Jarzmik , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot , Yuan Can Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 15, 2022 at 11:19 AM Bartosz Golaszewski wrote: > The clock is never released after probe(). Use devres to not leak > resources. > > Reported-by: Hulk Robot > Reported-by: Yuan Can > Signed-off-by: Bartosz Golaszewski Reviewed-by: Linus Walleij Yours, Linus Walleij