Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 Aug 2022 22:50:10 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Maxim Levitsky <mlevitsk@redhat.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, vkuznets@redhat.com
Subject: Re: [PATCH v2 1/9] KVM: x86: check validity of argument to
 KVM_SET_MP_STATE
Message-ID: <YvwfIgoN4a1xOJL/@google.com>
References: <20220811210605.402337-1-pbonzini@redhat.com>
 <20220811210605.402337-2-pbonzini@redhat.com>
 <26f6e26110b99e0a8cace173a221694d4e94cc1c.camel@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <26f6e26110b99e0a8cace173a221694d4e94cc1c.camel@redhat.com>
Precedence: bulk

On Mon, Aug 15, 2022, Maxim Levitsky wrote:
> On Thu, 2022-08-11 at 17:05 -0400, Paolo Bonzini wrote:
> > An invalid argument to KVM_SET_MP_STATE has no effect other than making the
> > vCPU fail to run at the next KVM_RUN.? Since it is extremely unlikely that
> > any userspace is relying on it, fail with -EINVAL just like for other
> > architectures.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > ?arch/x86/kvm/x86.c | 20 +++++++++++++++++---
> > ?1 file changed, 17 insertions(+), 3 deletions(-)
> > 
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index 132d662d9713..c44348bb6ef2 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> > @@ -10653,7 +10653,8 @@ static inline int vcpu_block(struct kvm_vcpu *vcpu)
> > ????????case KVM_MP_STATE_INIT_RECEIVED:
> > ????????????????break;
> > ????????default:
> > -???????????????return -EINTR;
> > +???????????????WARN_ON(1);
> 
> Very small nitpick: Maybe WARN_ON_ONCE after all??

+1, I don't think warning multiple times would help triage/debug, and this seems
like something that will fire a lot if it fires at all.