Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <299a0328-9d93-74ca-a2b2-114dfd896056@infradead.org>
Date:   Tue, 16 Aug 2022 15:36:32 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] docs: admin-guide/mm: Improve grammar on MM concepts
 documentation
Content-Language: en-US
To:     alexlzhu@fb.com, corbet@lwn.net, bobwxc@email.cn, rppt@kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        Kernel-team@fb.com
References: <20220816022621.253778-1-alexlzhu@fb.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220816022621.253778-1-alexlzhu@fb.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi--

On 8/15/22 19:26, alexlzhu@fb.com wrote:
> From: Alexander Zhu <alexlzhu@fb.com>
> 
> Improve grammar on MM concepts documentation.
> 
> Signed-off-by: Alexander Zhu <alexlzhu@fb.com>
> ---
>  Documentation/admin-guide/mm/concepts.rst | 138 +++++++++++-----------
>  1 file changed, 68 insertions(+), 70 deletions(-)
> 
> diff --git a/Documentation/admin-guide/mm/concepts.rst b/Documentation/admin-guide/mm/concepts.rst
> index c79f1e336222..c471f80b7a38 100644
> --- a/Documentation/admin-guide/mm/concepts.rst
> +++ b/Documentation/admin-guide/mm/concepts.rst

[snip]

> -Depending on the page usage it is treated differently by the Linux
> -memory management. The pages that can be freed at any time, either
> -because they cache the data available elsewhere, for instance, on a
> -hard disk, or because they can be swapped out, again, to the hard
> +Depending on page usage it is treated differently by the Linux
> +memory management subsystem. Pages that can be freed at any time,
> +either because they cache the data available elsewhere
> +(ie on a hard disk) or because they can be swapped out to the hard

   (i.e., on a hard disk)

>  disk, are called `reclaimable`. The most notable categories of the
>  reclaimable pages are page cache and anonymous memory.
>  

[snip]

>  
>  Compaction
>  ==========
>  
> -As the system runs, tasks allocate and free the memory and it becomes
> +As the system runs, tasks will allocate and free memory. Memory thus becomes

Addition of "will" is not needed.

>  fragmented. Although with virtual memory it is possible to present
> -scattered physical pages as virtually contiguous range, sometimes it is
> +scattered physical pages as a virtually contiguous range, sometimes it is
>  necessary to allocate large physically contiguous memory areas. Such
>  need may arise, for instance, when a device driver requires a large
>  buffer for DMA, or when THP allocates a huge page. Memory `compaction`

Thanks.
-- 
~Randy