Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 16 Aug 2022 16:11:12 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Steven Rostedt <rostedt@goodmis.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ben Widawsky" <bwidawsk@kernel.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: Re: [RFC PATCH 1/9] cxl/mem: Implement Get Event Records command
Message-ID: <YvwkEIywUvVohagd@iweiny-desk3>
References: <20220813053243.757363-1-ira.weiny@intel.com>
 <20220813053243.757363-2-ira.weiny@intel.com>
 <20220816123958.2b49674a@gandalf.local.home>
 <20220816124128.618948e9@gandalf.local.home>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220816124128.618948e9@gandalf.local.home>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J65eY3UE/7Y4oubCXPoT+p1wsc9dm8CRlGHkAO7OL/NCEsiGmHu3O1JvICBD?=
 =?us-ascii?Q?a6pSBjRBsuGsvw1Z6GHFnElRHp3vFQBtDP1+xfJ7f0UCkFNVDmuu+kPNFVfg?=
 =?us-ascii?Q?6glzQjvt8IGbc123UIotwp5QmUnPDF7EaRHIlHyrQ8zmlQa5XPy5u9Z6ohPb?=
 =?us-ascii?Q?tGRPC7Z3kE9ai/5sPKyy1PNzR4ST3Lr//ZU7EC3KGDRJOFV2P1ZWG/AV7Mfd?=
 =?us-ascii?Q?cppNn91HneU+CUzJmZGnUkuWzTM5G2dk8hj4M+L8ywpaLtMomI0fW3Fd9rpp?=
 =?us-ascii?Q?vH9SWPrl6wJeqfnXRDEHoVYr8vOT2RC2EYK+p2reLWOvnOgdCi7r40f8XXOg?=
 =?us-ascii?Q?CmBo5T5Sh+eHIizU/uyVG+FqAnI9PoIs2gfrmAC2GAVo13Bgn0YTNKFXI6Dp?=
 =?us-ascii?Q?usYFaTeoGwReOs6XilUpJqKWMKpqyXD55x57So+kVNDqxHx2WmeIBaNhTN+x?=
 =?us-ascii?Q?3Q3+xqXhhZCuL/H4Ti3+No5OKWbMPknZlYcLNKHnR0CsDi6fB7jqv3UI7+Tp?=
 =?us-ascii?Q?nohBUwLstBj5Fx/fIoW/SySQl6o/08WNUsVaVUeYyJ9SVdmyBmFz58NG+g5C?=
 =?us-ascii?Q?SERjMVrtQlFqdxGV5PcUt4VhLYJ6bkSJXNr4G3LVgX3VsEttz19P3cAIYZVf?=
 =?us-ascii?Q?dNt5nZWUFlkRhHjptx5K5H7yQWRViIF02lONlTFYVWPLXXrX6S8NaszTVGdn?=
 =?us-ascii?Q?jNf6IqOcp7vTbZh3AjStQypmiU0aQdWxDr2kLfaHr5ca455kOM1SRZ57HN1y?=
 =?us-ascii?Q?0Q/dnZmiGmqxSHp4iBjaS11w/RvoUZo36sVl0DICg97U2+cl9EQI4CXcMUKJ?=
 =?us-ascii?Q?DMA3vFD+84wymowO8dSxhXS6pgRXaX1P+DtREBZyyDiDZ1QYvUuXFXQ2v7er?=
 =?us-ascii?Q?5FvKCj4uzoMTq3BreasTe/SRQfx8jNfcvRuS/fxcpp8GSeMhL19l7iuGXObi?=
 =?us-ascii?Q?1/xZyWNKnXkluefAmu4qU2qzCl49HI2uUJkGQ/JC/2H4t7bSt5dAAOcwUPJX?=
 =?us-ascii?Q?O0VQL1BVUl7Za8TBlygsJW1PdtLT+9iopsEpPaXRi5HFJ1Wmzc7qpckrbDCL?=
 =?us-ascii?Q?KGErHcX+7z5QnFTUL2ttbd4XfCPWP2/YszEEZJA1tKHuhNzdjsfEBPKBxA/U?=
 =?us-ascii?Q?G2O1Uk052lvf+R1R53OiB9nI0GmNS3wLuAQFIf/4xrA1FO6idhnbiEqW5/gM?=
 =?us-ascii?Q?+6y9i59tx9iG6P7alYW8SOdk88qYg5AM9/qA+uYUqiQraS6qPUFNc4Cuvljf?=
 =?us-ascii?Q?9ttGOBW/NOvLsGe1PeMFuZbs8zkxx3EdvG0gHFhND+fgKfizRx/7TOaSuMhQ?=
 =?us-ascii?Q?tcCpB1+8697OgDbIncDNp9dmZkHMR0jegB8t2p4oEeTkO8lrjyVpCWlF0PcT?=
 =?us-ascii?Q?KMmlXy5MoyGOKAr+jtRhaFYJrxZoFNiN7sJ2cyKP7Dedy5tLfZCeuxJgZtb1?=
 =?us-ascii?Q?zw62YVhsqgHiQFw8/uGeu9DxV6WqcZK8quk7jGTKQSwuFV3vczS75MZH77aP?=
 =?us-ascii?Q?9seC2JPYVN2121EBfT1QGt8ri6iLnlWO01OE06cMXDYJwQdnCXWOerJWq9mi?=
 =?us-ascii?Q?p0M/ZmQeIZ7BxERyOylyqamPprwgy4KVPvWiNXgm?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9697eafe-de6e-4bbf-1c97-08da7fdc9f1a
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Aug 2022 23:11:16.6429
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mcj3zkoiUDwV8wT2Iqxeace86xhsSCNur2D2T8r5sB1Xu7nLHiPpXXiyfUKv3EuVaVhopbuC6exnmkFjm6QzpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4384
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 16, 2022 at 12:41:28PM -0400, Steven Rostedt wrote:
> On Tue, 16 Aug 2022 12:39:58 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
> > > +		record_count = le16_to_cpu(payload.record_count);
> > > +		if (record_count > 0)
> > > +			trace_cxl_event(dev_name(cxlds->dev), type,
> > > +					&payload.record);
> > > +
> > > +		if (payload.flags & CXL_GET_EVENT_FLAG_OVERFLOW)
> > > +			trace_cxl_event_overflow(dev_name(cxlds->dev), type,
> > > +						 &payload);  
> > 
> > If you want to avoid the compare operations when the tracepoints are not
> > enabled, you can add:
> > 
> > 		if (trace_cxl_event_enabled()) {
> > 			if (record_count > 0)
> > 				trace_cxl_event(dev_name(cxlds->dev), type,
> > 						&payload.record);
> > 		}
> > 
> > 		if (trace_cxl_event_overflow_enabled()) {
> > 			if (payload.flags & CXL_GET_EVENT_FLAG_OVERFLOW)
> > 				trace_cxl_event_overflow(dev_name(cxlds->dev), type,
> > 							 &payload);
> > 		}
> > 
> > Those "<tracepoint>_enabled()" functions are static branches. Which means
> > when not enabled it's a nop that skips this code, and when either is
> > enabled, it turns into a jump to the contents of the if block.
> 
> Ignore this suggestion. I see in the second patch you add more logic to the
> if condition.

Correct.

> Only use this suggestion if the logic is only for when the
> tracepoint is enabled.

This could apply to the overflow trace.  I think it is more likely that either
all of these traces will be enabled or none.

So other than doing:

	if (trace_cxl_event_enabled() ||
	    trace_cxl_event_overflow_enabled() ||
	    trace_cxl_gen_media_event() ||
	    <every event defined>
	    ...) {

Is there a way to know if 

	/sys/kernel/tracing/events/cxl_events/enable

is != 0?

I feel like the real optimization will be to shut this entire functionality
down if no one is listening.

Ira