Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220816032846.2579217-1-imagedong@tencent.com> <CANiq72mQpZ-z1vVeOwdaOB3b=jjQHtPwz3-jaPRV330-yL_FqQ@mail.gmail.com>
In-Reply-To: <CANiq72mQpZ-z1vVeOwdaOB3b=jjQHtPwz3-jaPRV330-yL_FqQ@mail.gmail.com>
From:   Menglong Dong <menglong8.dong@gmail.com>
Date:   Wed, 17 Aug 2022 10:20:14 +0800
Message-ID: <CADxym3Y1ZoWrkGW3v4PbVMvbEYnoFgHmFXCD-QpY4Of9hrAxBg@mail.gmail.com>
Subject: Re: [PATCH net-next v4] net: skb: prevent the split of
 kfree_skb_reason() by gcc
To:     Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc:     kuba@kernel.org, ojeda@kernel.org, ndesaulniers@google.com,
        davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
        asml.silence@gmail.com, imagedong@tencent.com,
        luiz.von.dentz@intel.com, vasily.averin@linux.dev,
        jk@codeconstruct.com.au, linux-kernel@vger.kernel.org,
        netdev@vger.kernel.org, kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 16, 2022 at 5:02 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Tue, Aug 16, 2022 at 5:29 AM <menglong8.dong@gmail.com> wrote:
> >
> > Reported-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
>
> Hmm... Why did you add me as a reporter?
>

Enn...because you pointed out my code's problem, just like what robot do.
Shouldn't I?

> > + * Optional: not supported by clang.
> > + * Optional: not supported by icc.
>
> Much better, thank you! Please add the links to GCC's docs, like in
> most attributes (some newer attributes may have been added without
> them -- I will fix that).
>
> In any case, no need to send a new version just for this for the
> moment, I would recommend waiting until others comment on whether they
> want `__optimize__` used here as the workaround.
>

Okay, I'll wait longer before the next version.

Thanks!
Menglong Dong

> Cheers,
> Miguel