Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <77d8e180-9931-55ef-631e-f3e0ecb9fd36@infradead.org>
Date:   Tue, 16 Aug 2022 19:29:31 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] improve the kernel quality and reduce the amount of BS
 patches
Content-Language: en-US
To:     Al Viro <viro@zeniv.linux.org.uk>,
        Paul Lemmermann <thepaulodoom@thepaulodoom.com>
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
References: <YvxF0yn07ztg9r4A@gus-fring.localdomain> <YvxNvpF7n1VqNnbD@ZenIV>
 <YvxP3LrvHLhFClBd@ZenIV>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <YvxP3LrvHLhFClBd@ZenIV>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/16/22 19:18, Al Viro wrote:
> On Wed, Aug 17, 2022 at 03:09:02AM +0100, Al Viro wrote:
>> this idiocy has gone too far    
>>
>> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> 
> 	Seriously, folks - the stream of patches with no better
> explanations than "The Most Holy checkpatch.pl Says So, Must Appease
> The Spirits" ought to stop.
> 
> 	If you are changing something, take care to explain _why_
> is the change made.  Reference to a tool that has pointed you
> towards the location you are changing does not replace that.
> checkpatch.pl is a script.  A dumb one.  It's a bunch of heuristics
> that correlate with code being potentially fishy and worth looking
> into; those are occasionally useful, but it's not an oracle.

Yes, just saying "found with checkpatch" is not sufficient.

It's even documented to be a dumb advisor:

"""Checkpatch is not always right. Your judgement takes precedence over checkpatch
messages.  If your code looks better with the violations, then its probably
best left alone."""

and

"""Note, though, that the style checker should be
viewed as a guide, not as a replacement for human judgment."""


-- 
~Randy