Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Wang, Haiyue" <haiyue.wang@intel.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "david@redhat.com" <david@redhat.com>,
        "apopple@nvidia.com" <apopple@nvidia.com>,
        "linmiaohe@huawei.com" <linmiaohe@huawei.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "naoya.horiguchi@linux.dev" <naoya.horiguchi@linux.dev>,
        "alex.sierra@amd.com" <alex.sierra@amd.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Mike Kravetz <mike.kravetz@oracle.com>
Subject: RE: [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Thread-Topic: [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Thread-Index: AQHYsRbS1IjgnpM1/EaZo6nPqIEeuq2yRsoAgAAoZ1A=
Date:   Wed, 17 Aug 2022 03:31:37 +0000
Message-ID: <BYAPR11MB3495F747CBF95E079E8FC8A5F76A9@BYAPR11MB3495.namprd11.prod.outlook.com>
References: <20220812084921.409142-1-haiyue.wang@intel.com>
        <20220816022102.582865-1-haiyue.wang@intel.com>
        <20220816022102.582865-2-haiyue.wang@intel.com>
 <20220816175838.211a1b1e85bc68c439101995@linux-foundation.org>
In-Reply-To: <20220816175838.211a1b1e85bc68c439101995@linux-foundation.org>
Accept-Language: zh-CN, en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UaupdEkgDaSsvpuBthPAQGu8nYjWX5WK16swD2Lt24h7sg3pYWiS+10ehdam?=
 =?us-ascii?Q?wwTbv/BUe03zd5cpKkOgQk7U7q5Mmiei4B4YtmCYveEnYV1G6DaSnSK3Iv/G?=
 =?us-ascii?Q?OIRtAXm/Me3ezuWfU9qNkm8RQ/mr4UbkYk0rypGeol5669ulm8+HKhkgfcSa?=
 =?us-ascii?Q?DkqYIc+MEKHWib0L+NcGHUH5vzZZQmcXUIxEhhcShYTpzA4yXsnUZ+wMSbh4?=
 =?us-ascii?Q?158OagvXkKxktO6I/vwnPtwM8meuwNQstM4sFIxoQOBZzl9JBPrBxCrA4tuz?=
 =?us-ascii?Q?MMwHlfGZB/WTa0CG01OWIdWP9wq8peVsemayrzEQd7UjVYoIT9yfCrwecQzR?=
 =?us-ascii?Q?vnb38EYZArF+8Tq7FUifuDcXm9TKeUR7oilOYjyicKXYUb/kpyLvl53vA05B?=
 =?us-ascii?Q?o2imBw9zQJ+rXyZoeJC5fXnqYHqmLgNIGyYmN/THcNKywjcrEhwtoccjr93u?=
 =?us-ascii?Q?k+pCUtcgjIjORahk1djtm+PJp/z/D781Q9nqox3A28fygw8N1W/HLcj9F+lN?=
 =?us-ascii?Q?+azOHYjHkiSk06PmeiN5xrINNY9AgM2HU+90Y+R6VPv7/5zvWRnKima2YNgr?=
 =?us-ascii?Q?Xbq0TdPMOvkwhphpAPiid4IH+Gj7l5iu/Fc81nUY9166LPTRtnHpuoPD9OkU?=
 =?us-ascii?Q?o4lWowUtY8Ww3WIiQ4jqt2wJIGG0AH+Dy1IY2Y8R0mAppVRZCU8zUneCwUzj?=
 =?us-ascii?Q?uOkXEMpHq7pAQFCrqAb4HMI3BInInKdM4okv/OhI1gcuQeHVF07C5YXe9bl2?=
 =?us-ascii?Q?VhP3Wl/Zx285iy/O4UxmfiJQBKYrj0146djSXCAErZ42lFmrPnJRo6IUQqzs?=
 =?us-ascii?Q?6xofHfiNiZfoQRaLfBTq1AL+QNzHuWAfwVvwf8AEqairhVuExoWHVC6OJ6H8?=
 =?us-ascii?Q?5p4QSA/FXwZk5ggXeYlzBvjJrNZJWsfXwdlO/W3La6ADMNaI2z78+pEm8Ijz?=
 =?us-ascii?Q?1faavciivBDVZoahIzGD5tMo0YPatJnVxuqMdI5fsA70KQA+88y1q8oOoapx?=
 =?us-ascii?Q?4FFEI28/S1mqYLXXgBs1UJPKlLPY9ou8x7kZK7QljuRXlsg/crs0kVYCtyK2?=
 =?us-ascii?Q?XQSOKM66MoNUltqfVhkJFMeey2XPJjxdeg9ldjnQuWFFRbwai95g9C+9yEkK?=
 =?us-ascii?Q?yKla44MLqv1WAT/X6A7/b+KiD2ozzceURGILfKsH/gbHWZABBkxlgVW0KBtS?=
 =?us-ascii?Q?xGOt4R7o68HLjeYeHcnUFd8kFwGczjIW9rSrdd/EXGhHNYNHL2Gu45Y+SJTa?=
 =?us-ascii?Q?V/GkhcWxHnT3fhzk38Fz9ME+MbK0d9Au515o9FzaWziTWI3He4ceDBFHfILf?=
 =?us-ascii?Q?oyl0ReOJLVYD6aqOMpivbHCxBY0bYFjZ1LdK7VxUZg+kELVsrEyJXoopRub/?=
 =?us-ascii?Q?hZW0eIN6i+GjOJAQmgDL+pt03PpTvlSgA8TXaAlVsvcXl8Ok3YUM4YY7T9I8?=
 =?us-ascii?Q?m8apKJVdY4iQGVW8fFVpX904++ruFK1dlNHi2BXxwxZf6Cm4pKLlqH2jYzWG?=
 =?us-ascii?Q?6Hd7crE9LIwOqg6bAcXOI4Q7EozsV60enTaci7pWtQhzPb8eBUiw+mqzW0bc?=
 =?us-ascii?Q?4XHNW9y1qgU92N2RWZR/eCFcigGFkinauCtm/1/B?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 61c5980b-a690-41b6-9ea0-08da8000fdc4
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2022 03:31:37.1910
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: QmWwxhCFLVNK+/P23JC2nmDHmZEDOU3ERymCLPfE72JhTc8Gmd7WwO2XgBtFSdaP36I4/FCrVV7qe91QGKqFbA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4028
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HK_RANDOM_ENVFROM,
        HK_RANDOM_FROM,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Andrew Morton <akpm@linux-foundation.org>
> Sent: Wednesday, August 17, 2022 08:59
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: linux-mm@kvack.org; linux-kernel@vger.kernel.org; david@redhat.com; a=
popple@nvidia.com;
> linmiaohe@huawei.com; Huang, Ying <ying.huang@intel.com>; songmuchun@byte=
dance.com;
> naoya.horiguchi@linux.dev; alex.sierra@amd.com; Heiko Carstens <hca@linux=
.ibm.com>; Vasily Gorbik
> <gor@linux.ibm.com>; Alexander Gordeev <agordeev@linux.ibm.com>; Christia=
n Borntraeger
> <borntraeger@linux.ibm.com>; Sven Schnelle <svens@linux.ibm.com>; Mike Kr=
avetz
> <mike.kravetz@oracle.com>
> Subject: Re: [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on fo=
llowing huge page
>=20
> On Tue, 16 Aug 2022 10:21:00 +0800 Haiyue Wang <haiyue.wang@intel.com> wr=
ote:
>=20
> > Not all huge page APIs support FOLL_GET option, so move_pages() syscall
> > will fail to get the page node information for some huge pages.
> >
> > Like x86 on linux 5.19 with 1GB huge page API follow_huge_pud(), it wil=
l
> > return NULL page for FOLL_GET when calling move_pages() syscall with th=
e
> > NULL 'nodes' parameter, the 'status' parameter has '-2' error in array.
> >
> > Note: follow_huge_pud() now supports FOLL_GET in linux 6.0.
> >       Link: https://lore.kernel.org/all/20220714042420.1847125-3-naoya.=
horiguchi@linux.dev
> >
> > But these huge page APIs don't support FOLL_GET:
> >   1. follow_huge_pud() in arch/s390/mm/hugetlbpage.c
>=20
> Let's tell the s390 maintainers.
>=20
> >   2. follow_huge_addr() in arch/ia64/mm/hugetlbpage.c
> >      It will cause WARN_ON_ONCE for FOLL_GET.
>=20
> ia64 doesn't have maintainers :( Can we come up with something local to
> arch/ia64 for this?

The 'follow_huge_addr' itself just has interest on "FOLL_WRITE"
struct page *
follow_huge_addr(struct mm_struct *mm, unsigned long address,
			      int write)

And arch/ia64 defines this function 17 years ago ...

But I found that "WARN_ON_ONCE for FOLL_GET" was introduced on 2005-10-29
by commit:

[PATCH] mm: follow_page with inner ptlock

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?=
id=3Ddeceb6cd17e6dfafe4c4f81b1b4153bc41b2cb70

-	page =3D follow_huge_addr(mm, address, write);
-	if (! IS_ERR(page))
-		return page;
+	page =3D follow_huge_addr(mm, address, flags & FOLL_WRITE);
+	if (!IS_ERR(page)) {
+		BUG_ON(flags & FOLL_GET);
+		goto out;
+	}

>=20
> >   3. follow_huge_pgd() in mm/hugetlb.c
>=20
> Hi, Mike.
>=20


> >  		}
>=20
> I would be better to fix this for real at those three client code sites?

Then 5.19 will break for a while to wait for the final BIG patch ?