Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4353784rwb; Tue, 16 Aug 2022 20:48:07 -0700 (PDT) X-Google-Smtp-Source: AA6agR4HnC/KPNxYxiuJucIyS4mul/qIQ+/Z+GPKrGd5q16Utc7HX6kRbC1Yi2NEI4Xs8w6R4ZQE X-Received: by 2002:a05:6a00:21c5:b0:52b:fc9c:295b with SMTP id t5-20020a056a0021c500b0052bfc9c295bmr24448256pfj.56.1660708087175; Tue, 16 Aug 2022 20:48:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660708087; cv=none; d=google.com; s=arc-20160816; b=u1FM6T+DG6/k4gjBYA5VIIX2k+eb2eNXuKJ5Kw/J7WJ7dtuIi6h4CREXSk7ie59ZjK DGL97C2w9pcM/t4oDaDsSdOzCHQdsHQ7FHIfRkuMO8YtKy8AHvkrqn2JTxIrjR26TGEL HIKMHfoPp/WxEyhfoX2+4mPEeSMpRay9vh3S6kJw77cOwY28d9brvvzNssfEvAXnpebd r0dFv5gGfhEL+6BOO3+dpRDgfLTT8zXVd97xtxzgEm3nKAFNnMw+m6bcZgnpxlkpvAuX 2dGKWsiBFX+0HyjnoTGXB7OMKMHPNQ8Z7kH9P5C5KDOUnrCvaUG2HUTQWt1EQ7VOZCVF F5DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=WqGKkJz/Jv5hH9wFe8IYQBFYShSbW0GE8e2K/9tTYvw=; b=gHk4R1YvumExV9+GYunxIijD+nPBDtgLn2m35/QOlCdw+LW+/YIeWMLc9Qf/W2WbDN x1hKf+pGMsOXlZAuX6u93Bhih4j6DX7pkco3KU8ignHG73S9krUnwX4yui97PLia9q5O ZIp4Iw2MZDy06Kd2LN9FMViILiE2ciFjzpCnkTjUZG1s/w0cYwKCcNV+DIB15bNsxDlF reD4gjZdZjwFWnhI1pmBqQHqH9zjqdwI5pKKmRK80CuEvX5pEEpkqVWxvx3IagoaE/rz L4fH68S8pB7aO1j1yxOSv2f9/129G3/t/+ynTvcC54jof19VRMdMwlihkjN4uuetROH7 kaJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KPvi5Be+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k36-20020a635a64000000b004116434c8b1si9357018pgm.389.2022.08.16.20.47.56; Tue, 16 Aug 2022 20:48:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=KPvi5Be+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230085AbiHQDmF (ORCPT + 99 others); Tue, 16 Aug 2022 23:42:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbiHQDmD (ORCPT ); Tue, 16 Aug 2022 23:42:03 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7CAA7F0B3; Tue, 16 Aug 2022 20:42:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9EFA3B81AD3; Wed, 17 Aug 2022 03:42:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1D2AC433D6; Wed, 17 Aug 2022 03:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660707720; bh=JB+uYnew1TY4hlA/hravuGJRZJpftlS1oeDaF0n04pw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KPvi5Be+9yCdfykFTpkB0jkAFXiVC+34Af7CdqYqQd5AnSrEjClmDB4aMxH5sjM3H 3LRLxiZgYyz81i55uacqlj+Y8SxuHsB36RchqpbtIX5jmTKRgmQbwcDtyFVG+wZczA UGpddhg7HBISAsBpENs5+EBwuMlP5CSNvW/TBSa6zovaj48c6fyrffSQ+6Mk50Yk8+ hR4e92Xp9msKozGS6DU8SFd2kOIg5wMWkRVQxRYeFOoInZnMiVpHfwJM40eEALQyij r0mx0cOWVbNInTEsxGPP/SueTYRd6G8vuqHwgSmpxphm7o5dQWFOOujPm6qZpt3jOs yuAaZZ4OqAu7w== Date: Tue, 16 Aug 2022 20:41:58 -0700 From: Jakub Kicinski To: Aleksander Jan Bajkowski Cc: hauke@hauke-m.de, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v2 1/3] net: lantiq_xrx200: confirm skb is allocated before using Message-ID: <20220816204158.32f24172@kernel.org> In-Reply-To: <20220815145740.12075-2-olek2@wp.pl> References: <20220815145740.12075-1-olek2@wp.pl> <20220815145740.12075-2-olek2@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Aug 2022 16:57:38 +0200 Aleksander Jan Bajkowski wrote: > + netdev_err(net_dev, "failed to build skb\n"); I don't thinkg this is needed, is build_skb() using GFP_NOWARN? Otherwise there will be an OOM splat anyway. Do check, I'm not sure. If there won't be an OOM splat this line should be rate limited.