Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4444153rwb; Tue, 16 Aug 2022 23:12:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ssTVa7yR2Fj1Zsdld0Lv1LAsUfYQUY6zc5znwwkvVI5sbpHP2VQ/eO0eqDHMC7T2gr/dB X-Received: by 2002:a17:90b:3850:b0:1f5:609a:3ac6 with SMTP id nl16-20020a17090b385000b001f5609a3ac6mr2145943pjb.125.1660716748337; Tue, 16 Aug 2022 23:12:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660716748; cv=none; d=google.com; s=arc-20160816; b=pwOijZASuKBBsg0dq46Qlq7YW0nd4P9dQSXoxZ9hoenZMD+hU3EFy2sTbpSqkdDfVc J5WhpozRT4U8Gl57Hy0G3Dj26PKl1mGTa4DEf6o8D6vAqDlIALr84z6MCxXGKvCyQT+C 7oZZvZ7YcI5TsfUfcB4WBE90dBwXFiek2Cs2eyRy57xrMr9px2rOItEzPu826XIE8OgQ nrPpXUX7SBPatrtGrUl70zsRu8W8yDBY3ocZsdSX4qd9Tsd48KczRyKOn42+zMsYcnbF ZOTJPMsVBN1JPMsnKMaOauh1+brcdB9RtqJ0G+nGkPagi6BrrAvUKwh5pSOoJeMyOnxV r2Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xZsiPO+XX3mOS4Ii7OMJYpbakPc0P/WjJFV8hl00pXI=; b=KlA9bZrWWKSK10beGlV10nJ128Bbz1DeYlTj86jA10Xm1qc0Jl3k2cq/uEUdr6+EBz 4oyQb7Cq6RbVeiKvyfxxTjTlB3xc0U2mH6VGu/OmveIlJ8MAAFl7GCA+lSFyDsWyQEHc Pjm5l0iZrkPaSfTEgajrmOzjplzSkPPfYumkxAgspTbx+MIh3m/4DhcByDdsPH8EybO4 r3ELoojH5JB6te6inIw0ijVXc0msZ+bBuawrMqVhhj1cvgg6Yto01rtm+KwD9LXj9mYJ DcwJND9EYW3Tn3n5DqefJT+/roBppD8ER/YgQNyAMm0fcBpkHZCOK1PE6OzaJtdWOt9p zmbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2M9o6st8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g9-20020a656cc9000000b0041c3351d9absi15386096pgw.30.2022.08.16.23.12.15; Tue, 16 Aug 2022 23:12:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2M9o6st8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238521AbiHQGBD (ORCPT + 99 others); Wed, 17 Aug 2022 02:01:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231362AbiHQGBC (ORCPT ); Wed, 17 Aug 2022 02:01:02 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42777E814; Tue, 16 Aug 2022 23:01:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 29C20B81AD3; Wed, 17 Aug 2022 06:00:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 935ACC433C1; Wed, 17 Aug 2022 06:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1660716057; bh=gWyhQ2vSiY3PQDsc2PdJGtbgVKekpF295CaCysh1iv4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2M9o6st8sa8fcPWhiVAkDuaEij9ALqXx9OFeqZBqBS5Za/mjTseMg24nLfeoNBayl fcR4MlMOgs0uX1kLl47wU8sCHO5VCdQeVnSbzxAkbJQTdAHrICXlNMtSh055bJYc3a L7pry/xmwZlFbeWtG+VM77DcRazJmFKgKm/9em/o= Date: Wed, 17 Aug 2022 08:00:54 +0200 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Guenter Roeck , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso , stable@vger.kernel.org Subject: Re: [PATCH v2] usb: typec: tcpm: Return ENOTSUPP for power supply prop writes Message-ID: References: <20220816191150.1432166-1-badhri@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220816191150.1432166-1-badhri@google.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2022 at 12:11:50PM -0700, Badhri Jagan Sridharan wrote: > When the port does not support USB PD, prevent transition to PD > only states when power supply property is written. In this case, > TCPM transitions to SNK_NEGOTIATE_CAPABILITIES > which should not be the case given that the port is not pd_capable. > > [ 84.308251] state change SNK_READY -> SNK_NEGOTIATE_CAPABILITIES [rev3 NONE_AMS] > [ 84.308335] Setting usb_comm capable false > [ 84.323367] set_auto_vbus_discharge_threshold mode:3 pps_active:n vbus:5000 ret:0 > [ 84.323376] state change SNK_NEGOTIATE_CAPABILITIES -> SNK_WAIT_CAPABILITIES [rev3 NONE_AMS] > > Fixes: e9e6e164ed8f6 ("usb: typec: tcpm: Support non-PD mode") > Signed-off-by: Badhri Jagan Sridharan > --- > Changes since v1: > - Add Fixes tag. > --- > drivers/usb/typec/tcpm/tcpm.c | 7 +++++++ > 1 file changed, 7 insertions(+) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.