Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4451532rwb; Tue, 16 Aug 2022 23:23:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR7z/OZ7D3OpldtGYhyngVM43cK92QxvR6adfXS1oqMR6SeS3pN9qISwIHKMRpOVys9QwLJX X-Received: by 2002:a17:907:9726:b0:730:9e04:f738 with SMTP id jg38-20020a170907972600b007309e04f738mr15598744ejc.631.1660717425189; Tue, 16 Aug 2022 23:23:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660717425; cv=none; d=google.com; s=arc-20160816; b=jBVtHLkXDoWDQo9N98MTzI3nMqCdSZLglnYYr7mlwLAmD1zp2AoGZAwjc7DLJfuWAv 3VjKISyjP4R6ukFxS5ABc8K1mloP9dtv+XulEAIELmk3GUgmy+10TSBI7ci4wpSDxmdh Asx9ygQsiSB2T3tvkvymwBRzc2rD43BVXwKePT6sZvHBC/Y9esOzgLr2+eESoZgkPREY AOHF/36VWmeMuwkVr5zXdmNzLT/RvR7qBkG6q5NobTHLrMOAa7ssVkLvK/XizDkaKjos fxzft95QH5WpKLQOrIDrgbdRdr4gMZniVngYdZ7wSn8URScaO2C5Q5/o6Ew2o7pxTLZZ h46A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=kB93RpgeDxqV6eg4zllJtOVqlHJ3q2cTErlIUWDz/FE=; b=l9aqCRDplw/Jy9Zmp2DI+/04ba745/g8qJtlMjgf1p2kZ85BNTS7qsoc569XgGEcH+ GoZPqtyn7EIcvojDy9tlh8MmKD/4IeRSk0/DT+rXjjAfik10IUNqaZWaJkMH81e2lyCm Ei8KTYRS4sLdZIrQkvPk9oTYNriHxG9ZctjBzYKbdrYqhYfANuF7WiSBzlH72pE3FfQU andgzbthTjc78VrhkR9DhInXXDRXGD/hADhx0Ek3KfH9M+uzEcBrUqrfNcInya5SYAid jYc4XwkqWkstQjyGJiXpcQjQU2CogRP0UiQqNx3FYsRBUkM9BjX5TMyKov+XJTT8GfWa Xf4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="N/tmOnSh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dp21-20020a170906c15500b0073860fab971si6002509ejc.215.2022.08.16.23.23.19; Tue, 16 Aug 2022 23:23:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="N/tmOnSh"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238660AbiHQFyY (ORCPT + 99 others); Wed, 17 Aug 2022 01:54:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233161AbiHQFyW (ORCPT ); Wed, 17 Aug 2022 01:54:22 -0400 Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB3FD5A3CE; Tue, 16 Aug 2022 22:54:20 -0700 (PDT) Received: by mail-il1-x12b.google.com with SMTP id l5so2780442iln.8; Tue, 16 Aug 2022 22:54:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=kB93RpgeDxqV6eg4zllJtOVqlHJ3q2cTErlIUWDz/FE=; b=N/tmOnShu9POigvwSuLapZiYwbwl6omssqsvR7NFux+AuYYDcYkaozdBCWciBlLZ/U tlvowz0FREf6GPq4HnULNC+4BbWWcEcSImeGCujx+FT5CXzgUgJ9kzli2BL87YVEtJlC 1cjOM3k81jeav/jQ5wv2p1hB8gimRmpaao3qe3HjIcGR4fUk8dqIRLWJ5VLvats++xKK msQ9FSpXXTWoE/riVLl6RLGoD9eIcG85zDpR9JeFnbCJlMGBL95XrgOAqqkA+VOtCiIi REemFtdIcDAtTyIED40b7WoNZbFrrAydkgAmZH8hHJXdVWnh37CzLxISFUDhPLaslJeR o+BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=kB93RpgeDxqV6eg4zllJtOVqlHJ3q2cTErlIUWDz/FE=; b=ZV31TIHpxeuhvS6F/aNc7FrdfHgiMo77Pl4H6tZsqclIrvpZk87lMr9An5Ncenb3H0 U1f8AWqucOQa5x+vUZ83tOO6FLEIvfSnQRXjhqn6Fu+yNPxs4+iVExsPOeaMGUdQVQ4P ZdLAoldp947XGSRqBAPy7+ZqVRAOI7K+3XLjfbzrz2UQy9EE0ZjKKL5nlvf8+rH8PevT KIIfmnIv0MbvTU9p9j/rOFTqO5VgfWP9q7/cs9+vtCbwlixlzqJrkobHzMQalDXw6Z47 wtroqsusens7+J/SbrvGNp4tOOOQfrBq7y763qcIx1d3nJQau9Eks0tcowyCmPfKsPAL jqTA== X-Gm-Message-State: ACgBeo2no86RocHVeGE9uBnEsm9t/ifAOnMOJ9gNxrTcjNdogF/JKqyl O4y8vHOpN4ul7Ko/lzV4HgsPe3nV7GPvgRERRts= X-Received: by 2002:a05:6e02:1c26:b0:2e0:d8eb:22d6 with SMTP id m6-20020a056e021c2600b002e0d8eb22d6mr11161317ilh.151.1660715660084; Tue, 16 Aug 2022 22:54:20 -0700 (PDT) MIME-Version: 1.0 References: <20220816032846.2579217-1-imagedong@tencent.com> In-Reply-To: From: Miguel Ojeda Date: Wed, 17 Aug 2022 07:54:09 +0200 Message-ID: Subject: Re: [PATCH net-next v4] net: skb: prevent the split of kfree_skb_reason() by gcc To: Menglong Dong Cc: kuba@kernel.org, ojeda@kernel.org, ndesaulniers@google.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, asml.silence@gmail.com, imagedong@tencent.com, luiz.von.dentz@intel.com, vasily.averin@linux.dev, jk@codeconstruct.com.au, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2022 at 4:20 AM Menglong Dong wrote: > > Enn...because you pointed out my code's problem, just like what robot do. > Shouldn't I? Yeah, but that is just the usual review on a patch; I didn't report the original bug (that the commit message talks about). (I appreciate that you wanted to give credit, though :-) > Okay, I'll wait longer before the next version. > > Thanks! My pleasure! Cheers, Miguel