Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a92f5041-9630-66ee-1757-4b58bdaabe90@linux.intel.com>
Date:   Wed, 17 Aug 2022 08:31:20 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v2 linux-next] Remove Unnecessary TODO
Content-Language: en-US
To:     Khalid Masum <khalid.masum.92@gmail.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc:     Vinod Koul <vkoul@kernel.org>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Sanyog Kale <sanyog.r.kale@intel.com>
References: <20220816175954.5259-1-khalid.masum.92@gmail.com>
From:   Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
In-Reply-To: <20220816175954.5259-1-khalid.masum.92@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/16/22 19:59, Khalid Masum wrote:
> The capabilities enabled for multi-link are required as part of the
> programming sequences, even when a stream uses a single link we still
> use the syncArm/syncGo sequences. Therefore the TODO is no longer
> necessary.
> 
> Suggested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>

the title of your patch should be something like

soundwire: intel: remove unnecessary TODO

so that the patch scope and context is clearly identified.
> ---
> Previous discussions:
> - v1 Link: https://lore.kernel.org/lkml/20220814080416.7531-1-khalid.masum.92@gmail.com/
> 
> Changes since v1:
> - Remove the todo, leave rest of the code as is
> - Update commit message
> 
>  drivers/soundwire/bus.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
> index 8d4000664fa3..18158825a6d8 100644
> --- a/drivers/soundwire/bus.c
> +++ b/drivers/soundwire/bus.c
> @@ -75,7 +75,6 @@ int sdw_bus_master_add(struct sdw_bus *bus, struct device *parent,
>  
>  	/*
>  	 * Initialize multi_link flag
> -	 * TODO: populate this flag by reading property from FW node
>  	 */
>  	bus->multi_link = false;
>  	if (bus->ops->read_prop) {