Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Liao, Bard" <bard.liao@intel.com>
To:     Vinod Koul <vkoul@kernel.org>,
        Bard Liao <yung-chuan.liao@linux.intel.com>
CC:     "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "tiwai@suse.de" <tiwai@suse.de>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>
Subject: RE: [PATCH 0/4] ASoC/soundwire: log actual PING status on resume
 issues
Thread-Topic: [PATCH 0/4] ASoC/soundwire: log actual PING status on resume
 issues
Thread-Index: AQHYlx6d/CKOWCWhzkKJXwmOkvg+9q2DpNmAgC82tPA=
Date:   Wed, 17 Aug 2022 06:48:56 +0000
Message-ID: <DM6PR11MB40745C1283CFCC3F5D41FAC9FF6A9@DM6PR11MB4074.namprd11.prod.outlook.com>
References: <20220714011043.46059-1-yung-chuan.liao@linux.intel.com>
 <YtTzZ4iA0xt68euH@matsya>
In-Reply-To: <YtTzZ4iA0xt68euH@matsya>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.6.500.17
dlp-reaction: no-action
dlp-product: dlpe-windows
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IZNth/V+gSKuWF9h5wLhv/1V2gdvNqCXmyVEXCeG1v1eT6jPTKDmNVYSWk4Y?=
 =?us-ascii?Q?EOw1KJiM4zPUM7TCHsVMdh78cUJcnmNERVcokrYGIX2aRVGL6Pnb/STmLWgI?=
 =?us-ascii?Q?/yj00vFDdumsXSedz19FbYaQ2JI45pydiUkOVLh5lvG2AoG3FmITHREBL1im?=
 =?us-ascii?Q?GyMpmf1nY45DAL3fHKxo+dcFrec1CiAk5g/Rz85w/NDgmOT3CmRm6hkabUBf?=
 =?us-ascii?Q?INv2mAmhsALI8Ol19tFSLNCc/yPQFPkf+P0p2S3s/4Ll8MZuR32hKKFWWl5S?=
 =?us-ascii?Q?v+BdkG4XIiFufbjldfMRioY4vxUAnqKY9ZeT01Uv5jEoJTJk+KHWriYUgycQ?=
 =?us-ascii?Q?axCvGgHv7ZE9YiPg199bxGN8KUJJfabYGrqfFcjj4L05oYcEwFIdpUvlKX6D?=
 =?us-ascii?Q?N0CmW9vroG7n3lPhejX4dREwAA4BnUn8fHjNW2BvU9vjir6utY4M8YiLFyEB?=
 =?us-ascii?Q?ZrtJhaiNzdu97vWvg7EZ9hOr/AId9L+6gTgsG46V74/ZrnpDY5iwPzNHWjLu?=
 =?us-ascii?Q?7cHNFvlcQ1vjaHhxc10H9wJEpbT4iaCgqW8FHrBtuEVmsUmGtlGj15ogmaIh?=
 =?us-ascii?Q?1QM+uzkj27GnSUvwYmQ1heqA/zTG+3oxJbDPxUwyaezj0a/rwS1cuLx5wT7G?=
 =?us-ascii?Q?YFdLul+zOokY7JVH782csdlufut1tpDlKTw+3Z898/JDPKGi/VsfORwSNJjI?=
 =?us-ascii?Q?BKXldM3Vik72phgPV0crDPFQf9hWZ6zctuALz5bPKo2Ss87q+tVP6PgIAm4l?=
 =?us-ascii?Q?HVHMuusBoKCYyQtV9o6wOONKUlBVB5g+w6Y4Q3RX/oXDog7AWtWERVcLEmUf?=
 =?us-ascii?Q?+s4nzjscuce+16e4SD0ru2rYRWVBYQWks8dZm8cvyPk9+6XIUdK28suFSY3q?=
 =?us-ascii?Q?R1u6AWhjUR2PIpJhOv5D7UfNoATN9m8HDFwASslzMAw0L3tu0KBPDyppmDew?=
 =?us-ascii?Q?Ivk6MBaqCpJ5kY24V9UGZqnKIVxw/8XOQK1oWPNpNuHLtb/lIGdS+yz4/iX9?=
 =?us-ascii?Q?EBcBiFJnUWWUut75w9j5UU83hhhvi4l5T0sgjhvpP1F6TCl5kkx8ut+AdS6P?=
 =?us-ascii?Q?lM72fqJzPgXpi8IyzkrYTG6ECpzbWL/6CX37OD50C0nfFOpKa209QOzdPPCV?=
 =?us-ascii?Q?ganBLT7AUY5T8fPY2EptAbooLT0qDkD+/p1oi4bCa+uAtBQVScSNuX4DRNu1?=
 =?us-ascii?Q?ubIixWaOLl+9IslK+6wXq/6uyWRFY2xUJBFUZ30bIRB1+OP1hXiW6S8cTLXt?=
 =?us-ascii?Q?n1+gdf+iQponDq9uoTwMZmDkqhj59XNIg7rRfujm0Wz73aPW3eFCrp7DD4rX?=
 =?us-ascii?Q?fQ4B5CxkI8ew0X7aEcBTQY6k+a24ZxFeoWYkluiaMCrIzquGUM5CKkKLWo8f?=
 =?us-ascii?Q?Xhyn3Frqixt9U5WBJbANqB9TijF7uQv+9pMIARrKuZRwW246QnZoFbWNNay8?=
 =?us-ascii?Q?ISsAUb57rxyPt+PshLKhvsxV93f4ESkUlwQemviDRkK7BRVLxC/O97cCJ//f?=
 =?us-ascii?Q?V1c/BAy8GYV2IAKz+nFL7F0y+LB/XuptyBKTwAAynD9ml4toMHAcsr7E4X2c?=
 =?us-ascii?Q?t1T9K9nuo7A5xKcD/sPGNfweCAg3qtumicy0LuWk?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4074.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38300286-141c-4759-aaec-08da801c8ed6
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2022 06:48:56.9906
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yDIZuf9nnVtik3S/n+sxVYQfSjQ67tnTU7XyQrf+Oi/V942p8qiQ+PiA+F8FawzBirnAsOx6w18n05/oMc6gDQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5461
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Vinod Koul <vkoul@kernel.org>
> Sent: Monday, July 18, 2022 1:45 PM
> To: Bard Liao <yung-chuan.liao@linux.intel.com>
> Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org;
> tiwai@suse.de; broonie@kernel.org; pierre-louis.bossart@linux.intel.com;
> Liao, Bard <bard.liao@intel.com>
> Subject: Re: [PATCH 0/4] ASoC/soundwire: log actual PING status on resume
> issues
>=20
> On 14-07-22, 09:10, Bard Liao wrote:
> > we've been stuck with problems in the dual-amplifier configurations whe=
re
> > one of the two devices seems to become UNATTACHED and never regains
> sync,
> > see https://github.com/thesofproject/linux/issues/3638.
> >
> > This is a rather infrequent issue that may happen once or twice per mon=
th,
> > but still it remains a concern.
> >
> > One possibility is that the device does lose sync but somehow our
> hardware
> > detection fails to see it resync.
> >
> > This series just adds a basic read directly from the PING frames to hel=
p
> > confirm if yes/no the device regain sync.
> >
> > The change is mainly on soundwire. @Mark, Could you ack the ASoC patch
> > if it looks good to you?
>=20
> Mark,
>=20
> The series lgtm, feel free to merge thru ASoC tree with:
>=20
> Acked-By: Vinod Koul <vkoul@kernel.org>

Hi Mark/Vinod,

Both of you are acked.
Can this series be merged now?

Thanks.

>=20
> >
> > Pierre-Louis Bossart (4):
> >   soundwire: add read_ping_status helper definition in manager ops
> >   soundwire: intel/cadence: expose PING status in manager ops
> >   soundwire: add sdw_show_ping_status() helper
> >   ASoC: codecs: show PING status on resume failures
> >
> >  drivers/soundwire/bus.c            | 32 ++++++++++++++++++++++++++++++
> >  drivers/soundwire/cadence_master.c |  8 ++++++++
> >  drivers/soundwire/cadence_master.h |  2 ++
> >  drivers/soundwire/intel.c          |  1 +
> >  include/linux/soundwire/sdw.h      |  5 +++++
> >  sound/soc/codecs/max98373-sdw.c    |  2 ++
> >  sound/soc/codecs/rt1308-sdw.c      |  2 ++
> >  sound/soc/codecs/rt1316-sdw.c      |  2 ++
> >  sound/soc/codecs/rt5682-sdw.c      |  2 ++
> >  sound/soc/codecs/rt700-sdw.c       |  2 ++
> >  sound/soc/codecs/rt711-sdca-sdw.c  |  2 ++
> >  sound/soc/codecs/rt715-sdca-sdw.c  |  2 ++
> >  sound/soc/codecs/rt715-sdw.c       |  2 ++
> >  13 files changed, 64 insertions(+)
> >
> > --
> > 2.25.1
>=20
> --
> ~Vinod