Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ab3ef674-c453-5b38-80b5-f41dcfed62bb@samsung.com>
Date:   Wed, 17 Aug 2022 09:35:55 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
        Thunderbird/91.11.0
From:   Pankaj Raghav <p.raghav@samsung.com>
Subject: Re: [PATCH v11 13/13] dm: add power-of-2 target for zoned devices
 with non power-of-2 zone sizes
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        <axboe@kernel.dk>, <snitzer@kernel.org>, <hch@lst.de>,
        <agk@redhat.com>
CC:     <pankydev8@gmail.com>, <gost.dev@samsung.com>,
        <matias.bjorling@wdc.com>, <hare@suse.de>, <bvanassche@acm.org>,
        <linux-kernel@vger.kernel.org>, <dm-devel@redhat.com>,
        <linux-nvme@lists.infradead.org>, <jaegeuk@kernel.org>,
        <Johannes.Thumshirn@wdc.com>, <linux-block@vger.kernel.org>,
        Damien Le Moal <damien.lemoal@wdc.com>
Content-Language: en-US
In-Reply-To: <30790cae-5440-2447-a8b8-52a57fa16fa5@opensource.wdc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
CMS-TYPE: 201P
References: <20220816131536.189406-1-p.raghav@samsung.com>
        <CGME20220816131551eucas1p218faf35348e78a73aaa87d5477ecdb2e@eucas1p2.samsung.com>
        <20220816131536.189406-14-p.raghav@samsung.com>
        <30790cae-5440-2447-a8b8-52a57fa16fa5@opensource.wdc.com>
Precedence: bulk

Hi Damien,
>> + */
>> +static bool bio_in_emulated_zone_area(struct dm_po2z_target *dmh,
>> +				      struct bio *bio, int *offset)
> 
> This function name reads like it is a block layer helper. It mat be less
> confucing to keep using the dm_po2z_ prefix for it.
>
Good point. Even though it is a static function in the same file, it could
be confused for a block helper at the caller site.
>> +{
>> +	/*
>> +	 * Read operation on the emulated zone area (between zone capacity
>> +	 * and zone size) will fill the bio with zeroes. Any other operation

>> +
>> +	return DM_MAPIO_KILL;
>> +}
> 
Do you see any more issues apart from the two you pointed out?