Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754573AbXFKG2Q (ORCPT ); Mon, 11 Jun 2007 02:28:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750830AbXFKG2D (ORCPT ); Mon, 11 Jun 2007 02:28:03 -0400 Received: from smtp2.linux-foundation.org ([207.189.120.14]:59399 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbXFKG2A (ORCPT ); Mon, 11 Jun 2007 02:28:00 -0400 Date: Sun, 10 Jun 2007 23:26:59 -0700 From: Andrew Morton To: "Dan Williams" Cc: "Herbert Xu" , "Jan Engelhardt" , "Mariusz Kozlowski" , linux-kernel@vger.kernel.org, "Neil Brown" , "Leech, Christopher" , "Jeff Garzik" , davem@davemloft.net, "Wolfgang Denk" Subject: Re: 2.6.22-rc4-mm1 Message-Id: <20070610232659.ceff247c.akpm@linux-foundation.org> In-Reply-To: References: <20070606020737.4663d686.akpm@linux-foundation.org> <200706062132.37430.m.kozlowski@tuxland.pl> <20070606132439.3f59f0cf.akpm@linux-foundation.org> <20070606212831.GA1534@gondor.apana.org.au> <20070606164202.a3dcd176.akpm@linux-foundation.org> <20070607070108.GA8013@gondor.apana.org.au> <20070607001218.742c0ba5.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.4.1 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1602 Lines: 37 On Sun, 10 Jun 2007 22:01:34 -0700 "Dan Williams" wrote: > It would be very helpful to have a clear merge path for dmaengine > changes and the async offload api. Yes, this needs some attention. I'd suggest that you prepare a standalone tree for Linus to pull and we aim at asking him to pull that for 2.6.23-rc1. In the meanwhile I'd suggest that you get the core patch(es) out onto the relevant lists again and cc'ed to the relevant maintainers. Of course, good changelogging and commenting makes the review a) more effective, b) more likely to happen and c) less work for reviewers. The changelog you have for 7556477664edcbe1c9a2fdf60edddfd8455d198b is nice, but it's awfully short for a 1/4MB patch. It tells us at a high level what the code does, but it has nothing to say about how it does it: a high-level design description, of you will. Put yourself in the position of an experienced kernel developer who doesn't know this code, and who doesn't know the hardware. What can you do to make their review easier and more effective? So. Please have a think about what you can do there, and also see what can be done about the 312 warnings which perl scripts/checkpatch.pl patches/git-md-accel.patch emits. Then send 'em all out again (say, a week from now) and let's all just dig in and make this thing happen? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/