Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4542643rwb; Wed, 17 Aug 2022 01:38:30 -0700 (PDT) X-Google-Smtp-Source: AA6agR7x7eUIfbxXGM5nIUdT+IEvvnXtWvsSye4/7Bxge5e3R0ubqrjWzW8FeBpqzRY2BPo9roJ2 X-Received: by 2002:a17:907:28c9:b0:731:e57:bf27 with SMTP id en9-20020a17090728c900b007310e57bf27mr15475277ejc.451.1660725510712; Wed, 17 Aug 2022 01:38:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660725510; cv=none; d=google.com; s=arc-20160816; b=X26ZCzcgs+UimSERiEzOkROmGdJyjIBpPwxQAsW/bP6IxK/xNgT7avlGxd823mGgTD qhWmia/S3vgNEnxr2MualT9q9ipoYjh7tC2MmovTQb0oy+dgE3ZpPI02jOyxz6mpoTjf zw1Ap9/K+bTP7WHaKd5iQ0HQXT7tACx0IMP5twbc9gdp2gfgRF9c8602cDJoCW4DEXzz 5zQ6/NI+pWchciv9A4VI45MZNkqdG0abtQvpgAoTP5zG9oejQMwXyC52OR4wdbftUMG7 uZeGWm6Ita/QA5YHAqZWIDNso2r3KiLXIqDpwbm7LB0rt9UaAvHTz0hn2PV+vYBNtgCX jTfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=oGRnErvsRLL5OIcedW14gBEzwpHYDIOfRWLWutnLveQ=; b=ZSBDpgD0vu0USXAwabZilNQrcCxOzVsRtYf/2Er+J9Yu9XKx2YvmUUI7RxVeb2PHnv 8exHfj4nINO0CIP0sWY8nEK14pD+rqgIr0rjIuIXfhr5UYqQ8jpmuUF8/gp9ybk+u8k0 iUhr5m7zpJtUxTakTmOxvH6tFyLT/2fwzMyghNdDiRdsU5x/5LFCztv3Uyt+gVSGT2XK 2PUbJPWlkCoTPoX5GKnPBPqlEMDuUU86KqvZBevoCP9GqeyVXoV6Exp+HAD4qqtaHxKU qw+jbCu76kiw17us8ICyGbHljsOjLm0Kcq4r7P2KOqb4shp6cFLefXlXSZJsgaLbf3Tg lCdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp36-20020a1709073e2400b00730c392a3c5si13950893ejc.243.2022.08.17.01.38.04; Wed, 17 Aug 2022 01:38:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230183AbiHQIUP convert rfc822-to-8bit (ORCPT + 99 others); Wed, 17 Aug 2022 04:20:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235084AbiHQIUO (ORCPT ); Wed, 17 Aug 2022 04:20:14 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 817A058DD3 for ; Wed, 17 Aug 2022 01:20:11 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-186-_ZDhN8jUN4OlHtEkOqfydg-1; Wed, 17 Aug 2022 09:20:09 +0100 X-MC-Unique: _ZDhN8jUN4OlHtEkOqfydg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.38; Wed, 17 Aug 2022 09:20:08 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.040; Wed, 17 Aug 2022 09:20:08 +0100 From: David Laight To: 'Hector Martin' , Will Deacon , "Peter Zijlstra" , Arnd Bergmann , Ingo Molnar CC: Alan Stern , Andrea Parri , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , "Daniel Lustig" , Joel Fernandes , "Mark Rutland" , Jonathan Corbet , Tejun Heo , "jirislaby@kernel.org" , Marc Zyngier , Catalin Marinas , Oliver Neukum , Linus Torvalds , "linux-kernel@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Asahi Linux , "stable@vger.kernel.org" Subject: RE: [PATCH] locking/atomic: Make test_and_*_bit() ordered on failure Thread-Topic: [PATCH] locking/atomic: Make test_and_*_bit() ordered on failure Thread-Index: AQHYsU4vfwz5idsf402HoI6nUKdp962yvvCA Date: Wed, 17 Aug 2022 08:20:08 +0000 Message-ID: <1135281ad4e84cc5ac0147772aa83787@AcuMS.aculab.com> References: <20220816070311.89186-1-marcan@marcan.st> In-Reply-To: <20220816070311.89186-1-marcan@marcan.st> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... > p += BIT_WORD(nr); > - if (READ_ONCE(*p) & mask) > - return 1; > - > old = arch_atomic_long_fetch_or(mask, (atomic_long_t *)p); > return !!(old & mask); > } This looks like the same pattern (attempting to avoid a locked bus cycle) that caused the qdisc code to sit on transmit packets (even on x86). That had some barriers in it (possibly nops on x86) that didn't help - although the comments suggested otherwise. I wonder if the pattern has been used anywhere else? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)