Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4564255rwb; Wed, 17 Aug 2022 02:06:38 -0700 (PDT) X-Google-Smtp-Source: AA6agR6O4tb23phsRBy+p7LvFPGSUQTNq5c1Gk/ZvCWPcYg/D2TnnPjr+JRWgQ3QjF8FGsbJ1JTs X-Received: by 2002:a05:6402:2387:b0:43d:3e0:4daf with SMTP id j7-20020a056402238700b0043d03e04dafmr22396394eda.208.1660727198493; Wed, 17 Aug 2022 02:06:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660727198; cv=none; d=google.com; s=arc-20160816; b=esnAMQdvlJ2eDJXNBq1U8Ug8o++rviBo+/izJPnOXGtnNxUqhOrSimTPcdrqQcWnyp fP7xLcrt2dZsPlkwTgMyqpmixnPKVMw6vGqMMm4KrikKmns5XVR1WjO1yk25GvUVW6HU yZDBFhqO18PuRc94jW/1kJ0Moc+xKkMgwk4o10MiskjSLrqD5XGRrsgI4Q9c3Quml0aA dRkqs7jA0HygKKX8sDwYFOV+rF0I0Y3hqJyb0m2FSOkjukFQnSXV5Ov5RlKWpwbDhNzi 0wFe47K+mKSwvKxs7ng1aQzPrcCNbOUmYBOSC38AK29mcRRGCPb6zHddzXBBFUp45yMq quMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=1Nc9t7mJDNJm7tX2tDtri09eHBfV+Ex+cKn6gDnLpQc=; b=B8EZkIk9ZqbfkXKiWWx4GPZzjhVNcnYlJhDyI55H9SDIv+LvamDe2rGAHunXvrMVCO kGw/F2gGOYSyUuJP1vxTAPbAc+xZ/owtYxypr5tYOKcq7UnnTflm3on5VEEBTiqGRx/N 6dTpI2piQNRytSiCSSTqNRDNqzjxvPWgZL5YJCCY2gM5/nZH1xoXJehoKmd5/U8YmKD5 Z5Lq5T1Cg2K2p4hN472q/S/G2QeuhfOusP/ANnTSQiSm89wWcuMg9sVojv7HquX2CUv2 XgGDM3JK116s3JxC25HHtaNgdI64OcLqmoptS3kmTu54fS/lm1q0Am6SFbAQAmLlNqt5 5Yhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=GcbLLw8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hc10-20020a170907168a00b0073063cbab03si1416381ejc.655.2022.08.17.02.06.11; Wed, 17 Aug 2022 02:06:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=GcbLLw8Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235450AbiHQIuN (ORCPT + 99 others); Wed, 17 Aug 2022 04:50:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230514AbiHQIuL (ORCPT ); Wed, 17 Aug 2022 04:50:11 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D0406A489; Wed, 17 Aug 2022 01:50:10 -0700 (PDT) Received: from zn.tnic (p200300ea971b9855329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:9855:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BFF501EC04F0; Wed, 17 Aug 2022 10:50:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1660726204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=1Nc9t7mJDNJm7tX2tDtri09eHBfV+Ex+cKn6gDnLpQc=; b=GcbLLw8ZpGKMrGQvsebCopv6bxKAXNMYcNfrs/TS+KIQqjHHVTyMTCVsFZ8if02hCMOvYR aNEOyZ/tUNxQbGU9Y+dJCxmS1HzRbnYVUvKQswbw1s/TfpbCdWF71i138SESUjd56D1C0n L0ynhx3AO0JdOJsu3Jwtf+RshCVT0Sw= Date: Wed, 17 Aug 2022 10:50:00 +0200 From: Borislav Petkov To: "Kani, Toshi" Cc: Justin He , Ard Biesheuvel , Len Brown , James Morse , Tony Luck , Mauro Carvalho Chehab , Robert Richter , Robert Moore , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "devel@acpica.org" , "Rafael J . Wysocki" , Shuai Xue , Jarkko Sakkinen , "linux-efi@vger.kernel.org" , nd , "stable@kernel.org" Subject: Re: [PATCH 2/2] EDAC/ghes: Modularize ghes_edac driver to remove the dependency on ghes Message-ID: References: <20220811091713.10427-1-justin.he@arm.com> <20220811091713.10427-3-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2022 at 01:39:32AM +0000, Kani, Toshi wrote: > Yes, but the impact is not necessarily limited to these modules. The impact is limited only to the modules which would otherwise potentially load on a HP system which advertizes as "HPE ", "Server ". You're the only user of ghes_edac. So please state which drivers you want blocked from loading on those platforms and where ghes_edac should load instead. From looking at 301375e76432 ("EDAC: Add owner check to the x86 platform drivers") it is 4 drivers. > I think a new check with ghes_get_device() can replace the owner check > in xx_init(). The owner thing should not be touched now - it can be a cleanup ontop if you - Justin - feel like doing it afterwards. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette