Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Manne, Nava kishore" <nava.kishore.manne@amd.com>
To:     Xu Yilun <yilun.xu@intel.com>,
        Nava kishore Manne <nava.manne@xilinx.com>
CC:     "michal.simek@xilinx.com" <michal.simek@xilinx.com>,
        "hao.wu@intel.com" <hao.wu@intel.com>,
        "trix@redhat.com" <trix@redhat.com>,
        "mdf@kernel.org" <mdf@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "ronak.jain@xilinx.com" <ronak.jain@xilinx.com>,
        "rajan.vaja@xilinx.com" <rajan.vaja@xilinx.com>,
        "abhyuday.godhasara@xilinx.com" <abhyuday.godhasara@xilinx.com>,
        "piyush.mehta@xilinx.com" <piyush.mehta@xilinx.com>,
        "harsha.harsha@xilinx.com" <harsha.harsha@xilinx.com>,
        "lakshmi.sai.krishna.potthuri@xilinx.com" 
        <lakshmi.sai.krishna.potthuri@xilinx.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
        "git@xilinx.com" <git@xilinx.com>
Subject: RE: [PATCH v2 1/3] fpga: manager: change status api prototype, don't
 use older
Thread-Topic: [PATCH v2 1/3] fpga: manager: change status api prototype, don't
 use older
Thread-Index: AQHYhVFh0nFKgVNbE0Gr+XpBPxtCy61kiGwAgE66L9A=
Date:   Wed, 17 Aug 2022 11:16:14 +0000
Message-ID: <DM6PR12MB39934EC6FB92A46CEA8645E5CD6A9@DM6PR12MB3993.namprd12.prod.outlook.com>
References: <20220621092833.1057408-1-nava.manne@xilinx.com>
 <20220621092833.1057408-2-nava.manne@xilinx.com>
 <20220628083158.GA2442728@yilunxu-OptiPlex-7050>
In-Reply-To: <20220628083158.GA2442728@yilunxu-OptiPlex-7050>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DwoyFhS5lvFrQ9XBxfd6o8kplCRqHmGUxmVsDvLn8FuudKe4DK5MM61R3Iea?=
 =?us-ascii?Q?EIKuDEDoRfwmYFGmIfGzVA09CxOS5bGSjpUSHVGBxUuFWD6/jb0T6hE/YurC?=
 =?us-ascii?Q?eIz6Zr4fd7oVLEjEsbuwe1z01aGnOxFFDUBxSyUaT8O7Pkxq12KUQ1+nOW8N?=
 =?us-ascii?Q?duaFgVgcZDOefxrFypMNe23clDTcIegv8wfMx+Iwet1AKbx+B4ZazvW222lo?=
 =?us-ascii?Q?tyKEOY4shJCs+be4O+AYtD8EjzjlqgWbpkqNFV7F7nhN5PEbLJcGYraBg90o?=
 =?us-ascii?Q?a2KjTTb88d82XvB7dZ/x1UCAA1Hwss79JhAf2X9sxdG4kuFJpFqxLMsNO6YZ?=
 =?us-ascii?Q?gms4n3nwUgYQ6Lh/D6U/zKO/BaPtprczs5bLr3X16DLR1qDbFRz3GbqZXDMX?=
 =?us-ascii?Q?AStKmpUI+ZmxJ/0o/f64GlG3iL+fIpBM298y2fhNz2Pqui1R8LKM52qu5DkA?=
 =?us-ascii?Q?C65s2KQpwOQUHvhNSpSIi6rlcHl7OnYBGkpkZqiGrMMZqq0AEh6MVPpxC3Rs?=
 =?us-ascii?Q?akJPZipIXJYsBx4uzLHRKhvuabV59bIIT+5PsYITRSXq2LM8PM+LScM/HKNZ?=
 =?us-ascii?Q?dOPBTY/DLoSNIdiTxxBNCpkttd4EFI615cZ98hz6oMjm29kxazQlzFGFnNZ1?=
 =?us-ascii?Q?wtS++AgUaLrtIwK0lurW/AQ12nYorh20uywQ1/76vLz7HdRqW+bNTYMYJufl?=
 =?us-ascii?Q?e41UhhKyqpkVvL+oFpr5AyYudRLeDjR1MSaWejRbGCycxhn//vmGMo/Jc81h?=
 =?us-ascii?Q?hH3EKBFcYFwwPYnikm7MkSYG3/dD18O0FbOnHB6qd8n7InA+/d+OuFgOAiXN?=
 =?us-ascii?Q?9a44TakJ7asfNVyoZS5iTpk/sg/01/fJ4sOSsbGwdLONszxMAGmRRhkEQXT3?=
 =?us-ascii?Q?chaaiipdlnfiKkr3a8jcPHWIbD+fOEacxx7Mk5ZdRdD2NRDVlKn4WrMV3n1D?=
 =?us-ascii?Q?RbQgeBOgVyMW6lGREkGqV2PZKyB8k+OSksTgaIPAawkeKo7pMahPRgd3OVIO?=
 =?us-ascii?Q?90SPTPPRshMlL0YDAFolV4LAmlaRxRERQbnHWZw/LuLKIDGICFKK68/AooxW?=
 =?us-ascii?Q?iK7CgTxd5zn6xYmjNTUzF2pP3C+YmtSuSrPjHPrF0zirqFNLFoBdMFPEtQ+P?=
 =?us-ascii?Q?7Z5jziqLdFkwGANryqXwKQ2XZB6FUSS4NddVFtCGD2Aw2r29ZUk5Ut5Dufh1?=
 =?us-ascii?Q?SZtqWcTxfcM4BEhshLYEsDJEQJfnMivwoiUAfVL+WvRWqzY4/u0gtGvSIztp?=
 =?us-ascii?Q?7Y1CRoeHNFIwh+yzJ+02mXHFf6/lmMvXpX5Hgk6xnLSo6DgHX74G70hbCNYt?=
 =?us-ascii?Q?mcsSbnk/QfNrdXfLep5jDsgRhfGM7FWPLoFFtvE/R3HY0d2NsxAOCffiFLl2?=
 =?us-ascii?Q?IQUVSc3OhpqQIIMGkMu9ZB5jbyOVo+ptH23e4lPhbbM2XYAWH1Ct0zvwX15u?=
 =?us-ascii?Q?EoTEcXfvkoUhqdO9z6bs9z2kgSUUsPEAzK+pqnaivj+mTEQZImmHLGAahvoS?=
 =?us-ascii?Q?72c9V19llCGkjb+ny5KgXaBTjGBEgUftfuLXp3qYabr3nUhgvDQQdmCchJ59?=
 =?us-ascii?Q?2KIEU1yDCVEhdoFXDYA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3993.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b04506c7-eba6-4024-cb80-08da8041e5ee
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2022 11:16:14.4583
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AizRJqusJc/bnpHDFGmq5F1g4BcMhuWY3RykjyoQwwK1kgQTesferCLB3xxO04DS
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR12MB2473
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Yilun,

	Please find my response inline.

> -----Original Message-----
> From: Xu Yilun <yilun.xu@intel.com>
> Sent: Tuesday, June 28, 2022 2:02 PM
> To: Nava kishore Manne <nava.manne@xilinx.com>
> Cc: michal.simek@xilinx.com; hao.wu@intel.com; trix@redhat.com;
> mdf@kernel.org; gregkh@linuxfoundation.org; ronak.jain@xilinx.com;
> rajan.vaja@xilinx.com; abhyuday.godhasara@xilinx.com;
> piyush.mehta@xilinx.com; harsha.harsha@xilinx.com;
> lakshmi.sai.krishna.potthuri@xilinx.com; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> fpga@vger.kernel.org; git@xilinx.com
> Subject: Re: [PATCH v2 1/3] fpga: manager: change status api prototype,
> don't use older
>=20
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
>=20
>=20
> On Tue, Jun 21, 2022 at 02:58:31PM +0530, Nava kishore Manne wrote:
> > Different vendors have different error sets defined by Hardware.
> > If we always define the new bits when we cannot find an exact 1:1
> > mapping in the core the 64 bits would soon be used out. Also, it's
> > hard to understand the mixture of different error sets.
> >
> > To address these issues updated the status interface to handle the
> > vendor-specific messages in a generic way. With the updated status
> > interface the vendor-specific driver files can independently handle
> > the error messages.
>=20
> I think we don't have to provide the vendor specific HW errors in a gener=
ic
> way, maybe the vendor specific drivers could handle them by its own devic=
e
> attributes.
>=20
> Since the output value set of the interface is specific to each driver, u=
sers
> should still interpret them in specific manners. So doesn't see much valu=
e for
> a class interface.
>

Agree,  vendor specific drivers could handle them by its own device attribu=
tes.
If it is the case, can we remove the existing status interface relevant cha=
nges from the core?

Regards,
Navakishore