Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 15:12:10 +0200
Message-ID: <87ilmrauad.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Amadeusz =?ISO-8859-2?Q?S=B3awi=F1ski?= 
        <amadeuszx.slawinski@linux.intel.com>
Cc:     Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [RESEND][PATCH] ALSA: info: Fix llseek return value when using callback
In-Reply-To: <7324df1d-0424-a589-f7c9-df089a6cbefe@linux.intel.com>
References: <20220817124924.3974577-1-amadeuszx.slawinski@linux.intel.com>
        <7324df1d-0424-a589-f7c9-df089a6cbefe@linux.intel.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 17 Aug 2022 14:56:05 +0200,
Amadeusz S?awi?ski wrote:
> 
> On 8/17/2022 2:49 PM, Amadeusz S?awi?ski wrote:
> > When using callback there was a flow of
> > 
> > 	ret = -EINVAL
> > 	if (callback) {
> > 		offset = callback();
> > 		goto out;
> > 	}
> > 	...
> > 	offset = some other value in case of no callback;
> > 	ret = offset;
> > out:
> > 	return ret;
> > 
> > which causes the snd_info_entry_llseek() to return -EINVAL when there is
> > callback handler. Fix this by setting "ret" directly to callback return
> > value before jumping to "out".
> > 
> > 73029e0ff18d ("ALSA: info - Implement common llseek for binary mode")
> > Signed-off-by: Amadeusz S?awi?ski <amadeuszx.slawinski@linux.intel.com>
> > ---
> >   sound/core/info.c | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/sound/core/info.c b/sound/core/info.c
> > index b8058b341178..0b2f04dcb589 100644
> > --- a/sound/core/info.c
> > +++ b/sound/core/info.c
> > @@ -111,9 +111,9 @@ static loff_t snd_info_entry_llseek(struct file *file, loff_t offset, int orig)
> >   	entry = data->entry;
> >   	mutex_lock(&entry->access);
> >   	if (entry->c.ops->llseek) {
> > -		offset = entry->c.ops->llseek(entry,
> > -					      data->file_private_data,
> > -					      file, offset, orig);
> > +		ret = entry->c.ops->llseek(entry,
> > +					   data->file_private_data,
> > +					   file, offset, orig);
> >   		goto out;
> >   	}
> >   
> 
> Doing resend, because I did copy paste mistake when pasting Takashi
> email to git command, additionally alsa-devel blocked my previous
> mail.
> I've seen that Cezary already discussed this issue, and it doesn't
> seem to be fixed, can this be somehow investigated? I guess we can
> provide response we get from server when email fails?

It seems working now.  Jaroslav mentioned that it was some DNS
problem.


Takashi