Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220816020423.323820-1-shaozhengchao@huawei.com>
 <20220815201038.4321b77e@kernel.org> <694f07e3-d5ad-1bc5-1cdb-ae814b1a12f7@huawei.com>
 <20220816111305.4851a510@kernel.org>
In-Reply-To: <20220816111305.4851a510@kernel.org>
From:   Jamal Hadi Salim <jhs@mojatatu.com>
Date:   Wed, 17 Aug 2022 09:19:03 -0400
Message-ID: <CAM0EoMkcOXNfd0dyoGeqGVqN1EQ5jHr_2BuWQoLUAyudsLwdRg@mail.gmail.com>
Subject: Re: [PATCH net-next,0/3] cleanup of qdisc offload function
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     shaozhengchao <shaozhengchao@huawei.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, xiyou.wangcong@gmail.com,
        jiri@resnulli.us, davem@davemloft.net, edumazet@google.com,
        pabeni@redhat.com, weiyongjun1@huawei.com, yuehaibing@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 16, 2022 at 2:13 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Tue, 16 Aug 2022 11:32:03 +0800 shaozhengchao wrote:
> > On 2022/8/16 11:10, Jakub Kicinski wrote:
> > > On Tue, 16 Aug 2022 10:04:20 +0800 Zhengchao Shao wrote:
> > >> Some qdiscs don't care return value of qdisc offload function, so make
> > >> function void.
> > >
> > > How many of these patches do you have? Is there a goal you're working
> > > towards? I don't think the pure return value removals are worth the
> > > noise. They don't even save LoC:
> > >
> > >   3 files changed, 9 insertions(+), 9 deletions(-)
> >
> >       Thank you for your reply. Recently I've been studying the kernel code
> > related to qdisc, and my goal is to understand how qdisc works. If the
> > code can be optimized, I do what I can to modify the optimization. Is it
> > more appropriate to add warning to the offload return value? I look
> > forward to your reply. Thank you.
>
> Understood. Please stop sending the cleanups removing return values
> unless the patches materially improve the code.

Quoting appropriate here.
+1

cheers,
jamal