Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 14:16:28 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andrea Righi <andrea.righi@canonical.com>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: head: rely on CONFIG_RANDOM_TRUST_CPU
Message-ID: <YvzqLFDuXtDRxilZ@sirena.org.uk>
References: <20220817094618.67063-1-andrea.righi@canonical.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="8H8XdsxnlYFybTHf"
Content-Disposition: inline
In-Reply-To: <20220817094618.67063-1-andrea.righi@canonical.com>
Precedence: bulk


--8H8XdsxnlYFybTHf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 17, 2022 at 11:46:18AM +0200, Andrea Righi wrote:
> The CONFIG_ARCH_RANDOM .config option has been removed by
> commit 9592eef7c16e ("random: remove CONFIG_ARCH_RANDOM").
>=20
> Depend on CONFIG_RANDOM_TRUST_CPU to determine whether we can rely on
> __arm64_rndr() to initialize the seed for kaslr.
>=20
> Fixes: 9592eef7c16e ("random: remove CONFIG_ARCH_RANDOM")

> -#ifdef CONFIG_ARCH_RANDOM
> +#ifdef CONFIG_RANDOM_TRUST_CPU
>  		 if (!__early_cpu_has_rndr() ||
>  		     !__arm64_rndr((unsigned long *)&seed))
>  #endif

I think the sense here would be more that we should just unconditionally
use RNDR if it's present - previously we'd use the result even if we
didn't have strong trust in the CPU implementation and I don't see why
we'd want to change that.

--8H8XdsxnlYFybTHf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmL86isACgkQJNaLcl1U
h9Df7wgAhn45rtL5BTafxsbRFNuND0n6Pq7ioAq/s35QXOWV1WRw4gRfDAaGRS3R
090kZUquUoRAHIf8IroKI3ZQmI1QG9GcZeOU7jCj4RsDcoWpWru3OUG1gogU3VDd
w44LtXw6ymbWROWPa5O3bS+/4isQpori6p7FTze1zL2KDrET9iKFKNQcgImVU014
0gQIkyqy+HmypLsu4MkPO/qXanmTEbQkQyCMnHX8cQgJXkAMaFhFj1EeYzwleHIS
wTuJsGZ1dzgYjS+p1XCBUYtZpL+sICn1g4BfTsOVDqqKEosg511NM98wLS7883+z
Rg2ajzZZarO9svnhv1hOIP6pqN3rqA==
=kiFb
-----END PGP SIGNATURE-----

--8H8XdsxnlYFybTHf--