Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 10:53:21 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Abhishek Sahu <abhsahu@nvidia.com>
Cc:     Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Kevin Tian <kevin.tian@intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v6 5/5] vfio/pci: Implement
 VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP
Message-ID: <Yvzy0VOfKkKod0OV@nvidia.com>
References: <20220817051323.20091-1-abhsahu@nvidia.com>
 <20220817051323.20091-6-abhsahu@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220817051323.20091-6-abhsahu@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/k42N+COW6wSB8jGby7vmMs8JnHnPfe0Hj8MD2w5BFak+pKCvEFKu6DqFvkp?=
 =?us-ascii?Q?g5LbrsTCP7Vv72+g8eZbIzEht/QYsSsWTwPXCfT6QNDiL2wK6aM/3sCrnOpl?=
 =?us-ascii?Q?qWOBC0GpEs8lnOsXtFHwqORdhk1EJ061Ggf9ERE5lZcMU26QAiUxRE25fxU5?=
 =?us-ascii?Q?5OFldyWjPy4YJv47wwB7IdSpnteh176JXBQccx8EwviCV5EvW9xPucon4rJo?=
 =?us-ascii?Q?nIEFKSJqsiSBYWUxaz7TYoQGLQY6HXdVLxuZvAdlIFw2DA6Zh+/XYOejOQOB?=
 =?us-ascii?Q?QEl5rYZd7FAn8J+0POCH32iX1uncHqdZPXYwnoLjrDj18X82IOd5YHVJ36bU?=
 =?us-ascii?Q?jPxig7eIYeRt9LMI3zNopoT/T0R8SxRS+T3wXFbUDaoIYHIeStzuXFoVrhUO?=
 =?us-ascii?Q?jNTKnf8tEYvjjX5jgLKxA8AYSFKzuIjX51Yuzl3ZOgN0cR4T5lqO3jwJijpF?=
 =?us-ascii?Q?234S1UDHd32Z5tA4p/oSnYw8/ISTOiojRCIUY+f8FtCBui4lSZxOnhhMUW+k?=
 =?us-ascii?Q?wOrDBMb3QRf6D4kD50aZfO7Q7ai4soSii62VvRrquwMICokzDZMSoy7ILtoP?=
 =?us-ascii?Q?2BQDb1S2fx+YX5qqZlSzUUsYV8oLQKDvaxpY/1i9Rmaslko1FAV4tT1zpiDW?=
 =?us-ascii?Q?9Ayu4pEjB8GUTa9lQsmlDnRjVz3fb6k5OvffsXCOhAIA3OSEMMCGUnD7dBXG?=
 =?us-ascii?Q?d0tNchvI0/906VXoCcRe+Qrdq/XTUZ8WqvWqfvzQCmglbD0p8Aqqrcv5vxc8?=
 =?us-ascii?Q?0VYzPoM0HTG67lCwuykwMtVG23qvkcva58PSy9NweVrv8ez9mX/tPNS+Wx5s?=
 =?us-ascii?Q?cRkvXnWgUPqiwq+UyOgV9N6IZT/BytDQVL9KhEo1la9GKhsE2kXUAqnmA0Mz?=
 =?us-ascii?Q?XJundfTAG6ppFmR5vdQo03v0lJbdkRUYCxqSWXoRhbGUmBCy9Bce5ncV9ZO9?=
 =?us-ascii?Q?7LaeJ1XlL89KYf+oGc8XELH88pbwZEkvE0lTGYv8eu5HFouPGP43kBnoglTP?=
 =?us-ascii?Q?IeFrFfTSQgHb5dE85rv+0Nz35pA8irdwqPFhnxS28eOte7tTO8DPign+LvU/?=
 =?us-ascii?Q?8W55bj+d9cccOOKCWzr8ou/pkcsdS/xMxJy1HzgNQ0OwjFgsv5GyagvhWQbq?=
 =?us-ascii?Q?aBIVX5a0EkLtBwnd/ZpQ0mZ6KzGOBVNnP8i5ELcojiTyLJzUGh3lWPDezrOV?=
 =?us-ascii?Q?WZJeb3jzZVuzAetCcTu4CbYetAIHZ1BdBb6Yn9umJFNcFmM1gN6fix5uLBfP?=
 =?us-ascii?Q?Tq7++DROtvsVyWFfCjuPcC+9gFMcVAZAFC48pb3JmSKosGQowogAbGGMsR6c?=
 =?us-ascii?Q?olkn3zeIwfWdoghMMVNQVDWslDORet+mDVLbcafRSgOYy+Y85oBLSDIBE1Eh?=
 =?us-ascii?Q?XImd9GojS7/kHFwRch5NBT0JghuXpTZh1yOW1ZKYxOPBVw0V4NsBMx3PbrgK?=
 =?us-ascii?Q?mtIEFGSGpWfHaaWNlAiDVmHdeosi5D5FM/gIn5GbeD0GTAvEyyi9hPbynzEY?=
 =?us-ascii?Q?ofnoSd+xvNdRlUKopH8w2MmS5d9rLYc6srZZ7Ostqs1HNtXycrax8hmpKuM3?=
 =?us-ascii?Q?G7cI1lNQJB3+pTLN6rAg30F+jkmE40Px0AyX3XIA?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a58efcf-5007-44d9-b3bc-08da8057d9a8
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 13:53:23.0130
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jeIj06HsnGnLkeo1tdDt0fYMWav4my0a7n93wt9btIdSfgxtnnA6OGJk07GCVRvn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6284
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2022 at 10:43:23AM +0530, Abhishek Sahu wrote:

> +static int
> +vfio_pci_core_pm_entry_with_wakeup(struct vfio_device *device, u32 flags,
> +				   void __user *arg, size_t argsz)

This should be
  struct vfio_device_low_power_entry_with_wakeup __user *arg

> @@ -1336,6 +1389,9 @@ int vfio_pci_core_ioctl_feature(struct vfio_device *device, u32 flags,
>  		return vfio_pci_core_feature_token(device, flags, arg, argsz);
>  	case VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY:
>  		return vfio_pci_core_pm_entry(device, flags, arg, argsz);
> +	case VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP:
> +		return vfio_pci_core_pm_entry_with_wakeup(device, flags,
> +							  arg, argsz);
>  	case VFIO_DEVICE_FEATURE_LOW_POWER_EXIT:
>  		return vfio_pci_core_pm_exit(device, flags, arg, argsz);

Best to keep these ioctls sorted

Jason