Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 14:44:48 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Shreeya Patel <shreeya.patel@collabora.com>
Cc:     sanju.mehta@amd.com, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        krisman@collabora.com, alvaro.soliverez@collabora.com,
        Lucas Tanure <tanureal@opensource.cirrus.com>
Subject: Re: [PATCH] spi: amd: Configure device speed
Message-ID: <Yvzw0GqUd9ZgxUTo@sirena.org.uk>
References: <20220817131809.312533-1-shreeya.patel@collabora.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6FocHUaNXur4kiU0"
Content-Disposition: inline
In-Reply-To: <20220817131809.312533-1-shreeya.patel@collabora.com>
Precedence: bulk


--6FocHUaNXur4kiU0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 17, 2022 at 06:48:09PM +0530, Shreeya Patel wrote:

> Create mechanism to configure device clock frequency such
> that it is the closest frequency supported by the
> AMD controller.

You shouldn't use the closest, you should use a frequency which is
strictly less than the requested one - driving things too fast will
generally break but too slow is pretty much always fine.

--6FocHUaNXur4kiU0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmL88M8ACgkQJNaLcl1U
h9Bw1wf/ZyAh2aIJGCThq2MRGZPYvLvL2UXlzTF0y6ANGohcz3kYFgyEg2GeTf22
YGrIH7UuqTEb+jWL7sews+gNZ04cB1AYSphvkamTlVFARillpOteigu10mX72p1i
F3NY3qJ9jPzFP+jVu/Wx8B7lROHuVJ0D9Fw4W6Bu0tfjyjsu73X6KmaVCA5XRmVt
zKZKQswcTmr5Ce/kBk+i7CbOmqnZ+eXtEUp9sFulcxFFFfdAVdDogjktFEGy4mna
bU2ougQgzHyttoXNedBN0S8ih7YjULeyr2qlbZnoXOtvOXHVjg0dpimBRYiglLn4
hG75Lu+wV/IIvp+3F35IbWGkzA44hw==
=scUh
-----END PGP SIGNATURE-----

--6FocHUaNXur4kiU0--