Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <743867a6-b266-58e4-a8a6-542757916f0a@huawei.com>
Date:   Wed, 17 Aug 2022 15:04:06 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [ata] 0568e61225: stress-ng.copy-file.ops_per_sec -15.0%
 regression
To:     Oliver Sang <oliver.sang@intel.com>
CC:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Christoph Hellwig <hch@lst.de>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        <linux-ide@vger.kernel.org>, <lkp@lists.01.org>, <lkp@intel.com>,
        <ying.huang@intel.com>, <feng.tang@intel.com>,
        <zhengjun.xing@linux.intel.com>, <fengwei.yin@intel.com>
References: <1f498d4a-f93f-ceb4-b713-753196e5e08d@opensource.wdc.com>
 <3451fa5a-6229-073f-ae18-0c232cd48ed5@huawei.com>
 <e4106ffa-3842-45c0-9756-5226cfcfa17d@opensource.wdc.com>
 <YvXeuCAK780OuJPz@xsang-OptiPlex-9020>
 <2e9cf5a6-c043-5ccf-e363-097c6c941891@huawei.com>
 <f1c3d717-339d-ba2b-9775-fc0e00f57ae3@huawei.com>
 <Yvs/w93KUkgD9f7/@xsang-OptiPlex-9020>
 <aabf7ed8-8d4d-dc68-1b8b-c91653701def@huawei.com>
 <43eaa104-5b09-072c-56aa-6289569b0015@opensource.wdc.com>
 <28d6e48b-f52f-9467-8260-262504a1a1ff@huawei.com>
 <YvzyZJUblfqN6Xj3@xsang-OptiPlex-9020>
From:   John Garry <john.garry@huawei.com>
In-Reply-To: <YvzyZJUblfqN6Xj3@xsang-OptiPlex-9020>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 17/08/2022 14:51, Oliver Sang wrote:

Hi Oliver,

>> v5.19 + 0568e61225 : 512/512
>> v5.19 + 0568e61225 + 4cbfca5f77 : 512/512
>> v5.19: 1280/32767
>>
>> They are want makes sense to me, at least.
>>
>> Oliver, can you confirm this? Thanks!
> I confirm below two:
> v5.19 + 0568e61225 : 512/512
> v5.19: 1280/32767 (as last already reported)

ack

> 
> but below failed to build:
> v5.19 + 0568e61225 + 4cbfca5f77
> 
> build_errors:
>    - "drivers/scsi/scsi_transport_sas.c:242:33: error: implicit declaration of function 'dma_opt_mapping_size'; did you mean 'dma_max_mapping_size'? [-Werror=implicit-function-declaration]"
>    - "drivers/scsi/scsi_transport_sas.c:241:24: error: 'struct Scsi_Host' has no member named 'opt_sectors'; did you mean 'max_sectors'?"
> 
> not sure if I understand this correctly?
> for this, I just cherry-pick 0568e61225 upon v5.19,
> then cherry-pick 4cbfca5f77 again.
> so my branch looks like:
> 
> a11d8b97c3ecb8 v5.19 + 0568e61225 + 4cbfca5f77
> 1b59440cf71f99 v5.19 + 0568e61225
> 3d7cb6b04c3f31 (tag: v5.19,
> 
> did I do the right thing?

Sorry but I was not really interested in 4cbfca5f77 and I see where that 
build error is coming, but don't be concerned with it. However, for 
avoidance of doubt, if you have results for vanilla v6.0-rc1 then that 
would be appreciated.

I will also send a separate patch for testing if you don't mind.

thanks,
John