Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4863516rwb; Wed, 17 Aug 2022 07:17:19 -0700 (PDT) X-Google-Smtp-Source: AA6agR63I3dealwmkJOf7/IJQ4vnAKR2lyDTOWDsjSrDmfOvoNf0GcZ5DKQoGiNbLFqzRFW0HShi X-Received: by 2002:a05:6402:2547:b0:43e:4cc4:85d3 with SMTP id l7-20020a056402254700b0043e4cc485d3mr23259425edb.233.1660745838791; Wed, 17 Aug 2022 07:17:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660745838; cv=none; d=google.com; s=arc-20160816; b=bZ5i1TFR8/GT3NWRyWxVp6lpJJf1R25FpuWYFYYIxFjr2djpH0H+MKU2TJm6EeBs0o Ud6Ty84yvnagXvC/fWszKZook47xBc2D/SKNtsULXnpjT0Rs2JxEX/G6gCo3Y86LPM4+ n58R8D1EnOskJiHJUcUPh467tZfTErDNry+WGTPEN9S+WsEDQvhuiDuw0O5ZS44E3oeV 89cNfYhGQJdqQekFeM5REwWEIjPqpgbeQJJC196gjeU6RHN+ikgTbR6G6QtvJUw/wZ6d wCnDPmAKiqeE9VI5ht16Xqis8yVMu1worB7ip+8CQOFFD3ULkALkgAuEXO1MHbmz5Aq+ sdmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=uSxsc7qIZUr4BX/DpxO11ti2dLdQqWbeg4IDajrasO4=; b=I8VFd1AT5/O7e5BlPJCexdMy4xSdbKEc1dgzJpwNY97bNBDZ/cZT9tQbbYeRfGGb4E g4Jj+zob62b52JM/uLT5YUROgIjkO4wZLAPa5iTFIG28Gff32foO2q+/5xu2secvMYic DSJmds+8F3smvncarYpn0+fjOtuHbXYr7IULYVW0hVnVTV8umfdP1X9q+e+AxIRY6aFH cE0kvH+YqelFuFxij0HwW6Ibw06PPbT92my2cREpOmDuvKQeK/PATQ4uwFmgjlDEX1cN 84OTjYOj0if6E8Zh58ApSx5pu3w5lhg4+o2Ap0l47kQBn4JoOI21R+AW+M/mZZFR9BYv gjHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CcDgHmLI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dp19-20020a170906c15300b0072f664f368asi3352581ejc.199.2022.08.17.07.16.52; Wed, 17 Aug 2022 07:17:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=CcDgHmLI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236621AbiHQNsd (ORCPT + 99 others); Wed, 17 Aug 2022 09:48:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230359AbiHQNsa (ORCPT ); Wed, 17 Aug 2022 09:48:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E448E32A96; Wed, 17 Aug 2022 06:48:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D60C661435; Wed, 17 Aug 2022 13:48:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6715C433C1; Wed, 17 Aug 2022 13:48:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660744108; bh=oY072z80Whl/TUmfEqOyp7S4ZsatcvmMePOWmEYF/S8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CcDgHmLIV4tCGEyoJrzSBdurHpYWl9R6XeREsD6lPC0w71gTtjgqU1vGAl+jGsSzt 0KXdk07balqqyaUc7wrZ3apURgh2lqjAAi8CcfJ7Njp4HljGNcdKYBIF83KKHhq/gX UD4RdhsxHsb/2YtbtEFNOttwJEb4Quor0tOTcF9Wa7/eO7nefXJE4e6pE7PalqFN8c kLiErlxkEJ9lZL1a/+GzYyiasaok7R/OJRMxcRxXXjVmwJRSdD8beiETSpxCUedA54 DGmhZtfETu6jo6G6LzHgA1RTRltifmC0eYRMUjZxs3QPviZZPDsiXDBh+Be+kwZ8rJ RThzudAdbiD6A== Date: Wed, 17 Aug 2022 14:48:22 +0100 From: Will Deacon To: "Michael S. Tsirkin" Cc: stefanha@redhat.com, jasowang@redhat.com, torvalds@linux-foundation.org, ascull@google.com, maz@kernel.org, keirf@google.com, jiyong@google.com, kernel-team@android.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, crosvm-dev@chromium.org Subject: Re: IOTLB support for vhost/vsock breaks crosvm on Android Message-ID: <20220817134821.GA12615@willie-the-truck> References: <20220805181105.GA29848@willie-the-truck> <20220807042408-mutt-send-email-mst@kernel.org> <20220808101850.GA31984@willie-the-truck> <20220808083958-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220808083958-mutt-send-email-mst@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2022 at 08:45:48AM -0400, Michael S. Tsirkin wrote: > > > Also yes, I think it's a good idea to change crosvm anyway. While the > > > work around I describe might make sense upstream I don't think it's a > > > reasonable thing to do in stable kernels. > > > I think I'll prepare a patch documenting the legal vhost features > > > as a 1st step even though crosvm is rust so it's not importing > > > the header directly, right? > > > > Documentation is a good idea regardless, so thanks for that. Even though > > crosvm has its own bindings for the vhost ioctl()s, the documentation > > can be reference or duplicated once it's available in the kernel headers. > > > So for crosvm change, I will post the documentation change and > you guys can discuss? FYI, the crosvm patch is merged here: https://github.com/google/crosvm/commit/4e7d00be2e135b0a2d964320ea4276e5d896f426 Will