Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3e2a0f50-c396-5af6-5cbe-303978378587@collabora.com>
Date:   Wed, 17 Aug 2022 19:40:31 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] spi: amd: Configure device speed
Content-Language: en-US
To:     Mark Brown <broonie@kernel.org>
Cc:     sanju.mehta@amd.com, linux-spi@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com,
        krisman@collabora.com, alvaro.soliverez@collabora.com,
        Lucas Tanure <tanureal@opensource.cirrus.com>
References: <20220817131809.312533-1-shreeya.patel@collabora.com>
 <Yvzw0GqUd9ZgxUTo@sirena.org.uk>
From:   Shreeya Patel <shreeya.patel@collabora.com>
In-Reply-To: <Yvzw0GqUd9ZgxUTo@sirena.org.uk>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17/08/22 19:14, Mark Brown wrote:
> On Wed, Aug 17, 2022 at 06:48:09PM +0530, Shreeya Patel wrote:
>
>> Create mechanism to configure device clock frequency such
>> that it is the closest frequency supported by the
>> AMD controller.
> You shouldn't use the closest, you should use a frequency which is
> strictly less than the requested one - driving things too fast will
> generally break but too slow is pretty much always fine.
Hi Mark,

yes, the code is actually configuring it to use the frequency which is 
strictly less than the requested one.
I just didn't use the correct words. I will make the change in commit 
message for v2 once you review the patch.


Thanks
Shreeya Patel