Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 17:32:25 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org, vadimp@mellanox.com,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, vadimp@nvidia.com, petrm@nvidia.com,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v3 1/2] Revert "mlxsw: core: Use different get_trend()
 callbacks for different thermal zones"
Message-ID: <Yvz7+RUsmVco3Xpj@shredder>
References: <20220817130227.2268127-1-daniel.lezcano@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220817130227.2268127-1-daniel.lezcano@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?igrjcZd9kvA8w9ices4dJTIDgilplO12nwWrYCdfgcQp6MpXYFL14WVqDVcB?=
 =?us-ascii?Q?hP/ClEaJEdJ2/DUoGXHcJsxAGEw+EFZRaSEzrak5tyZWYBo22YD69t/XDf/L?=
 =?us-ascii?Q?T9cTFYdPrAEgLJ4cxuJE1NPegQ1UsBh8oHpHkpfcc39iMF7Jhkka0YwES7Y+?=
 =?us-ascii?Q?dl6lVXwIMz1/UMMczY0bmDjYQ0Pqlg6sVt3ssPzl/0QDXlZzr8ilQodnuIob?=
 =?us-ascii?Q?BM/1oaeZ2j4oSRZ7GBH/pC5ubTaNnjNhUM3cFgT3P5ibPROxmUEhtb2LCJ3i?=
 =?us-ascii?Q?0Fk4kHGUUL4edQ3S8KFb9E2vAsWaJ6hcKJQdZOan3LvBW2YudSBIN1apBnT9?=
 =?us-ascii?Q?GL0StNuSNkXEAx4WJa9qTOSDw3RvNjdT61zEtHuMgr66sbX8zIwYvh4WzB+0?=
 =?us-ascii?Q?zCtGFIm8peiiWnLn1JQqIf7Cx0PLK7PpGtXZOcwilQykFoovdUY+k4QNZrfj?=
 =?us-ascii?Q?1RshoQXvCua6xtYPeeQRtvHTYOY0vuG/7d1KzNvktbHWwfTiruW+MbO7q46l?=
 =?us-ascii?Q?OH5xsCh/SbJpJK3aVvBIdfN+LUQvDaDIjJfEGCiuiCi9bXsIu4I2TgbqWxer?=
 =?us-ascii?Q?a37ab65iVlqC5nLn6mQ47K90C3Yx5t0y8PaCnqMcqYWHuRlnS7Xk01WDXaRt?=
 =?us-ascii?Q?t2HXOmpZutpKrXf8ljDG0T6gk85x5Wppv/QUCueFEa+NY/omgo10cR20A8M+?=
 =?us-ascii?Q?8J6jbYxmaymC5lL1Agm05z6wj78dW2OMnqZ13XQwWKnescA5jjrLVQYWaZm6?=
 =?us-ascii?Q?CBYyqoUfl5zyOj0iCIPCT9NlZa8k+jcJQlvf1psFSzaB3HX2aA2UtZvVFvgQ?=
 =?us-ascii?Q?rj/HPQdQpvc1GgxnczzCyJyQwjo7RkWqbsucB1acugChLQA5ytFkvn3JyIwc?=
 =?us-ascii?Q?KYBcJSD5gWtc0sR4oW2bB7g5a70qj5xS9LHzuPnBdHDql3O2XjWwK/ZE8gAl?=
 =?us-ascii?Q?zU/jKPZDDqxKJN7wHFS4s1bJOMwILMUUjzHPpiEkscmG8pZgE6MDEjNSqCYF?=
 =?us-ascii?Q?GxM1wx8AhzeaJLlDeZg0QDXpTG0SHiA+LbhiiXF64D9JyqGM2lXC/364JGQK?=
 =?us-ascii?Q?YHHMo9n0T+zcXPw6+rjhJGTKRAkXFtcRimgC49NkZAbqnkWivDZH9qR/7y9J?=
 =?us-ascii?Q?HCcaocTQvYjENAhyoNT2ofIIRPROLzWAO/BM3nGE/rcsjTXQLkaLsf9vjnWW?=
 =?us-ascii?Q?ERwXxj48WHDSa77zLiOBn6rfMnO5EKFIr/pVQBRYJMWNKK9+qMhpF6OeEnu+?=
 =?us-ascii?Q?fdSDh8bYPyrpJeWKlhiNdhr+FlFmVIy9b8rcDPKqDK/VSI0NLsG9v33AJ47o?=
 =?us-ascii?Q?pPo5qUPaPz8UdOa4fe5X3D7de7Rp1I5C8uldoSZcQYntitV759ST75juSCVL?=
 =?us-ascii?Q?Q9UDwp9EOKUDjAYsXJ+4lxxzP01CchtmhIiigwHP46wcAVhTrN+ns9eJXD8y?=
 =?us-ascii?Q?MFOAnp4jQ5w5R50e+ByNJHC8//eZm3Lfe9U/5lHlMagrkjAaRTq4LbTDhP0Y?=
 =?us-ascii?Q?eyPSmOqdudwwxZuIQtsPCarYa395DV/Hk42b03viMu8ndhXBg2DfEp6MjFH6?=
 =?us-ascii?Q?wFNOfnCaCraf5IiMTzGBztd4LWbAqMX91j5Q+0ZK?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af64892d-4a50-440b-c0ca-08da805d5165
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6163.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 14:32:31.3846
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jA8vyTRINGtiOEQLDqMUfDrsNqId2CGFpjM9qmXaEUvJN9MO6H+Vl97kjnNzeOTpxN7Scjq5pxLPVC7a4UZOjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5534
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2022 at 03:02:26PM +0200, Daniel Lezcano wrote:
> This reverts commit 2dc2f760052da4925482ecdcdc5c94d4a599153c.
> 
> As discussed in the thread:
> 
> https://lore.kernel.org/all/f3c62ebe-7d59-c537-a010-bff366c8aeba@linaro.org/
> 
> the feature provided by commits 2dc2f760052da and 6f73862fabd93 is
> actually already handled by the thermal framework via the cooling
> device state aggregation, thus all this code is pointless.
> 
> No conflict happened when reverting the patch.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Tested-by: Vadim Pasternak <vadimp@nvidia.com>
> ---
>  .../ethernet/mellanox/mlxsw/core_thermal.c    | 23 ++++---------------
>  1 file changed, 4 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c b/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
> index 3548fe1df7c8..0eb52665b994 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
> @@ -352,7 +352,8 @@ static int mlxsw_thermal_set_trip_hyst(struct thermal_zone_device *tzdev,
>  static int mlxsw_thermal_trend_get(struct thermal_zone_device *tzdev,
>  				   int trip, enum thermal_trend *trend)
>  {
> -	struct mlxsw_thermal *thermal = tzdev->devdata;
> +	struct mlxsw_thermal_module *tz = tzdev->devdata;
> +	struct mlxsw_thermal *thermal = tz->parent;

The reverted commit is a fix, so only reverting it is a problem. It
makes the get_trend() callback assume the wrong type of
'tsdev->devdata'. Patch #2 completely removes these callbacks, so I
suggest squashing both patches.

>  
>  	if (trip < 0 || trip >= MLXSW_THERMAL_NUM_TRIPS)
>  		return -EINVAL;
> @@ -546,22 +547,6 @@ mlxsw_thermal_module_trip_hyst_set(struct thermal_zone_device *tzdev, int trip,
>  	return 0;
>  }