Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 17:36:56 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org, vadimp@mellanox.com,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, vadimp@nvidia.com, petrm@nvidia.com,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v3 2/2] Revert "mlxsw: core: Add the hottest thermal zone
 detection"
Message-ID: <Yvz9CIelQSbGuqCg@shredder>
References: <20220817130227.2268127-1-daniel.lezcano@linaro.org>
 <20220817130227.2268127-2-daniel.lezcano@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220817130227.2268127-2-daniel.lezcano@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MrK/IqKt9wf5TOsYstctZvFNNGg43DlQt0IdGjiinsLfK2WrX5yQuhfcQoHc?=
 =?us-ascii?Q?UhFbTd9u4sQEY85uobO+HIObXqnM4VuXxpwCu8hprxzpg8nx7F2aX6d9G/aA?=
 =?us-ascii?Q?km1Sbg5jFQ0E/9Zd2Q/dc4cQ6II8seDVviQGa6qnAu8hv9xJHM828NmZSILu?=
 =?us-ascii?Q?m8JvZQwqzE9AVGsVKF5fmaHbm251KQyH/vBGArIQL+kGZNmjOJgqcPjBR7Xq?=
 =?us-ascii?Q?vLZXH221jiMg3a26x8Z14p3MYe27mRDoYtj45KVEZ7nUc02HOdpZ+qf+kEWD?=
 =?us-ascii?Q?nrud4GC+5oz2maf0+l7C8TA/KWcIvAxw1KWA8cE6tKX4Jf3b8AmtMii/ISUT?=
 =?us-ascii?Q?WfTfFCo26xSFDgpFgcOH0r8umNB8h8FcGBHsqnbJaFBQABW+mV+3BdC0Famz?=
 =?us-ascii?Q?7NPGpSU2PTtXk8AILamyOnKWF8+R9u08pC5UQqVO05hFEv4fPeDbtkY1w/lo?=
 =?us-ascii?Q?CoOOc3cr/oJ6tNCRxW9qc1TbvHQGgGxF6z7ZR97HHmaGNY5kFMrKIlVEaijH?=
 =?us-ascii?Q?1MsLJphIuU5IQEGKTmnE15Lqd98T5MwZGp/po1JmgOdaq4ousxnjsB0tHilR?=
 =?us-ascii?Q?DtfY4J5q//pCToVZImvdFvdSLEciNa+Q3uT4rzd/LVxGoh5sqeVEVdwpMksy?=
 =?us-ascii?Q?ujY5NV0sv3HPfTRh63XdlXGywC4QXqi48rJn+1bDuBL2pMQKjKpVrRU+a6Bu?=
 =?us-ascii?Q?dxjRxOUzdVArnJJc8pCjAkzmbyKTutmHQ0Te7EA+GV0kPOYaqbn6NPgeDoPM?=
 =?us-ascii?Q?AZwJnqwHRkujVZuj+1ortle7T1ZZ5EiZH+kAoQQI289N59HlaSfDqxYJsmdV?=
 =?us-ascii?Q?4q/8JiyihR191oy8s/W3M8tv6gftmPK0K5t+geXag6uh3HGv8k9MP+tx4JGh?=
 =?us-ascii?Q?haVtCNFC+O19SBQietgDuJrDcPxYqSGHiOjr+G0kpDxwprb4wInINtF02YJB?=
 =?us-ascii?Q?AuiGKHG8XzYRXxS86oORN95gJ/3+OSEadwaXi1hlTJLdK4G36fFqCyItfrJJ?=
 =?us-ascii?Q?4TTA7nt3OHkLEyHSKgBLjfxA+AtTZyn6gOtnWK44dHWTHLfULrswebdqBdZf?=
 =?us-ascii?Q?yZZVLm6Rx+0ewkxHcz/3hAQeVrt8uIVo9ZrvtNYYteXF70tBMU1h7/rpm1lg?=
 =?us-ascii?Q?3SNX4EztphuzIaA/0ggKXHdPiWsozwVRK7PnEAR1lIT2n8CO8MPmq+MsbIYa?=
 =?us-ascii?Q?Y5pqb5JuNgrD8B0dA9Mjwm0cKsSPtB8BwTMEnTICzQPnSafxr0p6UG5ai3bP?=
 =?us-ascii?Q?AWVKphpDRzn4StoFD0wyrv3xy/vsSbWjw+rUI0lUnY7fUJ7VLhsQ5PXQqwBh?=
 =?us-ascii?Q?O30reS/v6zJy8S0bsuR6JfsVT/Al8mJZcGqOTsmVKeh6X2zGwaTtRn6E5gZv?=
 =?us-ascii?Q?M4WS/BhKbBRrXQ9m4DqYoRYTliUJV4H0t+7fJaoRz/nH6V5uack6PJdOoMGH?=
 =?us-ascii?Q?bTDXAy8zrFI1UrHW+4PTP8+r+M9lKWdq55GMo1shgzaRW12P69aIb8G5xluA?=
 =?us-ascii?Q?bJ+NEDDoGIrqzVqgOP5rBCZRzPHn5TuYfxWivipofuLaOk6VjvB3cBOHjXxp?=
 =?us-ascii?Q?DqxfAEJ/AqE/0BtLVfrBon2edOW6R/Hhg7n/be6s?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 323e8a9f-98f5-44db-1b3a-08da805df27f
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6163.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 14:37:01.6326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SmHH6xr8MsY3MWEu9M7dTX/3YXZ7GhweKcdjK/bo/GkZ0dY03uWiZU7Ag1+OXHgJOS1NSjqBe9yvrchLYqeHHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4320
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2022 at 03:02:27PM +0200, Daniel Lezcano wrote:
> @@ -285,10 +254,8 @@ static int mlxsw_thermal_get_temp(struct thermal_zone_device *tzdev,
>  		dev_err(dev, "Failed to query temp sensor\n");
>  		return err;
>  	}
> +

Unnecessary blank line

>  	mlxsw_reg_mtmp_unpack(mtmp_pl, &temp, NULL, NULL, NULL, NULL);
> -	if (temp > 0)
> -		mlxsw_thermal_tz_score_update(thermal, tzdev, thermal->trips,
> -					      temp);
>  
>  	*p_temp = temp;
>  	return 0;
> @@ -349,22 +316,6 @@ static int mlxsw_thermal_set_trip_hyst(struct thermal_zone_device *tzdev,
>  	return 0;
>  }

[...]

> @@ -680,6 +623,7 @@ mlxsw_thermal_module_tz_init(struct mlxsw_thermal_module *module_tz)
>  							MLXSW_THERMAL_TRIP_MASK,
>  							module_tz,
>  							&mlxsw_thermal_module_ops,
> +

Likewise

>  							&mlxsw_thermal_params,
>  							0,
>  							module_tz->parent->polling_delay);
> -- 
> 2.34.1
>