Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 17:53:26 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Reinette Chatre <reinette.chatre@intel.com>
Cc:     "Dhanraj, Vijay" <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
        Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] selftests/sgx: Add SGX selftest
 augment_via_eaccept_long
Message-ID: <Yv0A5vjd0OIfxxfT@kernel.org>
References: <20220815233900.11225-1-jarkko@kernel.org>
 <20220815233900.11225-2-jarkko@kernel.org>
 <6b304bb4-01cc-c88a-7299-19217a7a692b@intel.com>
 <YvwpX7pYOW3Jv+vJ@kernel.org>
 <DM8PR11MB55913534E8CE66F63460E707F66A9@DM8PR11MB5591.namprd11.prod.outlook.com>
 <24bd8e42-ff4e-0090-d9e1-cd81e4807f21@intel.com>
 <Yvz+yxnxp8G6KzHi@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yvz+yxnxp8G6KzHi@kernel.org>
Precedence: bulk

On Wed, Aug 17, 2022 at 05:44:31PM +0300, Jarkko Sakkinen wrote:
> On Tue, Aug 16, 2022 at 09:35:27PM -0700, Reinette Chatre wrote:
> > >>> This portion below was also copied from previous test and by only
> > >>> testing a write to the first page of the range the purpose is not
> > >>> clear. Could you please elaborate if the intention is to only test
> > >>> accessibility of the first page and why that is sufficient?
> > >>
> > >> It is sufficient because the test reproduces the bug. It would have to be
> > >> rather elaborated why you would possibly want to do more than that.
> > 
> > That is fair. An accurate comment (currently an inaccurate copy&paste) would
> > help to explain this part of the test.
> 
> I would simply add something like:
> 
> /* 
>  * Define memory pool size big enough to trigger the reclaimer in the EAUG
>  * path of the page reclaimer.
>  */
> 
> Suggestions/edits obviously welcome for the comment.

I wonder if we could put .bt files somewhere to make them available. In
root causing this bug bpftrace scripting was the key so it would nice to
have them available along with kselftest.

I could imagine that we end up also in future to bugs allocation so
it would have the script when you clone the kernel tree, and possibly
more scripts in future.

E.g. add bt/alloc-error.bt under tools/testing/selftests/sgx.

BR, Jarkko