Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4950393rwb; Wed, 17 Aug 2022 08:33:02 -0700 (PDT) X-Google-Smtp-Source: AA6agR4+HiWGWm18yjk8v7mHaGxSY8LLBVhE7WTS6Ln/FhcCTuvRB+Kw2Ar9F+ntFst1bTFEeXEZ X-Received: by 2002:a17:902:dacb:b0:16f:6d84:b6ca with SMTP id q11-20020a170902dacb00b0016f6d84b6camr26102485plx.19.1660750382046; Wed, 17 Aug 2022 08:33:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660750382; cv=none; d=google.com; s=arc-20160816; b=mG4HhCJATacE3LW7ZtPxZ7rMRX6wbTCfjb1JWUzoxN6scOoV8ZUFk7YubfXkcyKs0I Yil2KQm95E/HTnLPB4BPOM26IB+UBvf+Iq+fd+951EpMJ2GEWjLLab5Y7dyaWC0OI/Do b1Ix+mmZAIOdSK5nEbZBo2D8jRJFTx36Z8EA0oj+Yzy46nQYShUH64YU3/G986lKn5eH g2v1pHervJGhwxYXgcxdcakl/PpOkChXCDtev0bnzRs+r3M503EB5YTyBgLXGYT900w+ UdSTo8IWDAOD1CHdzglfHHnFU745WdPRJWATTvXbR0ikJr6uppcGDx93hcVsTYGjJ2uj EL4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3EvC4hR1QFYrZqdfTLzQhLup5Rusz13ocuLpSWLUtzc=; b=DMUe1oAIi/MEMwR0zEQFXM+vPQjr8tjv2mVCRWHHDQ6F6rZCqxEiJ4mroQe+Kpd2FD cbTAUa283Dk20hqIdFgCP1l0HsRUA4PUqMSG3W9kir2HQWCZA3rFbXOJOdMKzHK/ETJB iknOltW01pp5Feidb/aKTjTHuwN6UPtVG89wB5yS669lGLr5XlGfKF3ksp65r3JvcQ7A Q+BZCprBSx4F4FV+HpxCwEfMzBhvVGL4fEPjG4qc/3rjSSRVvAHi9JxI9er7gm8herBR DiUhhmNPYRt0POzRwAwRdTUqRskVs9wAtCY1CAgFdw8SkG20M1gm2x7dZqIMEbthGjcb EvTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lwkPzrQv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 69-20020a630148000000b00428d6f8b8e2si1614715pgb.401.2022.08.17.08.32.51; Wed, 17 Aug 2022 08:33:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lwkPzrQv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240280AbiHQOoh (ORCPT + 99 others); Wed, 17 Aug 2022 10:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237255AbiHQOof (ORCPT ); Wed, 17 Aug 2022 10:44:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8474C49B42; Wed, 17 Aug 2022 07:44:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 31C64B81DFB; Wed, 17 Aug 2022 14:44:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F0DDC433C1; Wed, 17 Aug 2022 14:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660747471; bh=5+hesGY57xQHtUlGuPxqV55DlNRITexFStZnpOUjosc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lwkPzrQv4yGKxWlawuNpbVntJN4LEfpnbd0DbhhcYa0Njc3wfN+lEwn97cL0QnFYT NItsXu9JdTxMuD9S7eusL8VI/FJT20pmBc10Daec5Zw5VVUn9kGbxEGeWuO6LkEYeA SzQNHyUkl03Ptn2kTbrS9EY/K8W5JfApm9xKwAZ78uaUbtEPZOj8nR+1L6metNylHX mUlqaxIRjoonfvd+Npfwwei1amC4kvhWGCi4RRSdZX6itfCXTav1dXbKmMULYiTaVG rVc10EPbb0vTf88hVHn1ai87xODmTFqXC0aCARKtxz8QE/ehS0J2ZLVBa/ISrL7Mg0 K2avT2zDGd4lw== Date: Wed, 17 Aug 2022 17:44:27 +0300 From: Jarkko Sakkinen To: Reinette Chatre Cc: "Dhanraj, Vijay" , Dave Hansen , "linux-sgx@vger.kernel.org" , Shuah Khan , "open list:KERNEL SELFTEST FRAMEWORK" , open list Subject: Re: [PATCH 2/2] selftests/sgx: Add SGX selftest augment_via_eaccept_long Message-ID: References: <20220815233900.11225-1-jarkko@kernel.org> <20220815233900.11225-2-jarkko@kernel.org> <6b304bb4-01cc-c88a-7299-19217a7a692b@intel.com> <24bd8e42-ff4e-0090-d9e1-cd81e4807f21@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24bd8e42-ff4e-0090-d9e1-cd81e4807f21@intel.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 16, 2022 at 09:35:27PM -0700, Reinette Chatre wrote: > >>> This portion below was also copied from previous test and by only > >>> testing a write to the first page of the range the purpose is not > >>> clear. Could you please elaborate if the intention is to only test > >>> accessibility of the first page and why that is sufficient? > >> > >> It is sufficient because the test reproduces the bug. It would have to be > >> rather elaborated why you would possibly want to do more than that. > > That is fair. An accurate comment (currently an inaccurate copy&paste) would > help to explain this part of the test. I would simply add something like: /* * Define memory pool size big enough to trigger the reclaimer in the EAUG * path of the page reclaimer. */ Suggestions/edits obviously welcome for the comment. BR, Jarkko