Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 15:29:04 +0000
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     Ashok Raj <ashok_raj@linux.intel.com>, X86 ML <x86@kernel.org>,
        "Andrew Cooper" <amc96@srcf.net>,
        LKML <linux-kernel@vger.kernel.org>,
        =?utf-8?Q?=C8=98tefan?= Talpalaru <stefantalpalaru@yahoo.com>,
        Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH] x86/microcode/AMD: Attempt applying on every logical
 thread
Message-ID: <Yv0JQGa/2BlbQChZ@araj-dh-work>
References: <20220814120026.16118-1-bp@alien8.de>
 <YvtcGEHX8eSFpALX@araj-dh-work>
 <YvuQgx698T5cgF+C@zn.tnic>
 <YvzbFXnBjNjK+UJK@araj-dh-work>
 <Yvz53AAh+p5Db7CK@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Yvz53AAh+p5Db7CK@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sKjFuuMsWlHUPRKSlm/JR3109PkjixHnklYwj9Yw2rpXufQot//IOOZRjBGt?=
 =?us-ascii?Q?5xwBksTI/GLshGGKy9ha63F5qzWvFd7TLy2EpVZyF70bafUpscjOt6uw5E2t?=
 =?us-ascii?Q?eR3Ji6AUSbKagpeniAJlan78thKiITAZ07Uujxb4i45r4G41uaY4Pn0RQ6CA?=
 =?us-ascii?Q?VRAkkq7CEMzepnAN3GNJOg3CXTpXLOYHPElBOc2wISD/CeS7nEEbxup/KZ8X?=
 =?us-ascii?Q?G02myvtX0Yd3Mo6RbSdyvdewUT3ouLM9LCzql2y9Ad5HJsU5ZaPNpq2XWGdv?=
 =?us-ascii?Q?9rwq4wS4D6cT23VvbjpDYen3lm9SVFJEZcDpaW18PL3jEht1YwXjOtsRWz//?=
 =?us-ascii?Q?d7k1qlXNLZPtUJ4cYzlV5AaMPGL2N6W1C95I633o2GGMjHjpNfHH0pDwdes3?=
 =?us-ascii?Q?nvrlszOWXdiDtICQXOBXsDxNALH4bKoZVHI/50LZ/tMLEmxWZpq3l19x2Tmm?=
 =?us-ascii?Q?+OvY8CkS59A24eD6Ji12BjalUEz2esjr4uHBB9ia9JHC7kuTOxfrBXdjFRwU?=
 =?us-ascii?Q?bQylYGjoF4wOuQQZej36xjXlvl7NrH8wykQCoOlbS5Tv8YFf9Dt4wGPXA29s?=
 =?us-ascii?Q?gj9GlG0E71mS+K7hjcYfv4gViRSY+zlQIbF5Qlg6VcIgNJ9CdbJvPJWEadUN?=
 =?us-ascii?Q?TBb7pdAsS0Z8ilzJdd5PISy+DZKSk1ocHAI4uFjGNUsHgmCL0zL3htkWL0+V?=
 =?us-ascii?Q?LLVMpGdFYnzYfOxuWC2TMO1DkjQeoaEXwNpI+9ncvOW4HybXaNSzUkYmoQab?=
 =?us-ascii?Q?tOEwZsq0Aii0oCtzCkBJbPddrFwNTdJju6pzQ2uPAapCpR5+Vrf1lJBe/HgG?=
 =?us-ascii?Q?pkuNlpSe5mUx6CnCznZHmR+6IEMp0KpfRCB+VTkPdhQJ/h6zdxyLhJZV/zPt?=
 =?us-ascii?Q?Rfu4BkXSIH/DchqYk/6MsTSNCzbmQcq1F8wc32b2zJJLSGy/QSVZ/dg6fljB?=
 =?us-ascii?Q?2/PHltoxSPjWwInhco2DzZy16IFlWFlP9oWaT/oN9mCFJRoJoEBaOalZo7F9?=
 =?us-ascii?Q?4GymWSyZgC0XQVP8zZ7lRllhGZlAn4wQLhp0ElqrKYzJtOLauE4LaUKaKfSu?=
 =?us-ascii?Q?du8QdAhrwxujKFBxv8OrjMToM3UF9QhegFsfyfRjOOROXrlmy/srB3AvAT9H?=
 =?us-ascii?Q?hB2VTeDB3QuJjxLtUVGxq5lmuj2685ma+WVfTALWW7GDj0TssAzGC9bJZb++?=
 =?us-ascii?Q?j4FkWStoLjFcuv/zCSp8maojpI8J4HvCKgAnhSGW/X9orgwsSL2PXM0gRkOf?=
 =?us-ascii?Q?24mxAFOjJ4esK5gjnV/Qys0fEKHb7hkcdgQ8IxkpNZqD0DGnDk6INzaLp5JZ?=
 =?us-ascii?Q?Qg0Zv4G97Ykx+3nB4BBh5hySjweUMOsaE5r/ogb653w+LQhvbzxDTgtADITf?=
 =?us-ascii?Q?T5yNYnxvM13GR1d9PDGUzqYdDwcMpSCbuY52RKoj4oBnbqS7ARnNWOH4nUVe?=
 =?us-ascii?Q?WS06Yy36VCMMTzR51MD2KJvbvL2kQ4TuaGzN7zMOTMXgoGHLoklSGUsi9fPW?=
 =?us-ascii?Q?B8ZUY+iSy9PkMsI32+HdawYcbZvEuy180YrsdqYs4aHwjMHFGoDKfzqkkko+?=
 =?us-ascii?Q?trDLcK/uFjs/VEOOYff5e82DrD78LcxAGdwGImeHvMQLtlcgg3NPsDtYgL4Y?=
 =?us-ascii?Q?4g=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d1f35d69-0560-4864-7bd8-08da806542ce
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 15:29:22.8789
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NuPKqEj/YOEvUTtU4cyt0f1Aemqk8GMIYiMh31hP+KDRaG+Gr7n+BivQvwRyKixzbnSEmlYhp8CWD64Pw/cDzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4740
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2022 at 04:23:24PM +0200, Borislav Petkov wrote:
> On Wed, Aug 17, 2022 at 12:12:05PM +0000, Ashok Raj wrote:
> > Instead of doing a complete hack,
> 
> What complete hack?!

What I meant was the patch removed any and all revid checks *completely*
Instead of even limiting to == checks.

Once you do that "in spirit" its the same end goal. Isn't it? Although it
might be required for a completely different reason.

> 
> > could we maybe revive what we attempted
> > in 2019? At a minimum it will work for both architectures.
> > 
> > https://lore.kernel.org/lkml/1567056803-6640-1-git-send-email-ashok.raj@intel.com/
> 
> echo 2 >... - now that's a hack.

Its all in the eye of the beholder :-)

I didn't mean in any way to bring back the echo 2. What ever you think is
suitable to enable this is fine.

> 
> If you wanna use the kernel for testing your hw, use a local patch. Not
> expose it to people and then have me debug all kind of strange lockups.

So forget the hardware testing part. This is a complex flow for late-load
and how can we get more people to test it today in the community?

Do we have a more scalable way to support it today? 

This is similar to XEN supporting, ucode=allow_same, there is precedence. 

Doing that is just like having a built-in self-test for microcode loading. 

I think there is value in enabling it for x86.

Cheers,
Ashok