Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Dhanraj, Vijay" <vijay.dhanraj@intel.com>
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     "Chatre, Reinette" <reinette.chatre@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
        Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] selftests/sgx: Add SGX selftest
 augment_via_eaccept_long
Thread-Topic: [PATCH 2/2] selftests/sgx: Add SGX selftest
 augment_via_eaccept_long
Thread-Index: AQHYsQBK2Ad8oao9B0eIzoi6SNarlK2xt+wAgAB3W4CAABDRIIAA7BOAgAAQJ2A=
Date:   Wed, 17 Aug 2022 15:39:36 +0000
Message-ID: <DM8PR11MB55915BB75E3A6D266FC8D51DF66A9@DM8PR11MB5591.namprd11.prod.outlook.com>
References: <20220815233900.11225-1-jarkko@kernel.org>
 <20220815233900.11225-2-jarkko@kernel.org>
 <6b304bb4-01cc-c88a-7299-19217a7a692b@intel.com>
 <YvwpX7pYOW3Jv+vJ@kernel.org>
 <DM8PR11MB55913534E8CE66F63460E707F66A9@DM8PR11MB5591.namprd11.prod.outlook.com>
 <Yvz9g1dx9qbbMXJf@kernel.org>
In-Reply-To: <Yvz9g1dx9qbbMXJf@kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.6.500.17
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?maEjiwh0qGY1cZ26AYNtAMaNXUlAswpMRAf0kyqN64s5G+/jPlfHGiy0IVq7?=
 =?us-ascii?Q?N4RNTjihTsXTqPr8BvGjMDp8WW5ZyWimQqIpQx48eto+oZRA2oGV7wG9vZLq?=
 =?us-ascii?Q?agcltUJxOazC5afEVtqjALldY18xkJf9vymstmlcNR3QJqz0gsZq+sO+rxxO?=
 =?us-ascii?Q?sI7vZfPI2ntalm9xZasjJoMF2rWXvLS8OiBeib/nKFxB+XEDBWJX53x/PXst?=
 =?us-ascii?Q?bQBu0WRv7kW5m6FdzeMqd5Gk5za3j0gil0m7nFr48mIm6vGKHWs1F0aGRSlc?=
 =?us-ascii?Q?t65V+DNNX5boaVxn1cEYMwS6ZJiYPUdj16SJG+nFeB+UuDwyVAHsr1ZErhgd?=
 =?us-ascii?Q?Ila+JhbIio8Ikt0y9EBrWx3APW/zLlj1ZyS3GG5ExVtSQJfzGh2e81el8iiz?=
 =?us-ascii?Q?meZVIdkA0wSb8oqvY0ElAChp46O6YeP6soG9QqzLfehnhw8xq7St2Bo/cSbY?=
 =?us-ascii?Q?bDFeC0hFx4pgpTrZ5mPn4v64S0D7PBKQkP21ko2sfgqGV/xGCuO8zVeYAF/t?=
 =?us-ascii?Q?d6+YhoVi50P+z/qNJYQggcfOmtq4SM7esgAUnIy7BQ2BQTUkx0sRXtqgBVRL?=
 =?us-ascii?Q?4SddFrxELAnfY3MCcepRgTeTC42bCpsHUijqjVdp3gZllEo7euJErjCFpR9t?=
 =?us-ascii?Q?/xhQWwsDw3LMAhNcslILs97C9hCUdQe2+BpeKSiUXDYw7yNrkcuE3pt4sUJ2?=
 =?us-ascii?Q?F/eU5rZURVDDUSIVo9OuwoCGyHFaNFrTnTrPyGQKj9CXDFO1kK/6ijzke0No?=
 =?us-ascii?Q?v9eP1rWYrIYT6QK3PUcyPBqKN/nFjn4mK0NjoHtWy4ZbD0RHEHNUFHlp5UP/?=
 =?us-ascii?Q?5QTu6pzY87m3S+CIu1azew/b2N+CICv5e1EFxW/HoJDzLgKLSkdjtfh/SSKc?=
 =?us-ascii?Q?A2+VZWPOWY4T0GKFI2JKaQ+daQTGdhmJIw9iiqfFsWOodGV2mghe8x0nA9fN?=
 =?us-ascii?Q?or0VrfalX26a0PYNNZHc+4pWl709aXjX7cRgmhv0GrBfWocVEoMdGSeWgL0S?=
 =?us-ascii?Q?3ha7hxTIxUnykMZ+SUlEIBcguS2M62kNXLghDC008F0EIJGIaNyaXtZN4urc?=
 =?us-ascii?Q?yWxyKVbrd1jwgMoTHrXMohn3pYQos0dQGQPqthA5PL+XCiGqSsHg11DfxJ1X?=
 =?us-ascii?Q?g37f8L5TUTAaclo1ypqyJiF3deTFoayLhvsCURzEgUlP6elbMoojYizV0ALU?=
 =?us-ascii?Q?MQUiYfPfIideoSwI9IQbcrNoGzhjb1LK1rRdepX0lEk6uTkmdW39RmAC2Emi?=
 =?us-ascii?Q?a4fWAJRNRK6VeOMzqfJCvJUMWN6I0WOWA+ev8nFSMWvhQv3YrY6mHZ7U8979?=
 =?us-ascii?Q?ci7UxGIMUtTPyHSyM1oGwheKBw4+z1pZyF3e9tIdCaaqqWN391Qc59gkHwVG?=
 =?us-ascii?Q?/ZozxbqOeNCwv0HJH8BkD9LfMIkRXn2auZRXN7WgzY6iWqmkutBs69DJvt/Q?=
 =?us-ascii?Q?TZN0Pz9i4Ji02Dqxb8XewuvJ/R1/DWLb7KNXbY2WVss1vPDYLWfs42uHZOeA?=
 =?us-ascii?Q?9zzW8G1+QUDngGPw9siYRa+FbW3uQD8Dig7KWgEMTFxk6MbCo1wfSpRtVuxr?=
 =?us-ascii?Q?1FG1jdcoVp48jDm/0yWYI1RyS8o9JDN1fQl3Ywz3?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5591.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e09984f-72d7-4b85-2b27-08da8066b0e0
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Aug 2022 15:39:36.8690
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PBd7LlAfR5hVsp/Qa6V+yZ/mrSHyZYnTH8kUpRyNyEaZyY/Yr63ZwsmhRBAEiEV4sZUtUdgr5EVruPCaObNsIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6299
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jarkko Sakkinen <jarkko@kernel.org>
> Sent: Wednesday, August 17, 2022 7:39 AM
> To: Dhanraj, Vijay <vijay.dhanraj@intel.com>
> Cc: Chatre, Reinette <reinette.chatre@intel.com>; Dave Hansen
> <dave.hansen@linux.intel.com>; linux-sgx@vger.kernel.org; Shuah Khan
> <shuah@kernel.org>; open list:KERNEL SELFTEST FRAMEWORK <linux-
> kselftest@vger.kernel.org>; open list <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH 2/2] selftests/sgx: Add SGX selftest
> augment_via_eaccept_long
>=20
> On Wed, Aug 17, 2022 at 01:27:38AM +0000, Dhanraj, Vijay wrote:
> > I think changing it to "int i" will cause a buffer overflow with
> > edmm_size being 8GB.
>=20
> Hmm.. 'i' iterates segments. Amd I missing something?
>=20
> BR, Jarkko

It is also used when iterating over pages to eaccept. This might cause an i=
ssue.

	for (i =3D 0; i < edmm_size; i +=3D 4096) {
		eaccept_op.epc_addr =3D (uint64_t)(addr + i);

Regards, Vijay