Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp4973516rwb; Wed, 17 Aug 2022 08:56:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR7BGSerU70KsF/puaGovrd7PPdKWkQKLw5KUER9SZT5t5mIgsqUhuLNhhJ7TnZ0N0nrj6Sf X-Received: by 2002:a17:906:9c82:b0:6df:c5f0:d456 with SMTP id fj2-20020a1709069c8200b006dfc5f0d456mr17873100ejc.287.1660751786806; Wed, 17 Aug 2022 08:56:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660751786; cv=none; d=google.com; s=arc-20160816; b=Z5EsxdOVMRLEDV0f4HbZ3WdG00fhR0TSuGSC+j8cC/EiglDY3wOlqQJhY2pUP9yiU4 V6ZuEMU8Ml2zlZOhkXNrQtWCoMvnmTw34v7yyjPwfUFuEivLz/RUXGuFuil7O6qa3mXI zEyrAfJk1MEO1ZiU71CFqe2WuiVxACERl9jrsKp5bN94q16kJIvnaogKoEdc55BUNwjs QXonPZhmn6qj9vmb98XuXd5T1Jc6L+XKKn3TzOzD9nw0UgApJQuw+1spaGlECRliq+8i 85SvbuwVg1jSS8PGhBdCZQabxqVDhncWIczcs1nXgVUw5bg/vZPEKmdYYDAS26LLkQFt oWlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=WpyAJTVrfZCL2h1isVm7JNN8VN0Fv44rHjgYEWg7qik=; b=jT2SuOF5W4jvkKTI6t3+AIqlESJxEPQED2+m7mQp2rhit8B5JqsV6CKWeXW5kvzQ5F YUsbXjBIYmgkj07GXlau8KkKtV1929FZBPxcF7XPD1eNtcs1fU34Q+UO5aGeyEJo5n29 TDUscDfepmy0Tn+spfefkrRQLqLsgV4HfJUopcZKgEDuB78woFI7HDZeOq1D+pAbf8Bx d/7C19ngFDCNkcmsgfYL0fB4FKdjYWugSVVzDnMdTKTPoc8QQch47glJrnB0WPRwhMod FT5/tuScyFMQKRRtG4e1GWOkqa7POLr0gk9gQWyS18h+sIhkBT5abdBVHDYhIxACevrF YMIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=BtXfFWzs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g6-20020a056402424600b0043d2db88b04si14359461edb.448.2022.08.17.08.56.00; Wed, 17 Aug 2022 08:56:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=BtXfFWzs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237052AbiHQPsk (ORCPT + 99 others); Wed, 17 Aug 2022 11:48:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234267AbiHQPsj (ORCPT ); Wed, 17 Aug 2022 11:48:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED7F14E860 for ; Wed, 17 Aug 2022 08:48:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A1E8BB81E09 for ; Wed, 17 Aug 2022 15:48:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26772C433C1; Wed, 17 Aug 2022 15:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1660751314; bh=AHeZfy/Nxh85RKgqk8hL9JaiFYeWKnNM/yiUeuArn60=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BtXfFWzsCJkDcjy2yOzYGhRdcGusJrTQhO8VRzdx5/NBDr4bqcyLOnZm+gVi/kq8R 7xpEIDDriJXwmkzaJaBW0UfxrqCSA9Cv5jaZ1CFMVlpWKKTWL67YUk5B5xNdDK2llZ UGQFwn2z0wli5tDoM2zTwWdzcxCGqLVdB886By5U= Date: Wed, 17 Aug 2022 08:48:33 -0700 From: Andrew Morton To: Huang Ying Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Baolin Wang , Zi Yan , Yang Shi , Oscar Salvador Subject: Re: [PATCH -V3 0/8] migrate_pages(): fix several bugs in error path Message-Id: <20220817084833.b348d11eab362b2ac5a02259@linux-foundation.org> In-Reply-To: <20220817081408.513338-1-ying.huang@intel.com> References: <20220817081408.513338-1-ying.huang@intel.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Aug 2022 16:14:00 +0800 Huang Ying wrote: > error-inject.patch, test-migrate.c, and test-migrate.sh are as below. > It turns out that error injection is an important tool to fix bugs in > error path. Indeed, and thanks for doing this. Did you consider lib/*inject*.c? If so, was it unsuitable?