Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5363303b-30bb-3c4a-bf42-426dd7f8138d@nvidia.com>
Date:   Wed, 17 Aug 2022 21:34:30 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH v6 5/5] vfio/pci: Implement
 VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP
Content-Language: en-US
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Kevin Tian <kevin.tian@intel.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Max Gurtovoy <mgurtovoy@nvidia.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-pm@vger.kernel.org, linux-pci@vger.kernel.org
References: <20220817051323.20091-1-abhsahu@nvidia.com>
 <20220817051323.20091-6-abhsahu@nvidia.com> <Yvzy0VOfKkKod0OV@nvidia.com>
From:   Abhishek Sahu <abhsahu@nvidia.com>
In-Reply-To: <Yvzy0VOfKkKod0OV@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDcyRHhCUGx4YjZjcVlKdXBKLzRiMm02K09reWVpZkNIV1JjUGpzRnlLRzJI?=
 =?utf-8?B?Q0p3ZFpFeWJsWmMwQUduV1ZWMWZYNkZ0bG50NEV6NnRYb3ZySDNVMCtkTzk5?=
 =?utf-8?B?VFlCSHJKNFNyNC82V2s1aFlXbUtjTFBzMlJyU2pWNGYvWlR0U2FnZmlNbGNl?=
 =?utf-8?B?di96dlkxNzFzSWhRUEtNREVxejJBSUFSS240N0FTa0JlclM2bDZMdjg3THc0?=
 =?utf-8?B?MHlSd0ZTcTAvcU5oQ1ZLNUtNODhpbjZmbmhKby9aaDUva1M3OFZ6WFhUekFH?=
 =?utf-8?B?bFNSUzZXNlVRVFgrZldxZ1dwVk5pS2FsUHMxTElhekpjaytOQm1Jc3pSZFJu?=
 =?utf-8?B?UE5TQ2xGL0ErcWFPSzBJTXNuTjl1ZzgxK25pY3NzZXAyMzBhZitiQmFhYmdR?=
 =?utf-8?B?R05xK3B4b0hJR3hCdGxQa3NqOXNJc0psU1lWenBoZFdwZlV0YkpYR2hxWlM2?=
 =?utf-8?B?ZnFyeUV3bDFGMUhnYTBieVo3bm01ZU1YamtqaEs2SVBuSTF6ckY0M0xiTVpt?=
 =?utf-8?B?bGx0VFhkUlBJUGpQbnBMOGxXT3lOTGZiUWtvMUFjTFJvQ3dDa0w4NFU1TDdV?=
 =?utf-8?B?bkl6TXVkUWdGdFhZdWp2ZFRGZSs5VXY0L3dUM1p3ZjRHMnkvbkw1VFhuZVJT?=
 =?utf-8?B?WUMvQ1lhb2JlNXU1cytZdjBlbGN6dVJ4Yk1Rc09ON0dZNkJ0WjJ2K3lGR0Y1?=
 =?utf-8?B?dURYSStsTDcwSUk4K3N5czA3RExyK0Vid3h5bFdzVEdQbVdQWTRFajhCWjlU?=
 =?utf-8?B?dHFmMks1RjM4OXVXUzRRb2pJOGlidVRsUTlIZUsrd2dyZEZMY1NJbkhYWEov?=
 =?utf-8?B?Sm9mZ2J1eVd3eFdXYWpGQ0M4SkJKNnZ2M0g1dEh3RzFsU0lkN1J6ckJ5dWVk?=
 =?utf-8?B?ZkNFQ0pRSVVCcXk1MmZ1TXF4dzVrM2dnQ2F0aCtIYVF5YVhtRU8vODZZcThm?=
 =?utf-8?B?aDdOZFhhZVM1OVE5ZTRGU0ppZDlZMUs4dER1UnJjaEdIZ1J1d0UrTXRIRU0y?=
 =?utf-8?B?WEhrRXZIcTRsVHR5TnBEZ3RrdFJuSnhLbEFVZ0htOGtJN2dBdTdGQ2ZTdzFx?=
 =?utf-8?B?OGJueFZjMU9XVU1GUVU5ak85a1B3ckF3OWxPMTBHQ3dOa2VnRWNkQkkyazVY?=
 =?utf-8?B?ek5ubVM1cEZkRittK1djOHlYaXkrdkxFSmdacFdtQ2dabHN5RGdwQ0g0SmtK?=
 =?utf-8?B?ZEhjK0c0dVVJN2txOHNBS2VhaWRlQ1JJUEN5TmFxUG5UNzJJc3BhZnp3dHFx?=
 =?utf-8?B?cERxcFQ1NDVWTXJWSStEK1o3UnpiNUNhM3Nnb09ySlRJc25RTUFZZC9vSlVS?=
 =?utf-8?B?SE1WY0tYY2ZXMXJveGtXeCtSZ3BvZzhvSSt4dEZMVDM3cmRKdzNvVittOHFK?=
 =?utf-8?B?RndmcjFiZGY0Y0JjL0g1S2JRMzhKcHFQVVNPbGR6VDAzdWRONmRsOWVwclpR?=
 =?utf-8?B?NXlpY2ZwT0krZ0NabmF6ZXVMbnd6RDhRb1I3cXo1Wi9SR01ONS8zam9sZkNt?=
 =?utf-8?B?ZXdLbjJTZzlFbTh2QTNHWUtISC9xTEFqbTk4V0JmSXl2Q3RDUjBQS0VDeDhS?=
 =?utf-8?B?cHZUK3lwWXMvS2pENTRnWnZzMi93S0RKOGkxWDlESUlUZEhtRy8xT0l6aXBk?=
 =?utf-8?B?M3h2N3BxaXcwbUttZXMxU0hFN2Y0SzBIbXYxWDVVVThNKy9CdlpudHZwYWY3?=
 =?utf-8?B?aDcrSTVWTUlhNzJGRnFPcGRtRHJIMTZwRWkrWFREV0p5dUVwbUZ4bGI0d2Rk?=
 =?utf-8?B?NnVlU3hpTEY5akhxWHpXN21pWnJVUXVBUGd0a0JPcVU3WHZyL2pheDlIekM5?=
 =?utf-8?B?MTlhUUdJZTVaNDVZU0J2NXhBbW1RQnBNbGdkQUVPRDQybVVIRGYvNkk4NG9Z?=
 =?utf-8?B?YWdoSXJXYmVUY1VzcGhMQ1czTjNhcDlQNkJoTGl1Yi91SGhkc0h0cTg2WEll?=
 =?utf-8?B?ZHo5dHdrVTdka040V0J3T1NKc05WZnpRVjZnOE53TllXMGxXcWF6WHcycnZj?=
 =?utf-8?B?Ykc5YzNqTk1QaCswK0sxZTRaWVJ1NURwQ0FodlhLT1FoSEIwRFdXSXhPeTFF?=
 =?utf-8?B?SEtLSmZnb284dmlQbXo2NHkxdUNua1lMM2toVWhiNFdHeFZka05JOG1SNkNO?=
 =?utf-8?Q?2dewS8d80/pk6nqlMa7xKv7GR?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d24e28ab-85ff-4dd9-7703-08da806a322f
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5304.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 16:04:42.6499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cF9osWuhLQoWRFMeXoTw7lKxIyi+L76MpumEs2DIicZGegiVcddXVm3MvLWoolhvnpbfiup+v7sRbm89poLGag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB2403
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/17/2022 7:23 PM, Jason Gunthorpe wrote:
> On Wed, Aug 17, 2022 at 10:43:23AM +0530, Abhishek Sahu wrote:
> 
>> +static int
>> +vfio_pci_core_pm_entry_with_wakeup(struct vfio_device *device, u32 flags,
>> +				   void __user *arg, size_t argsz)
> 
> This should be
>   struct vfio_device_low_power_entry_with_wakeup __user *arg
> 

 Thanks Jason.

 I can update this.

 But if we look the existing code, for example
 (vfio_ioctl_device_feature_mig_device_state()), then there it still uses
 'void __user *arg' only. Is this a new guideline which we need to take
 care ?
 
>> @@ -1336,6 +1389,9 @@ int vfio_pci_core_ioctl_feature(struct vfio_device *device, u32 flags,
>>  		return vfio_pci_core_feature_token(device, flags, arg, argsz);
>>  	case VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY:
>>  		return vfio_pci_core_pm_entry(device, flags, arg, argsz);
>> +	case VFIO_DEVICE_FEATURE_LOW_POWER_ENTRY_WITH_WAKEUP:
>> +		return vfio_pci_core_pm_entry_with_wakeup(device, flags,
>> +							  arg, argsz);
>>  	case VFIO_DEVICE_FEATURE_LOW_POWER_EXIT:
>>  		return vfio_pci_core_pm_exit(device, flags, arg, argsz);
> 
> Best to keep these ioctls sorted
> 
> Jason

 Do we need to keep the IOCTL name alphabetically sorted in the case list.
 Currently, I have added in the order of IOCTL numbers.

 Regards,
 Abhishek