Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 19:11:12 +0300
From:   Ido Schimmel <idosch@nvidia.com>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>, kuba@kernel.org
Cc:     rafael@kernel.org, linux-pm@vger.kernel.org, vadimp@mellanox.com,
        davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, vadimp@nvidia.com, petrm@nvidia.com,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH v4] Revert "mlxsw: core: Add the hottest thermal zone
 detection"
Message-ID: <Yv0TIH0LsjFJwV0L@shredder>
References: <20220817153040.2464245-1-daniel.lezcano@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220817153040.2464245-1-daniel.lezcano@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?eueegQdT8561w8aU9ZTwiwosDh2Ns42Dol4UGNVSZHmnMYV6y3Wwdy6tPcXx?=
 =?us-ascii?Q?9uDsc1mPUVZfvS1xQQQ2MKdaFvonmbwHEZpe56nKjv5bqSfcy34IG/hmu8l1?=
 =?us-ascii?Q?MAdys1kUxawgjlz3HmUjdNm7ujbl0BGpy7muY+ILVJ25z0yHS3V+JjUjgPm4?=
 =?us-ascii?Q?3n1y6nYQ5FH9212jXO2xZ6uHxUwcGlYYFxaxMloLdBol5FaJ3LMU4V2+/L1k?=
 =?us-ascii?Q?Ys4R1AnMAt2CktP3fZtQo/bF5md2YPuFoKMrBIAaSOoeU7PunaRe+nBUPB0f?=
 =?us-ascii?Q?Y+FFMBHVx+SrbKuhgQ8Z2ub6nWy8rXLK5NZe0XRPN3ym5SmHz62pjJFuYk4b?=
 =?us-ascii?Q?3FuVOU71hbD8Hv5c1847DOIsIzcbX5SL+V3zHBg3q9go5nnwkZVrqUDtNdyS?=
 =?us-ascii?Q?Avi5yb8pXN8+clTG/9Gv1P//58chG0W6MvR0v55dkOM6RSFeidXWOIhRigM6?=
 =?us-ascii?Q?fUhI9FGyaKQc/MkQdp4ohUX7xBQQQcKuw+wIjwMGvVUwb+9Q1tDZz17eIQWa?=
 =?us-ascii?Q?E3uPqiew7xliKymnsdjGzUQHasic+s6L13MiRvKJeTwhSp5Hx1ztJ8XHPEU0?=
 =?us-ascii?Q?UXOE81G7SREV/N39ORyFDse/DivRglBpgxrjODGaJ5SMtV92ZFY7KBsBYqyi?=
 =?us-ascii?Q?1gHJ8ruRECamoqqWmJs7qSL3H2piHtvHWu9muWOErvaWTTvwffKa4T2Z+opp?=
 =?us-ascii?Q?Fz8Fk0Bd+446UvGbkmfTWnr8xUInr9Plp5ftrRY/dbEgp5iWKD2LQUDAt+QT?=
 =?us-ascii?Q?8eFqoybwSIhRhLXTPQC5+avYS7LL14jqeTD6MJ2d8xRdRC2ASYKrpY1StCvt?=
 =?us-ascii?Q?C7R0o/y6THI3qmLR98E+SGe68GxCAeMMiAkyPgkH+6ldaIIRIvNAOi+1Dp3U?=
 =?us-ascii?Q?6GW5y4FDFJNYZ53O55ty9zAYnJcRWoVQhSUa/hMu/7+YNOl6JVINDB6xu+ex?=
 =?us-ascii?Q?Th0aljebwpKrxuKJZy51ZjIB242vY41rNVXKYkx0mM5uoQy/LI9/Lr3IcmJm?=
 =?us-ascii?Q?2YfgSpZw9WpKYakisVJ6CSTTC9fUgAFOcoprSXmGTXmP0qXqPFPVK3rq1o7m?=
 =?us-ascii?Q?10WcXn5pkDDB88ImlB+3lQ/URGkA0lia4QwnuVmKhMri+w7mKgaFlbeeL+lY?=
 =?us-ascii?Q?rabMYnXRvzeeBiec8YaZInVkRpZ3HifSmfwxPdC+5/08ppiOge3pZ2FY8IxY?=
 =?us-ascii?Q?HXJ+kTr0x8MMmO4CnMpKEspJ3zesyNKeYS0dS7VIPZI51nXUpkHJJDCETiNL?=
 =?us-ascii?Q?TlDtcqteSmwBYmyGoZikTCZUFlSPnTRhZ1MDU/GMt4UWyp0RjPTZ0fJLRGWu?=
 =?us-ascii?Q?MPe4nQ35sXhYgoWA7Xynl0kdWoltx1t3T1YU6zicvePUDfQI//r/fj4dc6t4?=
 =?us-ascii?Q?btjeqzP4QNan2ybmz/Qb8aUG+M5xh7mGA8kWJ+OzjCsb7teVAmvU10isRF7w?=
 =?us-ascii?Q?QfYlb8W9TmihJX2aaxsiBgAdUPMmm204fV6H3UhPkionuQn0UWaLrkYN6sJy?=
 =?us-ascii?Q?RnOp8lzbQzyasF4oGSabSICH7/AhfsAPSmk3huQ2t8EfBcpXmlLyThdVsrmR?=
 =?us-ascii?Q?vgQd8THdoOCAYQNgvWDTVYYXxUrQHHKU/60h4IaG?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 440bf2ed-f120-4d4d-0480-08da806b1deb
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6163.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 16:11:18.0018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t2uw3bwqRnQ01LK8FAWOvwk0TTNdAtBL5RxKWPqfx13F0DnjbXYlI0usPAUKePthfqnIH1IiYDbMQcHd2zIm8g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6491
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2022 at 05:30:40PM +0200, Daniel Lezcano wrote:
> This reverts commit 2dc2f760052da4925482ecdcdc5c94d4a599153c and
> commit 6f73862fabd93213de157d9cc6ef76084311c628.
> 
> As discussed in the thread:
> 
> https://lore.kernel.org/all/f3c62ebe-7d59-c537-a010-bff366c8aeba@linaro.org/
> 
> the feature provided by commits 2dc2f760052da and 6f73862fabd93 is
> actually already handled by the thermal framework via the cooling
> device state aggregation, thus all this code is pointless.
> 
> The revert conflicts with the following changes:
>  - 7f4957be0d5b8: thermal: Use mode helpers in drivers
>  - 6a79507cfe94c: mlxsw: core: Extend thermal module with per QSFP module thermal zones
> 
> These conflicts were fixed and the resulting changes are in this patch.
> 
> Both reverts are in the same change as requested by Ido Schimmel:
> 
> https://lore.kernel.org/all/Yvz7+RUsmVco3Xpj@shredder/
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Tested-by: Vadim Pasternak <vadimp@nvidia.com>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Jakub, Daniel wants to route this patch via his tree. Do you mind?
I spoke with Vadim earlier this week and we do not expect changes to
this file during the current cycle.

Thanks