Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp5010971rwb; Wed, 17 Aug 2022 09:29:15 -0700 (PDT) X-Google-Smtp-Source: AA6agR7gvQmdOKMRK+BxYzFaB8HtnP5gUIp+31ThOwai4H7HYFRuLmGUVmQTK1UltzND7ql4w5LN X-Received: by 2002:a05:6402:35c:b0:43c:8f51:130 with SMTP id r28-20020a056402035c00b0043c8f510130mr23685268edw.393.1660753754855; Wed, 17 Aug 2022 09:29:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660753754; cv=none; d=google.com; s=arc-20160816; b=c7OfSFcjJG7cev+GHv0JvaOCM6ez+qPz00V4mjWS3xZFmFBDwQ+mmyRz+HNWA6jKdq kFug7IAuUt58mLcIhojYmAE/gJZXsz/BD7+voxixkC2tV+fvQR3aQ8gkKldxAEDalyNh /q58P189fR5CsPmULdPNfJLN/QDNS3fcDMZqRBjOyYvIraZKXLhmugxDz3dPeUHa1tSX DxxxlZk95wndRi4iDpPEnZm0t/8WBPmNhxk61mLHkTz7fG3sOI1TERh42o1w5A89R4yg 5a9w8IhX5Al+LDRLF63ZAk9/LnFIByAlxaFhPKejH9OUARvt+vtcYGO/2XZo70qr7H0I nTwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=XukEBVzTzLJj1tOYCbdeMA5vBle0qiwfRadVpWY8xMA=; b=suFpZuYIocwwK3gAAEf2A6d+MAKUTy3Kd41tIJjp06yAGEVuP7JM+k/2sxXxRGJDTN RjJm8sdt6q902l7soXZtm+1MuTE4D4scqNzJk+4lXNGg9/oOiFcHotpy2scSRK0BW+Nh T+G+NsHjzcIXKy/F2FLZEhOt7F4Kscjv6oX0vmoMf2Qsc9wKVlJGIJ9DioguHAaHUwJJ gQQRvydMpLvaq44wxQsq4SO56f3j1eYpZ4BezMcgGpefRBRZbsp2fgim0WVkpKhfK1u0 z2ORFfQD/8Tmj3uRiYwuFFwecdzVUbypDk6Y4feG4q9bEyYulNGumILuYbmIcGiKPWxR D6kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VFgUbZKL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v25-20020a170906489900b0072b13fa7314si10307250ejq.439.2022.08.17.09.28.48; Wed, 17 Aug 2022 09:29:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VFgUbZKL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231552AbiHQPyu (ORCPT + 99 others); Wed, 17 Aug 2022 11:54:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239604AbiHQPyq (ORCPT ); Wed, 17 Aug 2022 11:54:46 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DD449C1F3; Wed, 17 Aug 2022 08:54:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12660B81E1B; Wed, 17 Aug 2022 15:54:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 717E8C433D6; Wed, 17 Aug 2022 15:54:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660751670; bh=XukEBVzTzLJj1tOYCbdeMA5vBle0qiwfRadVpWY8xMA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VFgUbZKLQbqvJAE845SbZhDTVvhHmhQgtLhCfguEHhIYtM4T4ZgQh1M7ZmV47KF1o myvbbqXhQopL0AuHSaSEoA2kp/+XDXgIibsOyMTBzU3hATaezO14jCAlSQ8o78TuM8 z6A8nbvqnKCXAgPNcCd9ohkd1rL3X04PMLelROp76hNzuknmlRORAGWufZRop6sj5v AjRiEffbGVwNsciRmbHJYY1Cislm0pufqN4WVZ2OGi1PQGr0w07ViPcqxhqYmzJrVI EhiDYCF5f39FjpS1H94KBG4wnE+rOwoe0cFA5tUEsVotNKky+vgD5zSISPDm3qZ441 SWynHuhqTNPLg== Date: Wed, 17 Aug 2022 08:54:29 -0700 From: Jakub Kicinski To: linux@armlinux.org.uk Cc: Beniamin Sandu , andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro Message-ID: <20220817085429.4f7e4aac@kernel.org> In-Reply-To: <20220813204658.848372-1-beniaminsandu@gmail.com> References: <20220813204658.848372-1-beniaminsandu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Aug 2022 23:46:58 +0300 Beniamin Sandu wrote: > This makes the code look cleaner and easier to read. Last call for reviews..