Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: bgHc6JvATVXzyccdnMLLtfMHPvkyzApdZV/NS9qrCodvzvBf774yy9f/rh3MYwydCuqEbeOci+
 NBBO/qLK9ssMDKeR92oYiSWeyflMgujR/JTAO8eesSc1TY6bDUJc69k8A2p+Sb86MDuK2LRg2Q
 jWP1+WhAEmy+UuK5qN5fdWultaB4NkzwoQiosVmstmCMTFJ3I8sR7sv705pvorCzYFTnY860Nv
 La2KMAYc6Rq1kkkWn4UH6SlpEb5GFY791yvMSIi2JqJCI3Aqel8PvlV3xT3ezBhoSwyNCSPDtA
 j5yvgwR/9zRuLUsSbM6VDFNp
IronPort-SDR: UjvUO8HsL+dFez2gq+eM9ig0lS5nxJ3LHoiEtgZFiPHKRaBp0Un34yCpzJMPVMgk5gUfboXeuf
 iFc4up/PH6YS8SSzifXlXHlS7j5rzw/2mlk7DYvN4T3ge2Lacm1DGgtUVzDdYT93tkscQMG7Y+
 ySAE/b6JFf9nBbhrLxoCVw6PrR2M/rBnT//zPwOhkAklJ/4fWBxpMyW0ZV14ojTmkhthO+rH37
 Bbr33GX203yHJcQdvRGR96sHUZtsWq2MfburjCMdEn7kmnd7OEr+4W8t6Loa1Sat3JApBmQiPH
 CD0=
WDCIronportException: Internal
Message-ID: <840ce5cf-32d5-d694-cb79-2df871a607c9@opensource.wdc.com>
Date:   Wed, 17 Aug 2022 09:10:16 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.12.0
Subject: Re: [PATCH v11 13/13] dm: add power-of-2 target for zoned devices
 with non power-of-2 zone sizes
Content-Language: en-US
To:     Pankaj Raghav <p.raghav@samsung.com>, axboe@kernel.dk,
        snitzer@kernel.org, hch@lst.de, agk@redhat.com
Cc:     pankydev8@gmail.com, gost.dev@samsung.com, matias.bjorling@wdc.com,
        hare@suse.de, bvanassche@acm.org, linux-kernel@vger.kernel.org,
        dm-devel@redhat.com, linux-nvme@lists.infradead.org,
        jaegeuk@kernel.org, Johannes.Thumshirn@wdc.com,
        linux-block@vger.kernel.org, Damien Le Moal <damien.lemoal@wdc.com>
References: <20220816131536.189406-1-p.raghav@samsung.com>
 <CGME20220816131551eucas1p218faf35348e78a73aaa87d5477ecdb2e@eucas1p2.samsung.com>
 <20220816131536.189406-14-p.raghav@samsung.com>
 <30790cae-5440-2447-a8b8-52a57fa16fa5@opensource.wdc.com>
 <ab3ef674-c453-5b38-80b5-f41dcfed62bb@samsung.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <ab3ef674-c453-5b38-80b5-f41dcfed62bb@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/08/17 0:35, Pankaj Raghav wrote:
> Hi Damien,
>>> + */
>>> +static bool bio_in_emulated_zone_area(struct dm_po2z_target *dmh,
>>> +				      struct bio *bio, int *offset)
>>
>> This function name reads like it is a block layer helper. It mat be less
>> confucing to keep using the dm_po2z_ prefix for it.
>>
> Good point. Even though it is a static function in the same file, it could
> be confused for a block helper at the caller site.
>>> +{
>>> +	/*
>>> +	 * Read operation on the emulated zone area (between zone capacity
>>> +	 * and zone size) will fill the bio with zeroes. Any other operation
> 
>>> +
>>> +	return DM_MAPIO_KILL;
>>> +}
>>
> Do you see any more issues apart from the two you pointed out?

nope

-- 
Damien Le Moal
Western Digital Research