Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Punit Agrawal <punit.agrawal@bytedance.com>
To:     Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc:     Punit Agrawal <punit.agrawal@bytedance.com>,
        Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Feng Zhou <zhoufeng.zf@bytedance.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: Re: [PATCH] bpf: Simplify code by using for_each_cpu_wrap()
References: <20220817130807.68279-1-punit.agrawal@bytedance.com>
        <CAADnVQJsDYhNmP6G7O8tVfHZ7rQLeJ4KpwAQweVidny0fgTbyw@mail.gmail.com>
Date:   Wed, 17 Aug 2022 17:57:29 +0100
In-Reply-To: <CAADnVQJsDYhNmP6G7O8tVfHZ7rQLeJ4KpwAQweVidny0fgTbyw@mail.gmail.com>
        (Alexei Starovoitov's message of "Wed, 17 Aug 2022 09:41:14 -0700")
Message-ID: <87o7wierk6.fsf_-_@stealth>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Hi Alexei,

Alexei Starovoitov <alexei.starovoitov@gmail.com> writes:

> On Wed, Aug 17, 2022 at 6:08 AM Punit Agrawal
> <punit.agrawal@bytedance.com> wrote:
>>
>> No functional change intended.
>
> ?
>
>> -       orig_cpu = cpu = raw_smp_processor_id();
>> -       while (1) {
>> +       for_each_cpu_wrap(cpu, cpu_possible_mask, raw_smp_processor_id()) {
>>                 struct pcpu_freelist_head *head;
>>
>>                 head = per_cpu_ptr(s->freelist, cpu);
>> @@ -68,15 +67,10 @@ static inline void ___pcpu_freelist_push_nmi(struct pcpu_freelist *s,
>>                         raw_spin_unlock(&head->lock);
>>                         return;
>>                 }
>> -               cpu = cpumask_next(cpu, cpu_possible_mask);
>> -               if (cpu >= nr_cpu_ids)
>> -                       cpu = 0;
>> -
>> -               /* cannot lock any per cpu lock, try extralist */
>> -               if (cpu == orig_cpu &&
>> -                   pcpu_freelist_try_push_extra(s, node))
>> -                       return;
>>         }
>> +
>> +       /* cannot lock any per cpu lock, try extralist */
>> +       pcpu_freelist_try_push_extra(s, node);
>
> This is obviously not equivalent!

Thanks for taking a look. You're right - I missed the fact that it's an
infinite loop until the node gets pushed to one of the lists.

I'll send an update with that fixed up.