Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp5067410rwb; Wed, 17 Aug 2022 10:25:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR6nL9RNk/kQwHYJst9TCJBugVW/NXaR5FN9LF4yFtmr6vGsO+pGeYzxVJnuKop4dmr6CFRn X-Received: by 2002:a05:6402:155a:b0:445:ab8c:6a55 with SMTP id p26-20020a056402155a00b00445ab8c6a55mr6015331edx.181.1660757134895; Wed, 17 Aug 2022 10:25:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660757134; cv=none; d=google.com; s=arc-20160816; b=s5dO0VlakKqTBPk4j8XMi3QR2TlXtk1cPyK4+q9pjlSvGph1Aayc0naf5Ch/9LafQx Hh1R1G1rxzdbbnXw3o5WtYvEkBQScIFt3pOCe+8WKiWMMfur2bahTwMJaVteNYVh8+xa Pj6v+xRsigWqg1GMWyHMPblEHyzQnk1kamU98D/g+qNpRFypsH0ev1Klp5L86aoBZ1F7 dmLv0FYgRstYeRNn7HH6QAr/pMqiVmH7JJ1nXoAmY3LmAUBwRqwFgxYdynt8s1XBjN9K 6XG4XAiSNjcBEqqOV8VbOb9flQJqSXauj16sAV8O2u+YCP1N3guqNJxOfz+sd12OLtUh I6Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GM7xEfwIL/rtVq+hrRvQ1hKtp4szoR86mfFhzUxnc2Q=; b=EV2lsj/HyjyR/DzUzfdEjN1/8p66Wbe7TFEIYCkjbcbLAaYmPsdPv/azgMnfa6jc04 X3aAQPNQfZ31gP20tEtzObYtjoRPDtUNOqJgbeJfuE7Zeb/t7Ew8PnpnH8owFI/96KL/ jVGlkgmFrqPl4gpVDbmn9XNxia5QE1nGGQNM2ycu/mMKZucbYb6sgENlu4AjZwCKreJ2 WxTNwYc3U9sK/7J6H4E/DmpbJ4qD86A2kaZK5VSSwwzWkC2LitSCs4G7dabThb7WqSh+ IK1Up64NMqrEf/cuA1/WbtzGfYo/Dtv80/fdqXiYdWpayZAd4Mh9W8SEAzj39dBR26Hr 4pxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qk6gFmwc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cr14-20020a170906d54e00b0072b3b1c0a90si792264ejc.339.2022.08.17.10.25.08; Wed, 17 Aug 2022 10:25:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Qk6gFmwc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240476AbiHQRGF (ORCPT + 99 others); Wed, 17 Aug 2022 13:06:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240735AbiHQRGD (ORCPT ); Wed, 17 Aug 2022 13:06:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2495C98CAC for ; Wed, 17 Aug 2022 10:05:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1660755957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GM7xEfwIL/rtVq+hrRvQ1hKtp4szoR86mfFhzUxnc2Q=; b=Qk6gFmwcztZi/pyhapHCDwe17a5LB9wwX3MeiW66I9bpAvv47mdA7aw8+RDHLZQS5BDhia A0UOWBJyKbAEYL1/yYv2KHyTzrs3IBEslSLNMGGIb+gEUfQWeuTW+PQjZnn84MXKF/DknD tFqzPnv4PtNaDFn97PRQMsSXELBkKI8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-518-HmK02LtVMFeV_etqxEXP4g-1; Wed, 17 Aug 2022 13:05:56 -0400 X-MC-Unique: HmK02LtVMFeV_etqxEXP4g-1 Received: by mail-wr1-f72.google.com with SMTP id r8-20020adfbb08000000b00225239ce4deso633603wrg.1 for ; Wed, 17 Aug 2022 10:05:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=GM7xEfwIL/rtVq+hrRvQ1hKtp4szoR86mfFhzUxnc2Q=; b=CC31z4+DVMDL5p1ywuojMEnresavZWFXcBnz0OvN/fGrUdta1oUKTZ7lnCghAnRXAI RXHxs+DFpuwV3A955FXf/4tMe/ZdisTvqQpQiJrF0ybc91AxpvOImndqVfgNASnBfMF1 8KS53X4mZdbVplj0jKd9dSsSOK11S7biTMr73U9f35JVbzdwLA1PevxxAKn5lDoQs+ob Coyft0h43icU3Zr3qpTqlXlrS9lWnq0WxLuQCzgq+220gmkWxBUrt1noSbuiq98DjHA6 Of9xfXc89T8jl0IexAw7iq15KPcpwprpO9C/AZ825lLUX/+vu9/5wYKjCoy6WrDhm3Cv YE/w== X-Gm-Message-State: ACgBeo19R8xDLZrYqGeQTE5ilPiFTXMMLz7WS4gtsfJIgRJ4IAOmNQJw flDLGOfiyhYeCUjptTtbgjxLpOHyYeoQrlATQSSbFyu/HNr75ofR6/gk3We12+u8rQP+MS41L0q st//MGS4dU+EzYPHqCbo8bl1j X-Received: by 2002:a05:600c:4f4f:b0:3a5:a530:4fd7 with SMTP id m15-20020a05600c4f4f00b003a5a5304fd7mr2807118wmq.36.1660755955453; Wed, 17 Aug 2022 10:05:55 -0700 (PDT) X-Received: by 2002:a05:600c:4f4f:b0:3a5:a530:4fd7 with SMTP id m15-20020a05600c4f4f00b003a5a5304fd7mr2807106wmq.36.1660755955238; Wed, 17 Aug 2022 10:05:55 -0700 (PDT) Received: from redhat.com ([2.55.43.215]) by smtp.gmail.com with ESMTPSA id m9-20020a7bce09000000b003a3442f1229sm2645479wmc.29.2022.08.17.10.05.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Aug 2022 10:05:54 -0700 (PDT) Date: Wed, 17 Aug 2022 13:05:49 -0400 From: "Michael S. Tsirkin" To: Will Deacon Cc: stefanha@redhat.com, jasowang@redhat.com, torvalds@linux-foundation.org, ascull@google.com, maz@kernel.org, keirf@google.com, jiyong@google.com, kernel-team@android.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, crosvm-dev@chromium.org Subject: Re: IOTLB support for vhost/vsock breaks crosvm on Android Message-ID: <20220817130510-mutt-send-email-mst@kernel.org> References: <20220805181105.GA29848@willie-the-truck> <20220807042408-mutt-send-email-mst@kernel.org> <20220808101850.GA31984@willie-the-truck> <20220808083958-mutt-send-email-mst@kernel.org> <20220817134821.GA12615@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220817134821.GA12615@willie-the-truck> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 17, 2022 at 02:48:22PM +0100, Will Deacon wrote: > On Mon, Aug 08, 2022 at 08:45:48AM -0400, Michael S. Tsirkin wrote: > > > > Also yes, I think it's a good idea to change crosvm anyway. While the > > > > work around I describe might make sense upstream I don't think it's a > > > > reasonable thing to do in stable kernels. > > > > I think I'll prepare a patch documenting the legal vhost features > > > > as a 1st step even though crosvm is rust so it's not importing > > > > the header directly, right? > > > > > > Documentation is a good idea regardless, so thanks for that. Even though > > > crosvm has its own bindings for the vhost ioctl()s, the documentation > > > can be reference or duplicated once it's available in the kernel headers. > > > > > So for crosvm change, I will post the documentation change and > > you guys can discuss? > > FYI, the crosvm patch is merged here: > > https://github.com/google/crosvm/commit/4e7d00be2e135b0a2d964320ea4276e5d896f426 > > Will Great thanks a lot! I'm on vacation next week but will work on it afterwards. -- MST