Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 10:19:16 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Beniamin Sandu <beniaminsandu@gmail.com>, andrew@lunn.ch,
        hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfp: use simplified HWMON_CHANNEL_INFO macro
Message-ID: <20220817101916.10dec387@kernel.org>
In-Reply-To: <Yv0TaF+So0euV0DR@shell.armlinux.org.uk>
References: <20220813204658.848372-1-beniaminsandu@gmail.com>
        <20220817085429.4f7e4aac@kernel.org>
        <Yv0TaF+So0euV0DR@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 17 Aug 2022 17:12:24 +0100 Russell King (Oracle) wrote:
> On Wed, Aug 17, 2022 at 08:54:29AM -0700, Jakub Kicinski wrote:
> > On Sat, 13 Aug 2022 23:46:58 +0300 Beniamin Sandu wrote:  
> > > This makes the code look cleaner and easier to read.  
> > 
> > Last call for reviews..  
> 
> I had a quick look and couldn't see anything obviously wrong, but then
> I'm no expert with the hwmon code.

That makes two of us, good enough! :) Thanks for taking a look.

> I build-tested it, and I'm not likely to any time soon. I think
> Andrew added the hwmon code for this PHY originally.