Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6d6df27f-a5c3-d6dd-ac1c-1d1c0fe53aaa@kernel.dk>
Date:   Wed, 17 Aug 2022 10:44:16 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] eventfd: guard wake_up in eventfd fs calls as well
Content-Language: en-US
To:     Dylan Yudaken <dylany@fb.com>, viro@zeniv.linux.org.uk,
        bcrl@kvack.org
Cc:     linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
        linux-kernel@vger.kernel.org, Kernel-team@fb.com
References: <20220816135959.1490641-1-dylany@fb.com>
From:   Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20220816135959.1490641-1-dylany@fb.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/16/22 07:59, Dylan Yudaken wrote:
> Guard wakeups that the user can trigger, and that may end up triggering a
> call back into eventfd_signal. This is in addition to the current approach
> that only guards in eventfd_signal.
> 
> Rename in_eventfd_signal -> in_eventfd at the same time to reflect this.
> 
> Without this there would be a deadlock in the following code using libaio:
> 
> int main()
> {
> 	struct io_context *ctx = NULL;
> 	struct iocb iocb;
> 	struct iocb *iocbs[] = { &iocb };
> 	int evfd;
>         uint64_t val = 1;
> 
> 	evfd = eventfd(0, EFD_CLOEXEC);
> 	assert(!io_setup(2, &ctx));
> 	io_prep_poll(&iocb, evfd, POLLIN);
> 	io_set_eventfd(&iocb, evfd);
> 	assert(1 == io_submit(ctx, 1, iocbs));
>         write(evfd, &val, 8);
> }

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe