Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 10:26:19 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>,
        Michael Ellerman <mpe@ellerman.id.au>
Cc:     "Wang, Haiyue" <haiyue.wang@intel.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "david@redhat.com" <david@redhat.com>,
        "apopple@nvidia.com" <apopple@nvidia.com>,
        "linmiaohe@huawei.com" <linmiaohe@huawei.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "naoya.horiguchi@linux.dev" <naoya.horiguchi@linux.dev>,
        "alex.sierra@amd.com" <alex.sierra@amd.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v6 1/2] mm: migration: fix the FOLL_GET failure on
 following huge page
Message-ID: <Yv0ku1mn4LBzg/zG@monkey>
References: <20220812084921.409142-1-haiyue.wang@intel.com>
 <20220816022102.582865-1-haiyue.wang@intel.com>
 <20220816022102.582865-2-haiyue.wang@intel.com>
 <20220816175838.211a1b1e85bc68c439101995@linux-foundation.org>
 <BYAPR11MB3495F747CBF95E079E8FC8A5F76A9@BYAPR11MB3495.namprd11.prod.outlook.com>
 <20220816224322.33e0dfbcbf522fcdc2026f0e@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220816224322.33e0dfbcbf522fcdc2026f0e@linux-foundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ikx6g+9RNz+27AGzUckka+bLqG9KIc+/IcZPdqOHy8qJe8eG7YthDm3daJ5I?=
 =?us-ascii?Q?Vnv9EE7ufxXEZqDL0QaLzcu2YjEKMWpLaR+1PrkMZcjCbf8VfIQjAb+jBDWv?=
 =?us-ascii?Q?rEg18/pf6BkQv7xoEbanVscTdsCd5iZ4Zn2mii5bEbsqyhNeEvULbKGNBbjA?=
 =?us-ascii?Q?DKdDCn6bEuWlZTJ3zJZqtudwuBmpBTe9pYH1tvAU7tigKW4NjNgX7RHkPmhG?=
 =?us-ascii?Q?6ZiLSHidD13mzYyHq3gGQGP6QW4mAB36ymJtVjM9oNWe1ms6H1/qXOf0kW7E?=
 =?us-ascii?Q?Xcb+eKZdawZQpkypB539JYeQ+o04niuputLn8b0J6l0PLhlYs4VDfQtMZ0tC?=
 =?us-ascii?Q?KrFs2sPUvNfQOkieKdj/a6oUpf2VkpZTyM/t+r6Ns4sGBZou50dNdBn49V46?=
 =?us-ascii?Q?yhaX6yn1UZlq6W/T17abYW+nz9qx97NhN969vINk3A38ajofOSsiYz07uoC0?=
 =?us-ascii?Q?cPWbVe27YAtb6Hw3QLg6AircPoeP3B1Sf3/b+PaQV6nx5Mfblp7v1f2M2TjE?=
 =?us-ascii?Q?XCtdAcIc+w1JjbHMMgpPWqwYPq9wI5JSsXY7UJTLOUJ/uPc9UrA02k7K4BAO?=
 =?us-ascii?Q?xIERxJNV4zF77IZEJvkHWfQgY8CBgcpPp06uiZ2MJM2x/HQWW64UHcqFqE2R?=
 =?us-ascii?Q?a+Ngduq7IdwNvGQvjf3bJvHVqceBm8yp4Ri8a2/l4BjxbqtYbyCBE+aJa2wW?=
 =?us-ascii?Q?m6lksE6PgO8b/cd9xBFCJfRIO/Q39ZRlKFHaNSapNmgA8X+1tjwDYvVT7tYM?=
 =?us-ascii?Q?+mtRtHH1J472aNcPk1WSS+P8xS5bZrkJxtqovPEUc2aEszZy17b2BwYtesSl?=
 =?us-ascii?Q?o3+pe+noWzeWu67XuT76GlsfchDJGWCwupyTHF+HWX6MVtYCrY0gG6G4jR2V?=
 =?us-ascii?Q?0qhez+wlSwecrK46kWnklCkSn3j+zMKFGmfvM7LMFeGp4t5mtHItbEB+q/q6?=
 =?us-ascii?Q?Qzj5HI4VP1Xe05fEocTxZnj16OmQQ/F+C+llz+t6P6cYKcmXa8wn8guUJ7qH?=
 =?us-ascii?Q?mlZHuP822sOde+CY63Bh7mjC2sqzDuQL6cIwnEooa648NN+rJzs9j9BRMhMV?=
 =?us-ascii?Q?Mm2VQ0K3rGAM76vWZ/E06I0n0CyJhQLfvBwe9txr9SxzlMmdGSpSwTsOQnDr?=
 =?us-ascii?Q?+x2ijaNwTFSPhes2uWD+t+qpTPFR5oTWCISHe+siovZLtwQvj9q9xXHJxV0p?=
 =?us-ascii?Q?8MjlXPbYxiu4A8JkssnhoJKrsd7XZVt8ovpg+WePKtfUr/mOJN+FnRcxPBbg?=
 =?us-ascii?Q?tFMf4sP7BA7cjUx9ra2vU3SjWQ6yjLJuRrzSryCi+yZxWW6yWzakHbB2Kykh?=
 =?us-ascii?Q?qdIN5pef13KvfI0e+L/3CXLUirmPIsyB0uTcGEe/p0vCZ8rk5vlgFwRqI3xA?=
 =?us-ascii?Q?FJTM/GmrCablcX9PR3vo2XeNYrrYLMrCKvlVz1uk1ZQAnop53XRwmqalQpny?=
 =?us-ascii?Q?R/aBeMLtS37OBwJFD7yi6Kx5fGeFjzlm/tTYihThwzoXWErlpYK72nqTiq3Q?=
 =?us-ascii?Q?F4WXAthYeI/Bju54p9X0N896WhH3Us7L3Y/388wl+oWYyglJlmLMRvYnSp9+?=
 =?us-ascii?Q?kUx+pCfVCjBqo4VhpsGq1wZIyQL2R1UjcyopDetFt9JlSjt1GsVdXeN7iTUz?=
 =?us-ascii?Q?CA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?MUiLKYyxqHeEcJB8BomFAIDdLWfy2xT1aZeJEQpQt6nxbAwy9qbR3xNCtiHp?=
 =?us-ascii?Q?cEzE86PSpLo4BjGdyj1v4HbKY2e7KgxMNLKxPjcuS3gWTYHOs6Wi6RjZjKgl?=
 =?us-ascii?Q?5uzmxEEv0S0HPKy/FWaoTPC9imcRlS1AK3An4FR/6mIpv014Ijc+qQpoTnNK?=
 =?us-ascii?Q?aNFhHsQvkklVFuYlDQGx/JPyPJ3lGXHF0RLFlJd/MumNCZf+phYWcVvPC/ae?=
 =?us-ascii?Q?0oZPg257Bs35+2o82oZ9N3FQlQ1YBHY2zF22DDJ7S9eg1yEoSzFZRD0dqsQs?=
 =?us-ascii?Q?bLHMvUd0IVx9P32shLdnTbg1O1fE2oI3x33wftUBDmsjFWx4cBZPYTm7eDqL?=
 =?us-ascii?Q?ivdXM9Nm8bTlTkhjcr0CjpTeWyVaojjsDejS0zmGn8iPlcYTwBZWEw1QZc6z?=
 =?us-ascii?Q?0kdQ8O9XESjbEfmcobgwA0IlRgtri3XgyBdbjcKdL20kzaTUMIjcvmikPZYm?=
 =?us-ascii?Q?8DijzfJe+6XLY5jltX1UoMpWhN8wWKivrHxUtGmUnWUNKtymG114EbXG7M7l?=
 =?us-ascii?Q?5HrigbPPk4fUPcC9Z98GvoQkxrpxwDxpS2/d80KvF3qhwaRta/5gGyaz/S6T?=
 =?us-ascii?Q?j4ifMFaBNHeKJGUh6W5fDGjpOtZcpjwkv9maCrDU+ygSmqLBRga3v1mNfAkH?=
 =?us-ascii?Q?KnRnqDHL9zVeTho2fiRT2FqMvlck/L9at4zPbi5Wsf9sKeSjsXJbbadwCuxh?=
 =?us-ascii?Q?cu5MblyqHjiagY5F508gzQ0UJRnM+upJDozmIRAycuRIdse6ul2ncIKn6ZOB?=
 =?us-ascii?Q?JMdWdd7KhY4QbZAt+pcnP7N2We0lK41tsYvzWKli4VUKGVlNWGcmwlRm9BtM?=
 =?us-ascii?Q?i2gMp5/fHsf7Bi5gT7x3Q2OywSGO3xe6wamk9tMncnigZUSfw7RJEh+x8wST?=
 =?us-ascii?Q?aU3qFqhVFIaKHerJqxemIwPYQP8J4QLi8n+c6jfJ8cAmT1Pbr4zbQF4oNWCh?=
 =?us-ascii?Q?KgfUoOMz5GTaREN54pIuDyvqmcOqeLjGKoTTz0fG0DECk0E3xgatslcHdLGb?=
 =?us-ascii?Q?FQDvqd71EPLaGtBysq+i+bRVvOvPwoDvu4sKcMbKfWQ0RFucli15EfjbLXad?=
 =?us-ascii?Q?oy84fW0hrJ+SABW1LYnKPmrgaturpHFnMMnvCRlWSXPtSJrzV02irEd3S6nn?=
 =?us-ascii?Q?dYNUUpx5si/OTOKi5RHBz6ZjKBH37R0ssnnWz8/M7nGv8tT57OTPyOmKJrHT?=
 =?us-ascii?Q?qiPQ+97PuDqEfx1B0pqoKWxiouVHwwe0mq34c3j0YVnz1Av2V3t2kHa1tsmE?=
 =?us-ascii?Q?Warxom7gqUYP3Un8c82nZ0JFDMYmfNSoHS72hy/PSQnroUmVg5hZim0LvHT0?=
 =?us-ascii?Q?xdaHz64qjMrXTzMSEg/We6yE3prSlW22YsYvASobdIuRTIIjXZZFzxBYIEkv?=
 =?us-ascii?Q?Aa480AcyIQP6FMBNIZWuKOd4GN56okNX8Kjptm71iqAQ2wajKTfFilwlNYZn?=
 =?us-ascii?Q?lVSNOIIs2eMkDm/VjyODtAJykzj6/UrI4l6LhJ7WN6yBmDBN4ZvQnjSYuwIm?=
 =?us-ascii?Q?sLvg7QIMeko9gG77oZCv9MVskIQ575T8uOm9ajVAaZdpeMv1cJIdx4zLfp/d?=
 =?us-ascii?Q?MicI4Wu3ah8U5CLyGFPaJDi3sEaL4cGCrvIFBeX+?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c76d7d3-2a85-4cb4-30dd-08da80759b15
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 17:26:23.1326
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Qq0d6Mx3WxXDHP9Ic6qWCmxyVDufZQHpe5cS33oP4ag+sDMyoSeDy1qn2eLGw9doAcaJVteWrVKY1Rjkz9J2AA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2051
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-17_11,2022-08-16_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 phishscore=0 suspectscore=0 spamscore=0 mlxscore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2207270000 definitions=main-2208170065
X-Proofpoint-GUID: 6nSxvZlqdt22b7nWlL0uOvgBqVzqrt0M
X-Proofpoint-ORIG-GUID: 6nSxvZlqdt22b7nWlL0uOvgBqVzqrt0M
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08/16/22 22:43, Andrew Morton wrote:
> On Wed, 17 Aug 2022 03:31:37 +0000 "Wang, Haiyue" <haiyue.wang@intel.com> wrote:
> 
> > > >  		}
> > > 
> > > I would be better to fix this for real at those three client code sites?
> > 
> > Then 5.19 will break for a while to wait for the final BIG patch ?
> 
> If that's the proposal then your [1/2] should have had a cc:stable and
> changelog words describing the plan for 6.0.
> 
> But before we do that I'd like to see at least a prototype of the final
> fixes to s390 and hugetlb, so we can assess those as preferable for
> backporting.  I don't think they'll be terribly intrusive or risky?

I will start on adding follow_huge_pgd() support.  Although, I may need
some help with verification from the powerpc folks, as that is the only
architecture which supports hugetlb pages at that level.

mpe any suggestions?

When Naoya recently modified follow_huge_pud, it ended up looking very
much like follow_huge_pmd (as it should).  I expect follow_huge_pgd
will be similar.  In the end we may want to factor out the common code.
However, for a backport it would be better to just modify follow_huge_pgd
and do the cleanup/condensing common code later.
-- 
Mike Kravetz