Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp5198311rwb; Wed, 17 Aug 2022 12:56:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR72ec0ccnsbtckOkhubRxxtXgA9vX9J6UnuKtm9oE5mglbVFQ2+5YH4y6Pf74wOq5+e/Vpq X-Received: by 2002:a17:903:2341:b0:16e:e205:bb3a with SMTP id c1-20020a170903234100b0016ee205bb3amr26885228plh.10.1660766199297; Wed, 17 Aug 2022 12:56:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660766199; cv=none; d=google.com; s=arc-20160816; b=ma0Z4UpsvkC0dyPf3ux4+OKr+hKLYv/6aYTIdf1D7e2sFZ7HZVAMBvymQoucAFcJb2 IJj2agGjRMT0WHLPwpGHPqtKd7ZY3RFkkLNfy8+CXD2YxEjy9Hm/mSkz8kSz6e9ZLpgs oR/yijkaZImg725kdNK+KpH8Zk87iIkoFIHsLV+yR00CqwaDBCmU7+IYaRyTRAu1KvRz ycMaYgq8qiypQ1peMsHgEj6SCGvHvhf4DbFwmluuB+s5lh8jGFDJWLll7dKdUSFKkNif hilWtNRfLjJb/Oa8ouX+cC2gnZjOc2Rpvszc1vekylEq6atq9bwVJYe5fskIKSR8tejU lhQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=bTvGBTSz62KcOrmTp94AS2vpPvLuOut0Rj2szlvPEPs=; b=CxNoScgRidI4ZlbzwVoh4L5hLN8CwBuc/EjrJ7NY8g+CIm1ahiBjAAD3VNEnqrL0x+ cpoQHrQKvny84yzTdL2R6wi1AXuNCI+cQmkPZCbKOr7HCB/YICzrIuTqwBl5wU8ho6nA Yv8Qhz09jP2R113qOvLfO2B+Ob4AaEGr+PIsDe5oXO/85FjvoiTzmae0fdAN9Rf6aLig tRu1OaMrCkHFGwG9/aLHBJm7phU9l9FWWTDW0tJQ5t1MVF7fe5dqQWnYHpHKccvrM1ag P63sSVqmRfSKTA5pwPWN+DJZjCS91UF1SoQvPhEu0bYLYWwIoqNVXBOfEGLjQzBOCupq z52w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bAfkLGol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y23-20020a17090264d700b0016d1400b043si528691pli.395.2022.08.17.12.56.27; Wed, 17 Aug 2022 12:56:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=bAfkLGol; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241357AbiHQTrb (ORCPT + 99 others); Wed, 17 Aug 2022 15:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238462AbiHQTra (ORCPT ); Wed, 17 Aug 2022 15:47:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED6D11C8 for ; Wed, 17 Aug 2022 12:47:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8BD1661480 for ; Wed, 17 Aug 2022 19:47:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D158C433D6; Wed, 17 Aug 2022 19:47:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660765648; bh=RlznfQgTn+Zb69qUdCkZoQUpTrnL73CXphk9kJNJFHY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bAfkLGolSdo3TKS9rqeOUu76NFl9PJTUgF4T2R4WoLYhjeCpFLXiRnUVRfzuj9OUg kQqk1/dsTB4P+KsaUO5GCu2QyzJ5V3rgDmNbTq6rTXBOCErMbtNH4CcWb5oX8CtJ1R ITfOPhAr3lMAeN1NumI2wbmHQVeX/xyteeCCpHTAq5RjydUNz1dcn8a0IvVzZdyfpm RlUa3g4KVQGKI1y+xZZSVLhXaWeTZhCQ2MSB85hAWJYF7mxvneHSoRIhM8kqMeNhO5 TDOKrMMG36wCVLTZCaf7llyiZDrYZskC1+MIhnHMlRJL97sUzJhdyVasjOQfeFhAmF EdsRIKabPWzRQ== Date: Wed, 17 Aug 2022 21:47:22 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Vinod Koul , Kishon Vijay Abraham I , Linux Phy Cc: Andy Shevchenko , Daniel Scally , Gregory Clement , Heikki Krogerus , Kees Cook , Sakari Ailus , linux-kernel@vger.kernel.org, pali@kernel.org, josef.schlehofer@nic.cz Subject: Re: [PATCH linux-phy 3/4] phy: marvell: phy-mvebu-a3700-comphy: Support changing tx amplitude for ethernet Message-ID: <20220817214722.461b18c1@thinkpad> In-Reply-To: <20220817193119.4463-4-kabel@kernel.org> References: <20220817193119.4463-1-kabel@kernel.org> <20220817193119.4463-4-kabel@kernel.org> X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Aug 2022 21:31:18 +0200 Marek Beh=C3=BAn wrote: > +static u8 comphy_find_best_tx_amp(bool full_swing, u32 amp, u32 *true_am= p) ... > + tx_amp =3D comphy_find_best_tx_amp(tx_amp_mv, full_swing, > + &true_tx_amp_mv); OMG, I changed the full_swing parameter to be the first one at the last minute and forgot to also do it in the function call. Will send v2. Sorry. Marek