Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v3 3/8] arm64: dts: ls1028a: add flextimer based pwm nodes
To:     Michael Walle <michael@walle.cc>, biwen.li@nxp.com
Cc:     leoyang.li@nxp.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, olteanv@gmail.com,
        shawnguo@kernel.org
References: <DU2PR04MB89497E16D2E9A01BF763D92B8FEC9@DU2PR04MB8949.eurprd04.prod.outlook.com>
 <20220728093318.299798-1-michael@walle.cc>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <a575ac76-89f1-cf62-37a4-9f8190682910@seco.com>
Date:   Wed, 17 Aug 2022 16:20:21 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20220728093318.299798-1-michael@walle.cc>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTFXNlV4QVJ3SFpkU3Boc2dobkFQN1dGeDBqL0s0MFlDOHhZSUN6QkRHVzdU?=
 =?utf-8?B?L3FnT2tsU0RRdTFLZXZGMzdiVnloTTBnT081SFVzYUE1N3lKVENKRWdWTFNo?=
 =?utf-8?B?dmYwK21teGtLWXVOekNCNUx2Qmk0UjlHSGMzZ1ZmZDdyenlQLzdsejdsVlow?=
 =?utf-8?B?aVFoMWVpaHd3eGtRMW5LeXA1Zm42UHNmSVk1RmpoS29xTHZPVDNqKzZRcERl?=
 =?utf-8?B?QzVwYTI2M3MrSzFucHF6c24wUlBvQVlTT05pdC9rcWdITkMwamRHS3F1aSs2?=
 =?utf-8?B?NWViQ3dsb3lOWHFwSnhoY0VjbjZKd1gybG5sL0N4Uk1Ha1c5cFEvNDUzSndI?=
 =?utf-8?B?aUd0MWtmRTM1K2Mrd2lQT2xUakpqTkpZNFBTbEhIVFJSVjJwYWVnVnMyTlBl?=
 =?utf-8?B?ZDA2Q0xBa2VaajB5ZkJ5Si9LRWJKaVpTT0tYdW1NcVRTQ0kyckZBSXNIQjhX?=
 =?utf-8?B?aUtRWXVGN29mS2xNQjlQYytsSXV5Vkc4NUlkMVpsTHRPLzRxZzU3Q0FuVklk?=
 =?utf-8?B?Um8raHFLQnhtN3ppTm5ETUpNeEpuelEzdU02M0R3VVo0dmhhRDhKZ0RvVjRW?=
 =?utf-8?B?OTVXaS9QRVVvYTRpNEhrOHROWUhxT1MzS1EvelNOYXp6UlFNemRlaEhQWFZZ?=
 =?utf-8?B?M1dxenpZNTVZTFZWQmdlOGE4SXJpNzd3UE81N1Q1TDJkRW1vVlVLZExMcitX?=
 =?utf-8?B?SGg5YjdmQmEyNTJTK3V1NDhnbjloUEtzVitvZGp1NVRSczBuZXBFZ3ZUM2do?=
 =?utf-8?B?Z1VyQTRWMFlWM0lURHdqWDduOXJLckxFeWdXTzhUUTZXekRrdnp3MHlmd2lh?=
 =?utf-8?B?K2JjZ3pwWUxzTXJhNHkrOXp6U0lhbStiTGhwem1sS0NIY0RpbGI5WURySFQ2?=
 =?utf-8?B?SmxTTlp1NWdKdDhQL3hESXB1YkVRbTJ4bEtkQzlEZ3lwQm9BdklqMUJSV29Q?=
 =?utf-8?B?cjM2RXdnUHdxdmI3eE90bkpsb2ZRSXR4cTVHejVuWS9EVWRzbWVuZDVzVUdP?=
 =?utf-8?B?WHZ5L1E2c0JmSHFXMWx6eTV3SWJBcU5jYjdCazcrSzI1M3Y1WWpGRnJyOTh1?=
 =?utf-8?B?Nm1WMWZubGorenlHYVNZakdmamFpRTFJTzFYZ1lUYU9RamVyaHV2MC92Sm5O?=
 =?utf-8?B?UFZ2NE9qYVRzNVV1T3FGV0YyYjF6SzJvVzdOUVlnbmM4aEFuNDB5VkFRWU9T?=
 =?utf-8?B?TVFyZGhaSGk4UmNGTEJEVXJZTmdMQXRJNmRKWmxvcWVmS0Y0RDAxcHRpbC9o?=
 =?utf-8?B?MGl5RDRNM3hLdXVjdlU4WDFSNW0wQWpMUXZaeHNwYWlqUzhTNkMwMEZib3JD?=
 =?utf-8?B?VkZHRENCZ04ySVA0Z21PL2Y4NFBkZmsvdnpDU2EyOUlVSytscVh5Z0NmZjZG?=
 =?utf-8?B?dG5JaUk2clZqR2Zscm1EK2NvL1Q4bzZpVU45Ump2S0NzQkJIazFvOVRwUVpv?=
 =?utf-8?B?YW1IRTR4V3VYYVBhVi9tSEZ5YnFrdUxjNXJvOWNoUlRYc0YxTUdwdXlLOW5E?=
 =?utf-8?B?Rk5xRUZJalZmQTdqNHN2TkxpY1JsRzdxVjR5RlI0cW94RDRXQ3lTaFdCc2M0?=
 =?utf-8?B?STdtN1lnenNidFRhem45T2YxQmlYZWZqbW8zekxzU0FYSU95QW5HbEI4cnhI?=
 =?utf-8?B?RFdUZmRYaytZOXM3WDkxdTVHWm05Uy9xTHVreWxqRmYyckpRVS9jNWU1SjlJ?=
 =?utf-8?B?RnlnNndmWWFoYzZLenJQNTF1Ynl2Vk95NlRaZHozMkhZZDl2eENLaFNtTU84?=
 =?utf-8?B?UkJaZktnSkpaSmhaaGxjMXFlWFZxNnVmcERYY095T2FYRzB5V3JWcnBYaW0v?=
 =?utf-8?B?MFM4a1lQWXV4QjZiK09HSHJXUWJpUVlCZkNqWEJqa1dXTHQzV1huZmRDK3dy?=
 =?utf-8?B?OVpKQXNvM3I1by81VHZmMVYxRlNBaitJaE9NbzhsR3RaTDJkUVFwajM5UGsw?=
 =?utf-8?B?cnBsOWM1RmF0MTJlUmUydmcxS0dCM2J2MnZaN1A2SXQzMU8rNkhvZlRWM3VR?=
 =?utf-8?B?elpUZm40UEh4R3hhbFJkVU5uczRMUFVBYjViTFgzekI5MmVsa3k2dmo2WnZ3?=
 =?utf-8?B?akprbVZkaWJraFpTSkVsYi9JcVJSY0hOUTdJRGVKc2lpMlNsZ3kyL3pnVWIv?=
 =?utf-8?B?UlFNU0tLNFpEczNCNC94TjhFMVFoRS9JWUxwSXpZc1VZSzZvd2M0VUFhSTRs?=
 =?utf-8?B?U2c9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af73958e-0a31-4505-2b0e-08da808dec07
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 20:20:26.6389
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Iqm2RmMBlOn6yxJsHukU4a50t+sDWSj4TQCyoE1OeMPcEpsB0GgfQghYhSEBmOJeOwS1TFwUsup2rUY2oc0bgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB4159
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Michael,

On 7/28/22 5:33 AM, Michael Walle wrote:
> Hi,
> 
> sorry for digging up this old thread. But I've noticed some
> inconsistencies here while syncing the device tree with u-boot.
> 
>>> On Wed, Apr 13, 2022 at 06:07:20PM +0000, Leo Li wrote:
>>> > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:1210.21-1219.5:
>>> > > Warning
>>> > > (unique_unit_address): /soc/pwm@2800000: duplicate unit-address
>>> > > (also used in node /soc/timer@2800000)
>>> > > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi:1221.21-1230.5:
>>> > > Warning
>>> > > (unique_unit_address): /soc/pwm@2810000: duplicate unit-address
>>> > > (also used in node /soc/timer@2810000)
>>> >
>>> > Well, this is similar situation as pcie.  The flextimer controller can
>>> > be used as timer, PWM or alarm.  We have separate drivers and bindings
>>> > for these modes which resulted in different nodes for the same
>>> > controller.
>>>
>>> I think the mfd framework can address the situation where multiple drivers,
>>> with multiple functionalities, want access to the same memory region?
>>
>> I know mfd is used for device providing multiple functions at the same
>> time. I'm not sure if it can help dealing with the one function at a time
>> scenario.
> 
> Funnily enough, I had the same concern:
> https://lore.kernel.org/lkml/92eaa24876a823aa5833435f51095812@walle.cc/

(a bit late, but I didn't see this the first time around)

One alternate approach is to do something like commit bc1ce713a084 ("pwm:
Add support for Xilinx AXI Timer"). Both arch/microblaze/kernel/timer.c
and drivers/pwm/pwm-xilinx.c are drivers for the same device (and have
e.g. the same compatible string). They determine whether to bind based
on whether #pwm-cells is present or not. This avoids having two nodes
with the same address, since one node can be used, with an overlay (or
an included) used to specify the function. It would be better to defer
this to when userspace can have a say, but timers are probed very early
on, so we can't do that.

For the pcie device, perhaps you could use #address-cells?

--Sean