Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <190edda8-1f37-0fa5-1cc1-ada97518698a@nvidia.com>
Date:   Wed, 17 Aug 2022 15:15:20 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: [PATCH] selftests/vm: fix inability to build any vm tests
Content-Language: en-US
To:     Axel Rasmussen <axelrasmussen@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>,
        Guillaume Tucker <guillaume.tucker@collabora.com>
Cc:     linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220817211356.273019-1-axelrasmussen@google.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20220817211356.273019-1-axelrasmussen@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFMzYmJrM1g3a3hSOWY5ckJSVGxnVnJmUjFCSVFJOXg0d2Y5MXFxOGc0ZDgv?=
 =?utf-8?B?Qm5HY0ZDMU5WbGhqbFgzQmF6RG5pUzZtSWZEWTMvK2M3QTREN2xneWFNejUw?=
 =?utf-8?B?OFNnU0VIS1g4L3QvaHVNS3V1bVRFN3JkL0xWUkM0TzJxTzlqQUo0c2lnSlZW?=
 =?utf-8?B?bEJUNDh6S0xPSUhUWmdWSVdrclN1Myt4Qlp4ak9JdTR1WFoyYU9DSXVDV2RW?=
 =?utf-8?B?SXRCd3BMaThGNGk3OXZ3Wkd6YVFZaEhpMjB0eTlDYVdZUzJhbHlwMXJBNGxZ?=
 =?utf-8?B?OS9uZFNQNDM2RGtiU2IyYndPNjBtYmYwVUd2d05mYkg5Q1h3MkFIQUkyK3k3?=
 =?utf-8?B?NXhaY3NtM20rVHQyK3ZsK2NjZnhGenZEaG9oZTNPd0R0VGlEYmRXOFd5Q3Vy?=
 =?utf-8?B?MWY5RWZheWJuYkpVMERSamFvbDRseFlmUnMvdUZQL3RYYmdiWVVqa1JXVG53?=
 =?utf-8?B?L01NazVZZWJPMkdrWFNRSVh1bC9IUEM2RGNzaVhXSjRzVUVlNTRmaTNKcDdL?=
 =?utf-8?B?VXdaTUhoSHd0N1RsN3N1VU1KL3NUMHRVYWRjTnM2VlM3eGJrQWplN0REREZn?=
 =?utf-8?B?VXNkYkFSMnIwV0V3Q3MyOGtXdU51bGFtMW9hZ0ZVMVVKbGZlblI1K05nTzBj?=
 =?utf-8?B?c2NiWjAxcEI5WHlOdEp5M2xMOG5PSDF2c3J3NFBwWlVMdDE0dWpCS2VUTzYz?=
 =?utf-8?B?REJrcFZTanhCQWVmbjJITmtSSVRoRzFDMEpKNE9XRmc5dmJtYlc4QzVacVhS?=
 =?utf-8?B?VUNZaHFtR3lNSWZ5blczaGlJSU9BcTEyL0J5U25rZVp4Y0N1cUNFeHFySGxM?=
 =?utf-8?B?VlFjT1Q2a3hrT0dYdzJUNE80b0tmZEl6ZWhnaWRhNWlWemNqL2hnMzhMc3B2?=
 =?utf-8?B?eWZiWmlNSkYwU3NHUGJzSFR4SmhLK3dKOTJmSHlaamwwMWpYUnRaZGErNXlk?=
 =?utf-8?B?U2F6Z3A1NUVyTXdDemVXWDJ2ZmNidzNTSUYxY1pkZ0Vlb3lVUDRRTFJiblly?=
 =?utf-8?B?VURvTlorNDd4bXcxNnNheVA0OEIxa2YxY0Z3Z21tZ1ZrN005Mk84L05rc1JZ?=
 =?utf-8?B?T2xJS094cTEyR3pFMnhhb25RcXhzU052R2tFZnE0UytwWmtJUGNtY1N5eVNZ?=
 =?utf-8?B?YWN2WmdRRDRCT2REMzBSY1oreVl1KzB4NkE2NHFOSnJUTHY0R0VIZlpVTlpF?=
 =?utf-8?B?Qml0bjRUS2EyT1lmZHBGdm9VdWFYZGROZTRDM3phRUVVNmZVMmlkbDlXTFYy?=
 =?utf-8?B?THdYVUJVNjNXbDE3VTcxNzJZU2RLZy9PRXZxK1Q1Um8ydWNKYVRkNFRZRlVF?=
 =?utf-8?B?TGxBalN1WEJsWE9wbjlIVlkwRWl1bGhCMGVQc1lWbVIxWjI2d3dKWHNLSkxX?=
 =?utf-8?B?ajNWdy8xWHluRHUxdEV4d04zbFlWemp3Vk5SRXdWVzBTOFgvbFhLQ29vQU83?=
 =?utf-8?B?VVZEV3FIUng3L0FmdkRQSTJ4Z2hmU2k5N3dwN2t2ZXV4OWhDWEtSOU9QTmJS?=
 =?utf-8?B?d0kxNlQ2eXFzV0ZKcFV2ZG9nSCtxZ2diMjA4WFRMUGtDdXJnVHZldG1YY2xp?=
 =?utf-8?B?NUpqRGwzN044S0dlRll6dHlWdWJEVGJBK0dMM01HNGxkeVE0dHZFQ3pxY09M?=
 =?utf-8?B?RjE3RnVuUHlUWGF3aThpVkliZTdrUG51TFdTck1qL2s3ZGgxOTZ5NmhOU2Zt?=
 =?utf-8?B?SUthUVdOOTVlZTJhNHRWZkdPQksvZFhVVHI5eXBhSHllOGpmcGJteWJBUElL?=
 =?utf-8?B?QUc2bFdjLy9LS3d1aFd5YjlhbnhkblpzLzhhcW55WVpPaGJkcWVtZlRLQ0sx?=
 =?utf-8?B?TTZzUEFBZmhWbE81UytoVllPSTJQR1JyRmxNaWRHVm54Rmhxa3JPSW5pMC9Q?=
 =?utf-8?B?aWFkYTg3YXNLVGc5bGRkQ09BeUhHdEt0dnNRTDdZYlN6Myt1K1FOU1ZGUkhJ?=
 =?utf-8?B?RjZiVkZZOGJKcHZsZDZ3a2RBNGNVeXdINjk2ZEErRHVRMFhGeGUxYk1QY3dI?=
 =?utf-8?B?N3drb0ZMWVdUZ0xacllqYUJPdHV5KzVOc2dRTHg1Vk5WWlRpMWNJdkgxTU83?=
 =?utf-8?B?MXJlbmpDQWNiYmZ1VmVMNitmRk1heTlqd0JoSVdVQVhINUJLYjJrbE9YUmU0?=
 =?utf-8?Q?FWqWQN8+ggTa8vdFZyoK7WD6x?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0b1f6373-6bbd-4489-12eb-08da809dfa78
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 22:15:22.8458
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KiC+pYUh92vAbC6yYSJ+7lIVamvVIgxXPwJWs5TZ8IaPdL+5x1YXQ//xtZKNESwKlSpcp/Oca2bdEsRpUwDHpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5644
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 8/17/22 14:13, Axel Rasmussen wrote:
> Fixes: f2745dc0ba3d ("selftests: stop using KSFT_KHDR_INSTALL")
> Signed-off-by: Axel Rasmussen <axelrasmussen@google.com>
> ---
>   tools/testing/selftests/vm/Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile
> index d9fa6a9ea584..f2a12494f2d8 100644
> --- a/tools/testing/selftests/vm/Makefile
> +++ b/tools/testing/selftests/vm/Makefile
> @@ -1,7 +1,7 @@
>   # SPDX-License-Identifier: GPL-2.0
>   # Makefile for vm selftests
>   
> -LOCAL_HDRS += $(selfdir)/vm/local_config.h $(top_srcdir)/mm/gup_test.h
> +LOCAL_HDRS += $(selfdir)/vm/local_config.h $(selfdir)/../../../mm/gup_test.h

Hi Alex,

Thanks for fixing up this build, it's always frustrating to finally
finish working on something, only to find that the selftests build is
broken!

This looks correct, and also I've tested it locally, and it works. So
please feel free to add:

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


A couple of follow-up thoughts:

1) I recalled that hmm-tests.c in the same directory also needs
gup_test.h, and wondered if that was covered. And it turns out the the
relative "up and over" include path is done in hmm-tests.c itself,
instead of in the Makefile, like this:

/*
  * This is a private UAPI to the kernel test module so it isn't exported
  * in the usual include/uapi/... directory.
  */
#include "../../../../lib/test_hmm_uapi.h"
#include "../../../../mm/gup_test.h"

It would be nice (maybe follow-up polishing for someone) if this were
done once, instead of twice (or more?) via different (source code vs.
Makefile) mechanisms.

2) Commit f2745dc0ba3d ("selftests: stop using KSFT_KHDR_INSTALL")
claims that it is now required to "make headers_install" before building
the selftests. However, after applying your fix (not to imply that there
is anything wrong with the fix; it's fine), I am still able to build
vm/selftests, directly after a top-level "make clean".

I believe that this is because the selftests are directly including
gup_test.h, via relative up-and-over paths. And I recall (and also did a
quick dry run, to be sure) that this internal gup_test.h header is not
part of the headers_install list. So that seems to be all working as
intended. But I wanted to say all of this out loud, in order to be sure
I fully understand these build steps.


thanks,
-- 
John Hubbard
NVIDIA