Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 17 Aug 2022 19:48:53 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     Lu Baolu <baolu.lu@linux.intel.com>,
        Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 04/13] PCI: Allow PASID only when ACS enforced on
 upstreaming path
Message-ID: <Yv1wVfCWHnTdvPOc@nvidia.com>
References: <20220817012024.3251276-5-baolu.lu@linux.intel.com>
 <20220817211743.GA2274788@bhelgaas>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220817211743.GA2274788@bhelgaas>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?45w6+aJE+WbNPdyGURTBfdtbbrghqEQ4X7X1m3FGDkphwF+qwgKabqs7BxBj?=
 =?us-ascii?Q?S1gmLpRnLN2iQEm+mucWCSqa2ogOdiFv7r4aw8axHO3pIUHd82EmxVB2V9AH?=
 =?us-ascii?Q?2XgOBaPkDBZaP+zWk+VQ/vudjGvN60UVGQntPBV2XGp+gzXQ4FDHwkTHMUS3?=
 =?us-ascii?Q?mJ65iDYQQsgJ1E6CtLltTryCCKM81UQxaK8o8+lXgOsMSIDQYc2zsPOAXFeZ?=
 =?us-ascii?Q?IacIb+vLPLlaDd0waQZkDVlG//m7g15yhbWfP74yMo6F2nxPkMaBNqeyyLKL?=
 =?us-ascii?Q?y9KqjX0U37ohfDHQzEaW0mSLvxqTSoWQ3N58lC0QIbO1Z+3ljueLC8m0mXKR?=
 =?us-ascii?Q?ByGGbtCyYGKQ9RD+o5LgS5G5b4qODY3SLuKhuMu6BtV7ExKxn83gmI0yx6yK?=
 =?us-ascii?Q?O5WGpS4ZAm0aoT2dVQIKN/2OoL/u2DI4fVyt4E502JcGaF0DhGm06RzwHvkj?=
 =?us-ascii?Q?Nf7440JcDxaNkGwH508bgK/CQIQBVXLiYbznS3KszKczLC3JhA2L1BFJJOkQ?=
 =?us-ascii?Q?kuNWqfSWsYd4BFI6WCP6n75/ujpTaiWbI82t1Q8u7CaKWcMGHq/13rRvxMz0?=
 =?us-ascii?Q?sAfw0+mwE9zqyYyHgAjgJhHoMLc/9RBShQLfmUvziwZqfRtodItw4+xcQpkE?=
 =?us-ascii?Q?HgUR58UG+Vr1a35UVme+oeBoXhQPTWKzOhNqhr6jwCRTvDARR2/wVjNlxM6/?=
 =?us-ascii?Q?4C7oZsLnEAb7lhKX8/kTMxcYLEfm8uTLBy/BxLSLbdjxxGtQhBfwd4G6DD9q?=
 =?us-ascii?Q?wOuVV/Z9nsN9qQAp6bHYPbs9sKttLMA6QG+BF198zm2Dksf5XhM1Zby3AMXG?=
 =?us-ascii?Q?SNPqwDLlCjHHXGMBixl/zv5ESsj535EELOZ5Ny87jRHQvMHOoEB4hsHSVNWy?=
 =?us-ascii?Q?KJlLWxzg/SxuvR0OU9tmiZJHtLBXPZwxltL52djFLnMtigumLpSg8jGr3Um7?=
 =?us-ascii?Q?/WWWy6LdZqbNWv2VShjWYuibkUmGdEwQH1076oN/o32cSpmEw2pDnuJwITBB?=
 =?us-ascii?Q?WvXza0EN8unsCb5PuJV/Erdhid+KMxZwm9U7KEYGeZsISkKgH1ilS80M0n4g?=
 =?us-ascii?Q?4SU9U0gFiGGmii97zeG04rKCeZTpbXtGYcl9t+oWj/AgcZkMbcdzB2wkrOGc?=
 =?us-ascii?Q?Ngz3mlubYQZoKk5LS/KE5ZydTEadRhyQT5JDZlDdsEapXB2Nlbj1TBpKZHyd?=
 =?us-ascii?Q?ba08n7hoqFo59TPrygUdLpAJycRK93QMPyYw+02+4boq3ZZxmmEA3vUDAJOv?=
 =?us-ascii?Q?SdKztr4nQjICUIhdzcQwsgX/aaQ0pmD5O3uXYZtKnExjJ6OHYN+6U1H21Btg?=
 =?us-ascii?Q?ka37p0qoBdgDUuz3ih/4HaMWFlKbBU3ASCzuPhKlQ9jC6cKvGxZLcCcmmdwP?=
 =?us-ascii?Q?h9hgC3/iZZZMlvB1gXILwl+UYsgmT8OnhEBYZVYgtJMZDJyEP+gCEV4pBMip?=
 =?us-ascii?Q?DnnBl84iPOIcDr2mBbsBRprZt1hY+IkXaq6rJnJ3sim0VcaAG5+CFli98/f/?=
 =?us-ascii?Q?sXs3lBxPv8+IocwZ89EUBRohIe2E/AsuJUgUwj8uyxdZqJ3xeI4LZSesgr7W?=
 =?us-ascii?Q?OVGh5nTRtyl0uAk8+AV21iUCg25fQpZHKhTlxwgU?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ae88bd83-1c4a-4d6c-3783-08da80a2a96c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 22:48:54.3563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iKHzaG+4oqr/vivDQeJThWK32DE6m6sjIzaa6pf29PAufUC86eDz3hgaK4UEcdXr
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3041
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 17, 2022 at 04:17:43PM -0500, Bjorn Helgaas wrote:

> Does the PCIe spec really allow TLPs with PASID to be routed anywhere
> except upstream?

I think yes:

 2.2.10.2 End-End TLP Prefix Processing:

 The presence of an End-End TLP Prefix does not alter the routing of a
 TLP. TLPs are routed based on the routing rules covered in Section
 2.2.4 .

Which I read as saying that routing is done after stripping all the
prefixes. PASID is a prefix.

Lu, you may want to quote the spec in the commit message to make it
clear.

A strange choice in my opinion, but there it is..

Jason